From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Date: Mon, 26 Sep 2022 09:22:09 -0400 Message-ID: References: <87bkr2mhj1.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38759"; mail-complaints-to="usenet@ciao.gmane.io" To: Protesilaos Stavrou , 58092@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 26 15:39:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocoKl-0009p1-SK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 15:39:43 +0200 Original-Received: from localhost ([::1]:43428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocoKk-0002QF-Nf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 09:39:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oco4c-0002SY-EE for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 09:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oco4c-00039e-6P for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 09:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oco4b-0003J3-Se for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 09:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 13:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166419853712645 (code B ref 58092); Mon, 26 Sep 2022 13:23:01 +0000 Original-Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 13:22:17 +0000 Original-Received: from localhost ([127.0.0.1]:49636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oco3t-0003Ht-DB for submit@debbugs.gnu.org; Mon, 26 Sep 2022 09:22:17 -0400 Original-Received: from mail-oi1-f182.google.com ([209.85.167.182]:46675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oco3r-0003Hg-Ut for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 09:22:16 -0400 Original-Received: by mail-oi1-f182.google.com with SMTP id g130so8147247oia.13 for <58092@debbugs.gnu.org>; Mon, 26 Sep 2022 06:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date; bh=vqmEObbO4l2pl4iWH60fy/di3NaUcwffs8B2UlqsMow=; b=EzlSTVR/3J2x3ki7kZnd22WpSNl55qIdA95PhFdDdeNkO61bRNAWjmSLdDUsw8/lC4 oq2rGm/Vt4FE7izHjAhR3HcF0jHthrj/w9aICudmtHq5rq08Ua+OkwhMdYogMAVGnCOW 0zqzXqBAzYmHHrIi1EwDrhUW1ld1aIciK6sg2pft6UHlePrO0Xvrab+mKCpz7hhv4FfX mc0qde/VyDfmZpnj6yxeiNtUi4LbKy/kvlLBoAPDG8X/ERcz9DrmZp6kE2kvwALruJam UX5yhnA/0O4HLMhRNOpMHRA+fw0cBBUYImjN2/xtR4iTuK7ZA3kZuCeVsoNNClEny3w0 HPbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date; bh=vqmEObbO4l2pl4iWH60fy/di3NaUcwffs8B2UlqsMow=; b=lFOBCXHpdNY261+4kULpdpq6WHuBrOYd9Pj50DQGAMqzdYr7LtUx9qFPxk+xoAPRH1 1CuKScnv4nVj35DxPcBS4/fXc7W/Yyg9Q1SgtvT58u7+9hj0qs7RjH+3LmOnrt93wDgA rBFuI2WhTaMPKKMRCJoHbeu5vVYGdq7ALUpfpnt2KGV/cdco+Dleej2+VecrMJCTppE9 NossWjlyoGgXljkQHw4g1A72SPUOWNkiKTapsptUzIsSd5bOaefOMqy+GYWqw1A/RjD1 yvSyz95Ljct0F7Sh4BXPaGSV3mL3h9seGjl2rtRmpYVW61yYKBYuIk3B93zka1yzdg6x CWpw== X-Gm-Message-State: ACrzQf2iSxzPK0f4iTuCnlPI4t2NdC30PzWgArlLNbrqAL0dM/v46odg cVh7ss1pLtR+bReJ3bjA3fjujoMkM13Xj2d/toyyGPlh X-Google-Smtp-Source: AMsMyM4sBZLGrtGFfSZDNyAQfOXqvPX9qDgsdwZ6Kh454RbVFBJM6UZ4AIjSX9QLLbUh5Ow87zAcQLFSzV33a1NNmTc= X-Received: by 2002:a05:6808:1688:b0:345:ea9a:2954 with SMTP id bb8-20020a056808168800b00345ea9a2954mr14941451oib.199.1664198530259; Mon, 26 Sep 2022 06:22:10 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 26 Sep 2022 09:22:09 -0400 In-Reply-To: <87bkr2mhj1.fsf@protesilaos.com> X-Hashcash: 1:20:220926:58092@debbugs.gnu.org::QctjnVY0uIqleEgz:4SrC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243657 Archived-At: Protesilaos Stavrou writes: > From ea287b3d918c6a2cf6181c5671187143b3774bd5 Mon Sep 17 00:00:00 2001 > Message-Id: > From: Protesilaos Stavrou > Date: Mon, 26 Sep 2022 15:41:18 +0300 > Subject: [PATCH] Add log-edit-summary-separator face > > * etc/NEWS: Report on it. This line is optional, but I'd put it below the main change and say something like "Announce the new face." > * lisp/vc/log-edit.el (log-edit-summary-separator): Add new face. > (log-edit-font-lock-keywords): Replace hardcoded face attributes with > named face. > --- > etc/NEWS | 5 +++++ > lisp/vc/log-edit.el | 6 +++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/etc/NEWS b/etc/NEWS > index 0a5b7bc29c..ced4ece35d 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1766,6 +1766,11 @@ Writing shorter summary lines avoids truncation in contexts in which > Git commands display summary lines. See the two new user options > 'vc-git-log-edit-summary-target-len' and 'vc-git-log-edit-summary-max-len'. > > +--- > +*** New 'log-edit-summary-separator' face > +Styles the line that separates the log-edit headers from the log-edit > +summary. I'd say: "It is used for the 'log-edit' headers ..." > + > ** Message > > --- > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el > index 5290616302..25b47a75af 100644 > --- a/lisp/vc/log-edit.el > +++ b/lisp/vc/log-edit.el > @@ -325,6 +325,10 @@ ;;; Actual code > (defface log-edit-summary '((t :inherit font-lock-function-name-face)) > "Face for the summary in `log-edit-mode' buffers.") > > +(defface log-edit-summary-separator '((t :height 0.1 :inverse-video t :extend t)) Maybe put the value on a separate line (in case we want to extend it later)? > + "Face for the summary separator line in `log-edit-mode' buffers." > + :version "29.1") > + > (defface log-edit-header '((t :inherit font-lock-keyword-face)) > "Face for the headers in `log-edit-mode' buffers.") > > @@ -393,7 +397,7 @@ (defvar log-edit-font-lock-keywords > nil lax)) > ("^\n" > (progn (goto-char (match-end 0)) (1+ (match-end 0))) nil > - (0 '(face (:height 0.1 :inverse-video t :extend t) > + (0 '(face log-edit-summary-separator > display-line-numbers-disable t rear-nonsticky t)))) > (log-edit--match-first-line (0 'log-edit-summary)))) Other than those nits, LGTM (but I didn't test it).