From: Stefan Kangas <stefankangas@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: "Trent W. Buck" <trentbuck@gmail.com>,
Philip Kaludercic <philipk@posteo.net>,
Eli Zaretskii <eliz@gnu.org>,
gregory@heytings.org, 62370@debbugs.gnu.org
Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces
Date: Sun, 3 Sep 2023 03:30:45 -0700 [thread overview]
Message-ID: <CADwFkmkSKLP5xoFkAYa40tY1yP=1n6FFoF_16fv3fQ2A0HaNRg@mail.gmail.com> (raw)
In-Reply-To: <81a938c7-3a11-5327-9814-b55a9936f195@gmail.com> (Jim Porter's message of "Thu, 23 Mar 2023 09:11:57 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
> I agree that we shouldn't be changing defaults arbitrarily, but as I found when
> looking at the face definitions, we could make this change in a way where it
> just simplifies the job for theme authors but doesn't cause a noticeable change
> in most cases.
>
> Does that sound ok? If not, then I think we can just close this.
I think the solution that you proposed makes sense: it wouldn't break
anything, and it would make sieve-mode look better for many users.
ISTR that Philip was planning to look into improving our face
definitions, so I'm putting him in Cc in case he has any comments.
next prev parent reply other threads:[~2023-09-03 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 5:41 bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces Trent W. Buck
2023-03-22 14:49 ` Eli Zaretskii
2023-03-22 20:10 ` Gregory Heytings
2023-03-22 21:22 ` Jim Porter
2023-03-23 1:05 ` Trent W. Buck
2023-03-23 6:58 ` Eli Zaretskii
2023-03-23 7:03 ` Trent W. Buck
2023-03-23 7:25 ` Eli Zaretskii
2023-03-23 16:11 ` Jim Porter
2023-09-03 10:30 ` Stefan Kangas [this message]
2023-09-03 11:04 ` Philip Kaludercic
2023-09-05 4:43 ` Jim Porter
2023-09-05 12:01 ` Eli Zaretskii
2023-09-05 15:52 ` Jim Porter
2023-09-05 16:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkSKLP5xoFkAYa40tY1yP=1n6FFoF_16fv3fQ2A0HaNRg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=62370@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=jporterbugs@gmail.com \
--cc=philipk@posteo.net \
--cc=trentbuck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).