From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37420: [PATCH] Recommend against SHA-1 for security-related applications Date: Fri, 4 Oct 2019 17:33:54 +0200 Message-ID: References: <87v9tsv65b.fsf@gnus.org> <87ef0grneg.fsf@gnus.org> <83muf3wj8q.fsf@gnu.org> <87zhiotcv3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182140"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37420-done@debbugs.gnu.org, Robert Pluim To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 04 17:36:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGPd4-000lCB-Cj for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2019 17:36:26 +0200 Original-Received: from localhost ([::1]:49854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGPd3-0007Bg-9D for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2019 11:36:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39598) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGPbk-0006WA-CD for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 11:35:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGPbi-00037N-EN for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 11:35:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGPbi-00037D-BJ for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 11:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iGPbi-0000qZ-74 for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2019 11:35:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2019 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 37420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 37420@debbugs.gnu.org, stefan@marxist.se, stefan@marxist.se Original-Received: via spool by 37420-done@debbugs.gnu.org id=D37420.15702032553196 (code D ref 37420); Fri, 04 Oct 2019 15:35:01 +0000 Original-Received: (at 37420-done) by debbugs.gnu.org; 4 Oct 2019 15:34:15 +0000 Original-Received: from localhost ([127.0.0.1]:43359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGPax-0000pU-FT for submit@debbugs.gnu.org; Fri, 04 Oct 2019 11:34:15 -0400 Original-Received: from mail-pl1-f172.google.com ([209.85.214.172]:36076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGPav-0000pG-AF for 37420-done@debbugs.gnu.org; Fri, 04 Oct 2019 11:34:13 -0400 Original-Received: by mail-pl1-f172.google.com with SMTP id j11so3309005plk.3 for <37420-done@debbugs.gnu.org>; Fri, 04 Oct 2019 08:34:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0/Mt0GxTyxJlxRGh0KmmFGwBSynSS5+T/2Fz5KwPAHk=; b=h5i41ZN/4H7fDJxRAHM2hRBJHDgYvDdJhzLd6rhMA1WPuEdjOUW2XzYNWwn7n8Ezzi QVlHWSHPBPsZ+PEUKpddfTaQH7LgIcSv2tVX10KT3cS6kniMG21R7MkuOrLa0mY2WGIk +Zpsk9Yq+uT/zhaEIJLRL6qmdBlgsZFJvVJlfp32j9Qe5xRNs6WOrg6U6r1m+I8Vr8mf zQDBD2TTbduf3PJFyZDZoWgXh+sFTlsfiGXuwmz5FmsamySd2129UQem92ZUdbMw2PK7 AF2016SFl62XDcqmeC85a8gw8E9Zunwq0qOQ+XrJJ8j4Hg3XosZlXuszoL2r1Kdyw/Mh dsLQ== X-Gm-Message-State: APjAAAWJx5Oby38UH9Z7yJ52EiGVNkZytu2IdfTQde9F7fYecntp6Zyl hnb1PPgA22VifEmBhaaT4XeAxcc+mMeZuUMoqGA= X-Google-Smtp-Source: APXvYqwjQFC6QIhvnDi1YN236WGGw7XZwKH+otpkMDb6lhxAdoPDTRyqDd8QJcVCah1iSRxlCKLsDK5wjIq4C4qDX30= X-Received: by 2002:a17:902:326:: with SMTP id 35mr16273137pld.128.1570203247478; Fri, 04 Oct 2019 08:34:07 -0700 (PDT) In-Reply-To: <87zhiotcv3.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168330 Archived-At: Lars Ingebrigtsen writes: > > Thanks Eli and Robert. How about the attached patch? > > Looks good to me, but one tiny thing: > > > +(ert-deftest test-secure-hash () > > + (should (equal (secure-hash 'md5 "foobar") "3858f62230ac3c915f300c664312c63f")) > > + (should (equal (secure-hash 'sha1 "foobar") "8843d7f92416211de9ebb963ff4ce28125932878")) > > + (should (equal (secure-hash 'sha224 "foobar") (concat "de76c3e567fca9d246f5f8d3b2e704a3" > > + "8c3c5e258988ab525f94 > > Perhaps the lines should be folded to avoid too-long lines? Thanks; fixed and pushed as commit ef8fadf8c1. Best regards, Stefan Kangas