unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: nasyxx@gmail.com, 62704-done@debbugs.gnu.org
Subject: bug#62704: 30.0.50; treesit-install-language-grammar should accept an arg to indicate the installation path.
Date: Mon, 11 Sep 2023 16:35:37 -0700	[thread overview]
Message-ID: <CADwFkmkRnu6r_P0vstKKybgye6kZTgWKxqz6VN1z3WpCHEpAxQ@mail.gmail.com> (raw)
In-Reply-To: <49AD3E51-A184-49A4-A0A0-71FB13C02A46@gmail.com> (Yuan Fu's message of "Wed, 12 Apr 2023 00:06:44 -0700")

Yuan Fu <casouri@gmail.com> writes:

> Nasy <nasyxx@gmail.com> writes:
>
>> Hi,
>>
>> In treesit.el, the ~treesit-install-language-grammar~ function installs
>> the grammar to the default path of
>> ~treesit--install-language-grammar-1~, which is inconvenient for users
>> who want to install the grammar to a custom path.  Adding an optional
>> argument =PATH= to this function and changing the line below would be
>> better.
>>
>>     (condition-case err
>>         (apply #'treesit--install-language-grammar-1
>>                ;; The nil is OUT-DIR.
>> -               (cons nil recipe))
>> +               (cons PATH recipe))
>>       (error
>
> Fair enough. I added a prompt at the end that asks for the target
> directory. Please give it a try (I didn’t test it :-)

No further comments within 5 months, so I assume that the fix worked.
I'm therefore closing this bug report with this message.

If this conclusion is incorrect and this is still an issue, please reply
to this email (use "Reply to all" in your email client) and we can
reopen the bug report.





      reply	other threads:[~2023-09-11 23:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 21:10 bug#62704: 30.0.50; treesit-install-language-grammar should accept an arg to indicate the installation path Nasy
2023-04-12  7:06 ` Yuan Fu
2023-09-11 23:35   ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkRnu6r_P0vstKKybgye6kZTgWKxqz6VN1z3WpCHEpAxQ@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=62704-done@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=nasyxx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).