From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring Date: Mon, 14 Nov 2022 20:01:10 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4591"; mail-complaints-to="usenet@ciao.gmane.io" To: Gabriel , 59266@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 05:02:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oun9b-00011H-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 05:02:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oun9A-0004nJ-63; Mon, 14 Nov 2022 23:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oun98-0004lR-T8 for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 23:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oun98-00025r-G3 for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 23:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oun98-0007yF-B8 for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 23:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2022 04:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59266-submit@debbugs.gnu.org id=B59266.166848487830532 (code B ref 59266); Tue, 15 Nov 2022 04:02:02 +0000 Original-Received: (at 59266) by debbugs.gnu.org; 15 Nov 2022 04:01:18 +0000 Original-Received: from localhost ([127.0.0.1]:52463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oun8Q-0007wO-5N for submit@debbugs.gnu.org; Mon, 14 Nov 2022 23:01:18 -0500 Original-Received: from mail-oi1-f182.google.com ([209.85.167.182]:43590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oun8O-0007w9-Oz for 59266@debbugs.gnu.org; Mon, 14 Nov 2022 23:01:17 -0500 Original-Received: by mail-oi1-f182.google.com with SMTP id q83so13615015oib.10 for <59266@debbugs.gnu.org>; Mon, 14 Nov 2022 20:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=R22VsRkvtwXN26ss1Xx0Q2weAqR2emjz8hEZtpGeu+w=; b=BnZW4sOOluZ07VLm8qEM3Oum/yCcRkqAItFq/mHs712tM8N2EjVtqTUlw2Or1OFprk UqaDnXRWe4ZYXvqb45Q3vRWKeYS2k78P+BwiNPxWRIGWFQxM1fMb1BA+0caAin3FMX8q vdB8PVHN6h2Hf6IodeL0BQ2PPMeO4JZYpaFDGdlKcPFU2n0Zj6fzVG0Ez4WnWnMZyyqK kfxGhJyDZ1xUsdFZq+jeygBnI5ZvcmkLi3ZdgCQDatEMozChFy/G6RevCD0qKlKjy1nV HHDW+y4DmgxCYg3dWSm8kUkkcoD/wO2vRpWYDJ/iHREPGQYiFgIbAq2535SBoewtEM1r TF3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R22VsRkvtwXN26ss1Xx0Q2weAqR2emjz8hEZtpGeu+w=; b=YiBvqdAokF+L6FZmobb1FDfUAoqWeBQgVRT2iOj/hAMxyJ1ZQwzcS73+sa8/EyNQ0n nFq8LxcNMOmMpVynwbs/LxkKBWzn//WYcZtD6EKknB4mj3BC8ugY1nXGNG8aWhfIo/Ek pu6HserjWTaL9wC5JRuerpOORzIpHqp+C4HFYEmtQ/HVOuGycpEKcHDvCYnEd8ouRKyA yG/jZJcaoJmExLdqZYy7/Amx5LgzqpVouXRu0Yjx4ssFqpf3MK4ki+IgyxXiyKxP1Dq7 B+Ari8+ehq6OdiFG0JKGsAPeImHnM8u/xSDa8svGkZn/FAfgZVYIsEWMy4pGWL8xIZ17 hTCw== X-Gm-Message-State: ANoB5pl8l4WL8BwvtZiqolJ0s6eY4B2nI9GTmetHcDdYqKgNvkM17GSo 2DLThlgR8F3u2xYQsPHRMCiumr14zz0PU0V3SD0= X-Google-Smtp-Source: AA0mqf4gwLawD8PQyh6sZ7rQoBcAQ9ohtEq9J6uV2gVkyjPBLRKB01Ts9jhvKxiVYGjBFxvDaqmOpM97tiVx1lFb3gY= X-Received: by 2002:aca:3b86:0:b0:359:dc32:4f9e with SMTP id i128-20020aca3b86000000b00359dc324f9emr97376oia.92.1668484871125; Mon, 14 Nov 2022 20:01:11 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 14 Nov 2022 20:01:10 -0800 In-Reply-To: X-Hashcash: 1:20:221115:gabriel376@hotmail.com::3oxDX+oR6cf9eznT:0zEQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247911 Archived-At: Gabriel writes: > From fed6c0773f152ff795115b1a6c1a7855b3b99f54 Mon Sep 17 00:00:00 2001 > From: Gabriel do Nascimento Ribeiro > Date: Mon, 14 Nov 2022 11:36:59 -0300 > Subject: [PATCH 1/1] Add flat-button to set-face-attribute docstring > > * lisp/faces.el (set-face-attribute): Add `flat-button' to STYLE > section of docstring. > --- > lisp/faces.el | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lisp/faces.el b/lisp/faces.el > index 09e8110449..4088f4be8a 100644 > --- a/lisp/faces.el > +++ b/lisp/faces.el > @@ -791,9 +791,8 @@ set-face-attribute > color of the face for 3D boxes. STYLE specifies whether a 3D box > should be draw. If STYLE is `released-button', draw a box looking > like a released 3D button. If STYLE is `pressed-button' draw a box > -that appears like a pressed button. If STYLE is nil, the default if > -the property list doesn't contain a style specification, draw a 2D > -box. > +that appears like a pressed button. If STYLE is nil, `flat-button' > +or omitted, draw a 2D box. Thanks for the patch. It copies the text from (info "(elisp)Face Attributes") and in that sense looks good. But shouldn't we keep the part saying that nil is "the default if the property list doesn't contain a style specification"?