From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#14473: 24.3; emacs locks up when eshell attempts to display a dialog Date: Tue, 8 Oct 2019 16:05:54 +0200 Message-ID: References: <86zjvjnfj9.fsf@gly.ath.cx> <83r23xbw9s.fsf@gnu.org> <86wodlakye.fsf@phe.ftfl.ca> <8636g4crpc.fsf@phe.ftfl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="228654"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 14473@debbugs.gnu.org To: Joseph Mingrone Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 08 16:23:30 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHqOf-000x01-8l for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 16:23:29 +0200 Original-Received: from localhost ([::1]:56366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHqOT-0001b2-65 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 10:23:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHq8m-00054P-1G for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 10:07:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHq8k-0003DT-JA for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 10:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHq8k-0003DH-3f for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHq8j-00018a-Mu for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 10:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2019 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14473 X-GNU-PR-Package: emacs Original-Received: via spool by 14473-submit@debbugs.gnu.org id=B14473.15705435754320 (code B ref 14473); Tue, 08 Oct 2019 14:07:01 +0000 Original-Received: (at 14473) by debbugs.gnu.org; 8 Oct 2019 14:06:15 +0000 Original-Received: from localhost ([127.0.0.1]:51159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHq7y-00017b-FB for submit@debbugs.gnu.org; Tue, 08 Oct 2019 10:06:14 -0400 Original-Received: from mail-pf1-f196.google.com ([209.85.210.196]:40802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHq7w-00017N-30 for 14473@debbugs.gnu.org; Tue, 08 Oct 2019 10:06:12 -0400 Original-Received: by mail-pf1-f196.google.com with SMTP id x127so10819285pfb.7 for <14473@debbugs.gnu.org>; Tue, 08 Oct 2019 07:06:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YWUmIszbb9gXlE5gQ9SC0SE8zHYjqBi9rFPhtInEvYg=; b=br6KRqvA+gM8it+U/A8WuAGa5Eq6b0JUL5p3kXIRPZIXCUluj1fmSaw26/O6mpsqWr ccF7HgT76S+sqmyVvRGFCUaVSapSBeqN42fsDNxaHfxeJH1d/+nrp9Ky6lW2TYqKhViZ 31Nya81w9uSY838ilEmec+FAV+AZh8haJ3/pBoBH/4unC26qhkQVUHs4sHGRN7eaYfpk 4Rb/24Gv22QMj84AoEUy/pu/UFrx/klH/LsImx/9zcypSpdc6UEml2uO3Akfo8I6fuPj 6Qj/b47xiQz3tW1xgAMKUBt3orBAJmjxQYLDaU73D9gIyeGgJ407+6iVQ7zMbRCZk9JB me0g== X-Gm-Message-State: APjAAAXoG2MFGeg+hd4dKUCj48um9jFrk75tBVfP0iJDqXRUlnrwBoMi bwrGgsA5CNmur0Ex2pdYmR+2XfIglXhsmJePRSk= X-Google-Smtp-Source: APXvYqx3+NVB4/Y64ZV4vmWG652z2PwsLDBv2yljtpQ24i5WDNeOa6YHr+1tnFCNygJZqRS0Q8yysI8n5UMXDwTaTOQ= X-Received: by 2002:aa7:8750:: with SMTP id g16mr38493663pfo.190.1570543566325; Tue, 08 Oct 2019 07:06:06 -0700 (PDT) In-Reply-To: <8636g4crpc.fsf@phe.ftfl.ca> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168651 Archived-At: Hi Joseph, Joseph Mingrone writes: > >> It's still a problem (26.3 and 2019-09-15 master-branch build) in that the dialog is not displayed, but the Emacs process no longer consumes 100% CPU. > > > Thanks for reporting back. > > >> Here is a simple recipe to reproduce the problem. It assumes the FreeBSD ports tree is installed in the default location, which is /usr/ports. > > > Can you think of any way to reproduce this if you are not using > > FreeBSD? Is there some particular command run by "make config" that > > makes eshell freeze for example? It seems to me that very few Emacs > > developers are using FreeBSD, and I personally don't have access to > > any FreeBSD systems for debugging. > > I would guess any GNU/Linux command that also presents these curses > dialogs would have problems. If you or any Emacs developer wants a > FreeBSD shell account, I can provide one. Thank you, noted. There are indeed (a small number of) open bugs regarding *BSD systems, so I'm hoping that someone will take you up on that offer. I might if I find the time. > https://invisible-island.net/dialog/dialog-figures.html > > To be clear, it seems like less of a freeze now and more like an > inability to display the dialog and the point becomes lost requiring > users to kill eshell. So, it is much less severe of a problem than in > the past. Yes, after installing "dialog", I'm able to reproduce the problem on my system using this command: dialog --yesno "foobar" 10 50 In my case, hitting RET brings me back to the eshell prompt. I think the problem is that eshell just doesn't support the control characters that ncurses is producing, meaning that it has to switch to term-mode to get that to work. Luckily, there are user options you could set to make eshell do that automatically. I created a Makefile with: config: dialog --yesno "foobar" 10 50 Using that Makefile, saying "make config" in eshell opens it in term-mode automatically after I evaluate: (add-to-list 'eshell-visual-subcommands '("make" "config")) Does setting that option solve the issues you're seeing too? If so, I think we can just write this up as a limitation in eshell, and recommend users to configure this variable. Also see eshell-visual-commands and eshell-visual-options for more. One final thing, is running "make config" common on FreeBSD? I guess it's part of the "ports" system that pretty much everyone uses, including people on OpenBSD? If so, perhaps it would be worth changing the default of eshell-visual-subcommands from nil to something like: (when (equal system-type 'berkeley-unix) '(("make" "config"))) Best regards, Stefan Kangas