unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Pip Cet <pipcet@gmail.com>
Cc: 46916@debbugs.gnu.org
Subject: bug#46916: 28.0.50; pure_alloc(10424, ...) fails badly when pure space is exhausted
Date: Sun, 31 Oct 2021 07:02:47 -0700	[thread overview]
Message-ID: <CADwFkmkLdoaGPpAd_np5mQtONxXn8vU0Pych6ukb7BVFUAhP6A@mail.gmail.com> (raw)
In-Reply-To: <CAOqdjBfVdcDCrNah_z0xtFZO5p4_-Bmzxi2xJ=h+MXWO_ZxsTg@mail.gmail.com>

Pip Cet <pipcet@gmail.com> writes:

> I have no objections to this report being closed, in case that's
> relevant: it's a clear bug but Eli appears to prefer not to fix it,
> and I can live with that. In fact, isn't that what WONTFIX is for?

Hmm, so I reviewed all this more carefully, and I think I agree that we
might as well fix this bug.

OT1H, the use-case you present is quite unusual, as almost no one will
call `purespace' outside of Emacs core development.

OTOH, it is a pretty bad behavior you observed, and the patch seems
minimal enough to me.  IIUC, outside of bootstrapping Emacs, we
won't/shouldn't call 'purespace' very often, so the code-path will not
be exercised in normal use (which means your patch won't hurt), and it
might save someones system from swapping to death.

Eli, I'm not sure if your previous reply was just intended to say "we
normally just increase the size of purespace", or if you also object to
installing this patch?





  parent reply	other threads:[~2021-10-31 14:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 12:24 bug#46916: 28.0.50; pure_alloc(10424, ...) fails badly when pure space is exhausted Pip Cet
2021-03-04 12:44 ` Pip Cet
2021-03-04 14:15   ` Eli Zaretskii
2021-10-31  2:56     ` Stefan Kangas
2021-10-31  7:13       ` Eli Zaretskii
2021-10-31  9:41       ` Pip Cet
2021-10-31 11:29         ` Eli Zaretskii
2021-10-31 14:02         ` Stefan Kangas [this message]
2021-10-31 14:23           ` Eli Zaretskii
2021-11-05  7:11             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkLdoaGPpAd_np5mQtONxXn8vU0Pych6ukb7BVFUAhP6A@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=46916@debbugs.gnu.org \
    --cc=pipcet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).