From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51451: image-transform-original has a misleading name Date: Wed, 3 Nov 2021 13:16:55 -0700 Message-ID: References: <87ilxdnsbu.fsf@mail.linkov.net> <86ee7xvzwi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8881"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51451@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 03 21:18:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miMiH-000229-Ep for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 21:18:25 +0100 Original-Received: from localhost ([::1]:55696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miMiG-0004ie-Hb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 16:18:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miMhu-0004iN-Fs for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 16:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58049) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miMhu-0006d8-7d for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 16:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miMhu-0006n8-3y for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 16:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Nov 2021 20:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51451 X-GNU-PR-Package: emacs Original-Received: via spool by 51451-submit@debbugs.gnu.org id=B51451.163597062426020 (code B ref 51451); Wed, 03 Nov 2021 20:18:02 +0000 Original-Received: (at 51451) by debbugs.gnu.org; 3 Nov 2021 20:17:04 +0000 Original-Received: from localhost ([127.0.0.1]:41361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miMgy-0006lX-J5 for submit@debbugs.gnu.org; Wed, 03 Nov 2021 16:17:04 -0400 Original-Received: from mail-pf1-f181.google.com ([209.85.210.181]:34425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miMgv-0006ks-TK for 51451@debbugs.gnu.org; Wed, 03 Nov 2021 16:17:02 -0400 Original-Received: by mail-pf1-f181.google.com with SMTP id 127so3574707pfu.1 for <51451@debbugs.gnu.org>; Wed, 03 Nov 2021 13:17:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=KSo80kRUxmMm+a5kAI684bd39CtdBQn5+YjWZ1QVC3Y=; b=IDseEnYBZm4jpZ4lvrHVdwQnUH0sGOUeBLRZkGkj1y/0MTk/X857NnndFaitT2NmTw As40E5K6Dg15ZuwNG+Xc+6WBpf26foaqZJ1BSdALnlNVqpfRkiCxukB55tJA2Zm15V45 w7u86DzLaVMk4YuS2NtfLXrNHq43UgHBTRPHXJEl4dbj2DkysNNs0CiTw6gYutjGNk7E zx0sEQqMstAhJAdeLesBQdgqu2s14qbrKrJb7MWO1aRaFDgsNP9YqhIYgag327Jck6TK ms5iSQvtiHX3/fJzE+q1LaHTAh7W7RzOlRj6gE82ZLvaIHGpT89GCwN2qCC9xEKmm4gG 3kTg== X-Gm-Message-State: AOAM532NnTTFqjSQhxO/0Pfk/4i7lj3f7TpkuFkKkMTpPdY9XYCoqioI qfnTsB/iqmpB4iCMTYxRXlF8LMf/MlPXQFntkBU= X-Google-Smtp-Source: ABdhPJwoScW1bV84hcszwsMIoGg9zwlcg3wV7+AQacAQ0OuXYi50WMftukilJn4pzB+dAzxwO3HCpRXmclQof6kB1nA= X-Received: by 2002:a63:330f:: with SMTP id z15mr35367681pgz.42.1635970616018; Wed, 03 Nov 2021 13:16:56 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 3 Nov 2021 13:16:55 -0700 In-Reply-To: <86ee7xvzwi.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218896 Archived-At: Juri Linkov writes: >>> image-transform-* commands are modifying the values of >>> image-transform-* variables. >>> Would you propose to rename variables as well? >> >> I didn't think about that, as the commands are what the user will see. >> Maybe we should. Do you think it would be a good idea? > > At least, currently there is consistency in naming of > image-transform-* functions and variables. That's true. > But if you see a problem only in the name of image-transform-original, > then it could be renamed to image-transform-set-original or maybe > better to image-transform-reset-to-original, i.e. to something more > descriptive, while keeping the existing name prefix. I see a problem with all of them, especially in combination with `image-save'. :-( But the most confusing one by far is `image-transform-original', indeed.