From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty Date: Tue, 19 May 2020 20:44:30 -0700 Message-ID: References: <87ftbwrtlm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ba1b0a05a60c3656" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="109452"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41385@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 05:45:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbFfL-000SKK-60 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 05:45:11 +0200 Original-Received: from localhost ([::1]:58424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbFfJ-0000jB-J5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 May 2020 23:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbFfC-0000j3-Mn for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 23:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbFfC-00011T-DV for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 23:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbFfC-0007SH-Bz for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 23:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 May 2020 03:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41385-submit@debbugs.gnu.org id=B41385.158994627828610 (code B ref 41385); Wed, 20 May 2020 03:45:02 +0000 Original-Received: (at 41385) by debbugs.gnu.org; 20 May 2020 03:44:38 +0000 Original-Received: from localhost ([127.0.0.1]:51798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbFeo-0007RO-HP for submit@debbugs.gnu.org; Tue, 19 May 2020 23:44:38 -0400 Original-Received: from mail-yb1-f194.google.com ([209.85.219.194]:40873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbFen-0007RB-6w for 41385@debbugs.gnu.org; Tue, 19 May 2020 23:44:37 -0400 Original-Received: by mail-yb1-f194.google.com with SMTP id c2so268369ybi.7 for <41385@debbugs.gnu.org>; Tue, 19 May 2020 20:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=pE1dQmorQuS22PCiOkbLFFB9rZuGIBcXsMSGhsihcx8=; b=Z1KyKQMJACTt3a7g5HWdOi4kCS8VGOzsutf/7yxT2ynEdBHGfNFAYBVuXfMFhfTJHt mJnZb5/pHLZOquOKdwqG0DyvmomN/E2poDEbUuO4Jutk4/UxbmrJPZtvkbssk6ksQS9v +rJFf9R773XyHcalz+99G8QuiPwXX1smpVVOPp1fPJ8l4HO/J+l0NM1ORO5wUtKRB+RX tsifyDbebU5zxg/q+8hto+Bb5zqleAp0Tpsa5ZsKyGw2ECKbd7RSE98A6oqhNDHf8fEC 4U8NF1CfecFY0MiLWyWOMHHBi1mDWpn1X29JzPcG123uCX3k+N0h1xH39shSmO72KJ6d HTlA== X-Gm-Message-State: AOAM533xXgnVdQPk3CuC2KW7FrVY+i4gdoiT492bI938e/UC2W/VEPOP NGMhJGm6244rxovS9SHEo4WvksxeAmcHMqPw43g= X-Google-Smtp-Source: ABdhPJwtIGJsMKLu26ralUVw6B1ikEfqutnTLEwbSq94sknZkAqTJN4LERWSIEBdKLzwEZskvOyIUiXQSCfcKSZuBEg= X-Received: by 2002:a25:ad4c:: with SMTP id l12mr4181249ybe.389.1589946271519; Tue, 19 May 2020 20:44:31 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 May 2020 20:44:30 -0700 In-Reply-To: <87ftbwrtlm.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180641 Archived-At: --000000000000ba1b0a05a60c3656 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > I don't think this is an ideal way to fix this command -- using error > handling to do control flow is usually the wrong thing to do, and it > makes debugging difficult. What if there's a real bug in > eww-bookmark-prepare? > > Instead eww-list-bookmarks should just do the > > (eww-read-bookmarks) > (unless eww-bookmarks > (user-error "No bookmarks are defined")) > > bit, I think. It might mean rearranging some stuff in eww-next-bookmark > etc, though. Thanks, good point. Does the attached patch look better? Best regards, Stefan Kangas --000000000000ba1b0a05a60c3656 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch" Content-Disposition: attachment; filename="0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: d52d17460c82e716_0.1 RnJvbSAxOGE2YWVjMGM4YzI0MjUwZmNkMTA1ZDUzOGJkZGNkZjkwN2MwZTVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDE5IE1heSAyMDIwIDAyOjQzOjE2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U2hvdyBld3cgYm9va21hcmtzIGJ1ZmZlciBvbmx5IGlmIGl0J3Mgbm90IGVtcHR5CgoqIGxpc3Av bmV0L2V3dy5lbCAoZXd3LWxpc3QtYm9va21hcmtzKTogRG9uJ3Qgc2hvdyBidWZmZXIgaWYgdGhl cmUKYXJlIG5vIGJvb2ttYXJrcy4gIChCdWcjNDEzODUpCihld3ctYm9va21hcmstcHJlcGFyZSk6 IE1vdmUgc2lnbmFsbGluZyBhbiBlcnJvciBpZiB0aGVyZSBhcmUgbm8KYm9va21hcmtzIGZyb20g aGVyZS4uLgooZXd3LXJlYWQtYm9va21hcmtzKTogLi4udG8gaGVyZS4gIEFkZCBuZXcgYXJndW1l bnQgYGVycm9yLW91dCcgdG8KY29udHJvbCB0aGlzLgooZXd3LW5leHQtYm9va21hcmssIGV3dy1w cmV2aW91cy1ib29rbWFyayk6IENhbGwgYGV3dy1yZWFkLWJvb2ttYXJrcycuCi0tLQogbGlzcC9u ZXQvZXd3LmVsIHwgMTQgKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvZXd3LmVsIGIvbGlz cC9uZXQvZXd3LmVsCmluZGV4IGE2YzFhYmRiYjEuLjg0MTU0YzUwMmQgMTAwNjQ0Ci0tLSBhL2xp c3AvbmV0L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTE3NDIsMjUgKzE3NDIsMjcg QEAgZXd3LXdyaXRlLWJvb2ttYXJrcwogICAgIChpbnNlcnQgIjs7IEF1dG8tZ2VuZXJhdGVkIGZp bGU7IGRvbid0IGVkaXQgLSotIG1vZGU6IGxpc3AtZGF0YSAtKi1cbiIpCiAgICAgKHBwIGV3dy1i b29rbWFya3MgKGN1cnJlbnQtYnVmZmVyKSkpKQogCi0oZGVmdW4gZXd3LXJlYWQtYm9va21hcmtz ICgpCisoZGVmdW4gZXd3LXJlYWQtYm9va21hcmtzICgmb3B0aW9uYWwgZXJyb3Itb3V0KQorICAi UmVhZCBib29rbWFya3MgZnJvbSBgZXd3LWJvb2ttYXJrcycuCitJZiBFUlJPUi1PVVQsIHNpZ25h bCB1c2VyLWVycm9yIGlmIHRoZXJlIGFyZSBubyBib29rbWFya3MuIgogICAobGV0ICgoZmlsZSAo ZXhwYW5kLWZpbGUtbmFtZSAiZXd3LWJvb2ttYXJrcyIgZXd3LWJvb2ttYXJrcy1kaXJlY3Rvcnkp KSkKICAgICAoc2V0cSBld3ctYm9va21hcmtzCiAJICAodW5sZXNzICh6ZXJvcCAob3IgKGZpbGUt YXR0cmlidXRlLXNpemUgKGZpbGUtYXR0cmlidXRlcyBmaWxlKSkgMCkpCiAJICAgICh3aXRoLXRl bXAtYnVmZmVyCiAJICAgICAgKGluc2VydC1maWxlLWNvbnRlbnRzIGZpbGUpCi0JICAgICAgKHJl YWQgKGN1cnJlbnQtYnVmZmVyKSkpKSkpKQorCSAgICAgIChyZWFkIChjdXJyZW50LWJ1ZmZlcikp KSkpCisgICAgKHdoZW4gKGFuZCBlcnJvci1vdXQgKG5vdCBld3ctYm9va21hcmtzKSkKKyAgICAg ICh1c2VyLWVycm9yICJObyBib29rbWFya3MgYXJlIGRlZmluZWQiKSkpKQogCiA7OzsjIyNhdXRv bG9hZAogKGRlZnVuIGV3dy1saXN0LWJvb2ttYXJrcyAoKQogICAiRGlzcGxheSB0aGUgYm9va21h cmtzLiIKICAgKGludGVyYWN0aXZlKQorICAoZXd3LXJlYWQtYm9va21hcmtzIHQpCiAgIChwb3At dG8tYnVmZmVyICIqZXd3IGJvb2ttYXJrcyoiKQogICAoZXd3LWJvb2ttYXJrLXByZXBhcmUpKQog CiAoZGVmdW4gZXd3LWJvb2ttYXJrLXByZXBhcmUgKCkKLSAgKGV3dy1yZWFkLWJvb2ttYXJrcykK LSAgKHVubGVzcyBld3ctYm9va21hcmtzCi0gICAgKHVzZXItZXJyb3IgIk5vIGJvb2ttYXJrcyBh cmUgZGVmaW5lZCIpKQogICAoc2V0LWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgIipld3cgYm9v a21hcmtzKiIpKQogICAoZXd3LWJvb2ttYXJrLW1vZGUpCiAgIChsZXQqICgod2lkdGggKC8gKHdp bmRvdy13aWR0aCkgMikpCkBAIC0xODI4LDYgKzE4MzAsNyBAQCBld3ctbmV4dC1ib29rbWFyawog CWJvb2ttYXJrKQogICAgICh1bmxlc3MgKGdldC1idWZmZXIgIipld3cgYm9va21hcmtzKiIpCiAg ICAgICAoc2V0cSBmaXJzdCB0KQorICAgICAgKGV3dy1yZWFkLWJvb2ttYXJrcyB0KQogICAgICAg KGV3dy1ib29rbWFyay1wcmVwYXJlKSkKICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAoZ2V0LWJ1 ZmZlciAiKmV3dyBib29rbWFya3MqIikKICAgICAgICh3aGVuIChhbmQgKG5vdCBmaXJzdCkKQEAg LTE4NDYsNiArMTg0OSw3IEBAIGV3dy1wcmV2aW91cy1ib29rbWFyawogCWJvb2ttYXJrKQogICAg ICh1bmxlc3MgKGdldC1idWZmZXIgIipld3cgYm9va21hcmtzKiIpCiAgICAgICAoc2V0cSBmaXJz dCB0KQorICAgICAgKGV3dy1yZWFkLWJvb2ttYXJrcyB0KQogICAgICAgKGV3dy1ib29rbWFyay1w cmVwYXJlKSkKICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAoZ2V0LWJ1ZmZlciAiKmV3dyBib29r bWFya3MqIikKICAgICAgIChpZiBmaXJzdAotLSAKMi4yNi4yCgo= --000000000000ba1b0a05a60c3656--