From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60089: 29.0.60; eglot doesn't support csharp-ls language server [PATCH] Date: Thu, 15 Dec 2022 13:28:33 -0800 Message-ID: References: <60949726-279b-67c6-e960-0f6d6d158009@secure.kjonigsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2173"; mail-complaints-to="usenet@ciao.gmane.io" To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , 60089@debbugs.gnu.org, joaotavora@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 22:29:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5vn3-0000M6-Pl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 22:29:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5vmq-0007ek-SI; Thu, 15 Dec 2022 16:29:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5vmo-0007eL-Jm for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 16:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5vmo-0000fg-Ba for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 16:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5vmo-0003y3-7D for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 16:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 21:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60089 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60089-submit@debbugs.gnu.org id=B60089.167113972215240 (code B ref 60089); Thu, 15 Dec 2022 21:29:02 +0000 Original-Received: (at 60089) by debbugs.gnu.org; 15 Dec 2022 21:28:42 +0000 Original-Received: from localhost ([127.0.0.1]:45017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5vmU-0003xk-Ae for submit@debbugs.gnu.org; Thu, 15 Dec 2022 16:28:42 -0500 Original-Received: from mail-ot1-f42.google.com ([209.85.210.42]:33748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5vmS-0003xe-11 for 60089@debbugs.gnu.org; Thu, 15 Dec 2022 16:28:41 -0500 Original-Received: by mail-ot1-f42.google.com with SMTP id q18-20020a056830441200b006704633f258so312730otv.0 for <60089@debbugs.gnu.org>; Thu, 15 Dec 2022 13:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=lzO6xhLCyUGnyPxf6Br252p97tkNITvWm1kSz2e23Ec=; b=dfECgGOIaWWY5KPzlPlhGwP1m5JumYK2SvhRE7jCjFBFu6+JbqDBUelZgHCnZJT1nh SZIV9yDaUgQHjzTs/q961TRUwQvhAdUTes2rR7y0RDh9pdyhEwhypSkaT5N9cLL4p75C Jl09SMGWZppkDcc21u3cjGOt6538RQTbOPXejt9jfXQZMsBacfc3xs05IBn1l2ZJCKqp vHBUatgp+PGumGDRd/komInPFOVj9mEskUmxgdd8av24xOI6SoqrUAxepQP1hsF/J+Rs 1TanYQRR3nb2jA2LUbl9oP4j87nWcJwH8+awEuJIL6E4tMOvdBVO3ybeCRA3YDjY4mJJ K1MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lzO6xhLCyUGnyPxf6Br252p97tkNITvWm1kSz2e23Ec=; b=Aa4Oo7K3d1bpN9aenRC8w/tsBlZhwNbiI2z5009q/LvuyMH7NK94eYHE9XOI89WbvX zIXPf2Fmk/PDOR1qXx6JlNeKgRwbM5bv/kdJdScXfx6RAOfCVbaJcv2HuMuZVJzpMgvf R3Ppt190GaGNxVzFXeJChQGQl/KfoSYtNtnZJ5A8zX2OHUodUPkLZPTcsUSHFaDAaO3h Q7NuV6kBf+blQ/a+iMCWq7tSzibDfIrHxdHVpbcKa7PzxZWNf4e1unxxZwiDDoD0u5gN toG3Xxs4rl54bcX9ue/edvBZvyOelrQG2eUxKwmXqUDYLy3WB1yWuaqqTodbqQ5TYBGh n9Lw== X-Gm-Message-State: ANoB5pkW6Ze0nEwEXIaYw3YHQQTFOzYt89L8WJFG4sGbLL8T29CVTo5H dJLFjOlFsEXjyo8T4ROtNDjLgi3y6TYe5ikqg7g= X-Google-Smtp-Source: AA0mqf7OUNd8z+pTNy+QjeZgayqu2jrRpq0cEpj4ArAhQH8h4udAUy7ktq6mbsYD4frpODRD2QUThp/q/QTxytWQ7MQ= X-Received: by 2002:a05:6830:11cd:b0:66e:7741:ed1d with SMTP id v13-20020a05683011cd00b0066e7741ed1dmr12045657otq.224.1671139714340; Thu, 15 Dec 2022 13:28:34 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 15 Dec 2022 13:28:33 -0800 In-Reply-To: <60949726-279b-67c6-e960-0f6d6d158009@secure.kjonigsen.net> X-Hashcash: 1:20:221215:60089@debbugs.gnu.org::kMQyjJOf2Q+H2m+s:5Hqw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251149 Archived-At: Jostein Kj=C3=B8nigsen writes: > Right now eglot only knows about the Omnisharp Roslyn language server > for C#. > > csharp-ls[1] is another popular language server and is supported by > other LSP-clients, like lsp-mode. > > Eglot should support it too. > > Attached is a patch which introduces support for this language-server. > > [1] https://github.com/razzmatazz/csharp-language-server Could you give a rationale for why we should prefer omnisharp over csharp-ls? Why not the other way around? (I know nothing about C#.)