From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS Date: Mon, 24 Aug 2020 04:36:42 -0400 Message-ID: References: <20200221225014.GA49998@breton.holly.idiocy.org> <9B906B55-067E-4F04-A9D5-F4BD351D1665@idiocy.org> <20200225210630.GA72702@breton.holly.idiocy.org> <20200305172208.GC56782@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11783"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: John Wiegley , 39724@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 24 10:37:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kA7yc-0002wS-Bh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 10:37:14 +0200 Original-Received: from localhost ([::1]:58916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kA7yb-0008Cs-9t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 04:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA7yQ-0008CU-8G for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 04:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kA7yP-0004To-VJ for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 04:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kA7yP-0001nt-RV for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 04:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 08:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39724 X-GNU-PR-Package: emacs Original-Received: via spool by 39724-submit@debbugs.gnu.org id=B39724.15982582106914 (code B ref 39724); Mon, 24 Aug 2020 08:37:01 +0000 Original-Received: (at 39724) by debbugs.gnu.org; 24 Aug 2020 08:36:50 +0000 Original-Received: from localhost ([127.0.0.1]:55964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA7yD-0001nS-Re for submit@debbugs.gnu.org; Mon, 24 Aug 2020 04:36:50 -0400 Original-Received: from mail-yb1-f176.google.com ([209.85.219.176]:33813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA7yC-0001nG-Tn for 39724@debbugs.gnu.org; Mon, 24 Aug 2020 04:36:49 -0400 Original-Received: by mail-yb1-f176.google.com with SMTP id u6so4732041ybf.1 for <39724@debbugs.gnu.org>; Mon, 24 Aug 2020 01:36:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=aCh2NNCpp8xyeobCeQDkKn2Wt+1y1qko/Tza4oYusDA=; b=E3Wy9Rg81f+/35VlfOgzj34VppOnq+/NU94I9GrJFybR8vqkuVhB1Y0QYeHHbx7CoA rjZ37LM9eHJVqIRQY1qWyCMKRzWNzL42r7iSr8srTv18a9FCL9L2c0JzLGCXIprkbOlm JR0S6PtGsWu1/AOsYxRsdMDWyt0FUytNl9AbWizCxDaLfqshwUorAnuS9GRJ6pKI5t74 BcKerSFkOV55z8fKBZ7pdgihN7gHoHAahYgCF6RYmZXZkQER+OhcL9VGemU8agl6frvc DjyzbHvXgwMUwCQ9PMJhm+Boq1rDEVmrmEe4ilKq8FbqVav8bG/ocA8yXmeimZYNAlDL dT3w== X-Gm-Message-State: AOAM532uHbCq1cPTAPFxEDFcVH1qqaAFQyLN2EGSExvC3kv9kH010z0F MfCzoqmwSY6/PZ6PJ+ZjLs0Ld3gF5D6jk4gRXhSkLkNX8qOCDQ== X-Google-Smtp-Source: ABdhPJxXbQ0YST0eEo8utSiSzZtE2z0ECPxYAE6RKwPYzco4lil2gVA+Gj/1jsvJp1pvrRkdpJD1x7sX5wqU+/rMoYY= X-Received: by 2002:a25:9843:: with SMTP id k3mr6289155ybo.466.1598258203402; Mon, 24 Aug 2020 01:36:43 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 24 Aug 2020 04:36:42 -0400 In-Reply-To: <20200305172208.GC56782@breton.holly.idiocy.org> (Alan Third's message of "Thu, 5 Mar 2020 18:22:10 +0100 (CET)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186114 Archived-At: Alan Third writes: > On Tue, Feb 25, 2020 at 10:06:33PM +0100, Alan Third wrote: >> On Mon, Feb 24, 2020 at 09:56:04AM -0800, John Wiegley wrote: >> > >>>>> "AT" =3D=3D Alan Third writes: >> > >> > AT> Are you still using Nix to build Emacs? As I recall it used to use= the >> > AT> 10.10 build environment even on more modern versions of macOS, so = this >> > AT> could still be an incompatibility between the new drawing code and= older >> > AT> versions of macOS/XCode. >> > >> > I am using Nix, but it passes this: >> > >> > -DMAC_OS_X_VERSION_MAX_ALLOWED=3D101200 >> > >> > Which should be recent enough, I'd think. >> > >> > I also need to track down the slowness that I'm seeing, to see which c= ommit >> > introduced that. It will take me a few days to gather all of this info= rmation, >> > given how slow the test cycles are. >> >> Could you try the below patch to see if that sorts the background issue? >> >> modified src/nsterm.m >> @@ -8240,6 +8240,8 @@ - (void)createDrawingBuffer >> /* This fixes the scale to match the backing scale factor, and flips = the image. */ >> CGContextTranslateCTM(drawingBuffer, 0, NSHeight (frame) * scale); >> CGContextScaleCTM(drawingBuffer, scale, -scale); >> + >> + ns_clear_frame (emacsframe); >> } >> >> >> @@ -8269,7 +8271,6 @@ - (void)windowDidChangeBackingProperties:(NSNotifi= cation *)notification >> { >> NSRect frame =3D [self frame]; >> [self createDrawingBuffer]; >> - ns_clear_frame (emacsframe); >> expose_frame (emacsframe, 0, 0, NSWidth (frame), NSHeight (frame)= ); >> } >> } >> >> >> I don=E2=80=99t know if I=E2=80=99ve just missed it (I=E2=80=99ve been m= essing with my email >> set=E2=80=90up recently) but I=E2=80=99ve not seen the build log you pro= mised. >> > > Hi John, I don=E2=80=99t know if you tried the above patch, but can you p= lease > try building the master branch again? I fixed an issue last night that > may be the same as your problem. I=E2=80=99m not sure because it all depe= nds > on the build environment and what versions of Cocoa are available and > so on, and I think Nix may confuse matters. That was 6 months ago. Any updates here? If I don't hear back from you within a couple of weeks, I'll just assume this has been fixed and close this bug. Best regards, Stefan Kangas