From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44858: [PATCH] Make byte-compiler warn about wide docstrings Date: Fri, 11 Dec 2020 14:03:08 -0600 Message-ID: References: <87zh34wfxo.fsf@gnus.org> <87v9dss2ic.fsf@gnus.org> <83eejw3ghc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44858@debbugs.gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 11 21:05:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knofP-0003gN-6P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 21:05:27 +0100 Original-Received: from localhost ([::1]:35648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knofL-0007DK-KW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 15:05:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knoe2-0007Bh-3X for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 15:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knoe1-00007E-Pe for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 15:04:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knoe1-0006sg-M3 for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 15:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 20:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44858-submit@debbugs.gnu.org id=B44858.160771699726396 (code B ref 44858); Fri, 11 Dec 2020 20:04:01 +0000 Original-Received: (at 44858) by debbugs.gnu.org; 11 Dec 2020 20:03:17 +0000 Original-Received: from localhost ([127.0.0.1]:43231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knodJ-0006rg-Ep for submit@debbugs.gnu.org; Fri, 11 Dec 2020 15:03:17 -0500 Original-Received: from mail-pf1-f170.google.com ([209.85.210.170]:41438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knodH-0006rS-3q for 44858@debbugs.gnu.org; Fri, 11 Dec 2020 15:03:15 -0500 Original-Received: by mail-pf1-f170.google.com with SMTP id t8so7648656pfg.8 for <44858@debbugs.gnu.org>; Fri, 11 Dec 2020 12:03:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=GcBSmTa/xjrrZb6FJhCL27st906W4Vufami3HgXYKHo=; b=P0uDw/y8OvmDe6icrNad75D5Q/dhQ9Xa26kjHufV8F0Asve0BzSCVl2KBZoTfqgQTC 2tLXBrW3SSfQX/h5s7PPUsemp6D6FY6+vsUUxAnTIKxNi3VUKBvgs/P/XZKU27paZqib ZxsbyzFgTZqiIyn2rHegXi0ckzaCWOvR1ZmYokgRdRexFbP1/8z1NbLLCGcuEMdY6GZ4 KZ0fEnbgQSAX6Yjn6KGowoStvrTx5iGaNh2ymd2G6hfgqwbvG8/dRRg1yKNQgRUd8VpM mouMfNEZRCmFoPluP7MUqOsHNzedud6tIFAP+nPiByQ8RcmJzVnsBcUqoqUN12S9AGop oa/w== X-Gm-Message-State: AOAM530IhGKTIgShmKJCJ0Eyy3lWIn+5oYlFVDUVUAjajeb1mgWldOuT nNkXlIYBGH9/2XXm6O6l22I4o0p32RDkHhvXpYE= X-Google-Smtp-Source: ABdhPJzni2F2D1ZPM1KNIrjdwfjlQhcqTIUadQfNrmL99QR2mnGdsger+z7LtlD862mvOMTj+Fn8WPwebSXygiEUqhI= X-Received: by 2002:a62:e212:0:b029:19d:8cff:f179 with SMTP id a18-20020a62e2120000b029019d8cfff179mr13283541pfi.44.1607716989316; Fri, 11 Dec 2020 12:03:09 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 11 Dec 2020 14:03:08 -0600 In-Reply-To: <83eejw3ghc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195802 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Thu, 10 Dec 2020 15:53:13 -0600 >> Cc: 44858@debbugs.gnu.org >> >> +(defun internal--fill-string (str) >> + "Fill string STR to `fill-column'. >> +This is intended for very simple filling while bootstrapping >> +Emacs itself, and does not support all the customization options >> +of fill.el (for example `fill-region')." >> + (if (< (length str) fill-column) <<<<<<<<<<<<<<<<<<<<<<<<< > > Can we use string-width here instead of length? If this will work > during bootstrap, it is preferable, I think. Yes, it seems to work fine. Now changed.