From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#13780: 24.2; Making find-file-hook customizable seems to cause troublle Date: Wed, 28 Oct 2020 01:52:42 -0700 Message-ID: References: <87k3q1gpba.fsf@sc3d.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000591e1f05b2b74942" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7409"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 13780@debbugs.gnu.org, Reuben Thomas To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 28 09:53:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXhCm-0001oK-Ss for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 09:53:16 +0100 Original-Received: from localhost ([::1]:50150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXhCk-0003at-VW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 04:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXhCZ-0003aO-9s for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 04:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXhCY-0005pC-91 for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 04:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXhCY-0004Xu-6m for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 04:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Oct 2020 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13780 X-GNU-PR-Package: emacs Original-Received: via spool by 13780-submit@debbugs.gnu.org id=B13780.160387517217457 (code B ref 13780); Wed, 28 Oct 2020 08:53:02 +0000 Original-Received: (at 13780) by debbugs.gnu.org; 28 Oct 2020 08:52:52 +0000 Original-Received: from localhost ([127.0.0.1]:47071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhCN-0004XV-Vn for submit@debbugs.gnu.org; Wed, 28 Oct 2020 04:52:52 -0400 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:45796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhCK-0004XG-Qk for 13780@debbugs.gnu.org; Wed, 28 Oct 2020 04:52:50 -0400 Original-Received: by mail-ej1-f45.google.com with SMTP id dt13so6030222ejb.12 for <13780@debbugs.gnu.org>; Wed, 28 Oct 2020 01:52:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=4VZTc9fOlolqhiQL7yLHevRTRePO/PSlSe437tvKVhs=; b=EdhX91KntwGrJBD4mpQfxqBBxqZ+70IuxV4PU9hH59RfjIeDmQnmMSreSJ4qxo2jFe HCOVagVOEMT6KDHARbp11XYOuIM71xSw25eZIvmTh0s33YnnRSvuSS9pxHEu+2G2GfjD 8Z/6l+bgI4r0Tlt6oWWPFpNLlL7U9UKeCRzxq/4qleFx29bzZSSxmhbhBRw9W9E4MMw/ EB7tIShwpuJyk2BolOVkH7XMjF02Vofw3d/DCDLbNMeQcu/Z6K4UUitoIhpDODMQrjlZ tbXJx6j/3ihmBCSfd0yKfSX9oA+qayNZkMADtSe8RNg6WvpE6kx1uPSZqJeaSCCsYKF1 RWtw== X-Gm-Message-State: AOAM533oKtQ4/qdFmy+vs0KQR2YtAg0cDjmpu97WnrzuJBpUOMh8/S1+ j/ReQ5y8GGynTKGmSRiBWj2nmkfms0Xgcc1N7/I= X-Google-Smtp-Source: ABdhPJy1rCrjk09U1eUpoIUhKo9rWW9ToHut8cWmTSDmKf2CqQpZEPOJoOxMzDbwfV0HmUc6DcRTviSFNfAljuNMMVs= X-Received: by 2002:a17:906:bc91:: with SMTP id lv17mr6734975ejb.249.1603875162879; Wed, 28 Oct 2020 01:52:42 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 28 Oct 2020 01:52:42 -0700 In-Reply-To: (Stefan Monnier's message of "Fri, 22 Feb 2013 15:58:13 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191825 Archived-At: --000000000000591e1f05b2b74942 Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: >>> So until Custom ...blabla... I think it's better to use defcustom for >>> hooks very sparingly, i.e. only for those hook we can reasonably >>> expect will only be modified by the user's customization. >> So do you think the existing customization ability for find-file-hook >> should be removed? Or at least some kind of warning attached? > > Yes, So how about the attached? --000000000000591e1f05b2b74942 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Don-t-allow-customizing-find-file-hook.patch" Content-Disposition: attachment; filename="0001-Don-t-allow-customizing-find-file-hook.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 5fb0254658b2a17e_0.1 RnJvbSBkNTA0ZjdhMDJmZjFhZGNlZTYwYjk1NjllNmExNjFkNTBlN2UzN2M3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogV2VkLCAyOCBPY3QgMjAyMCAwOTo1MTowNSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIERvbid0 IGFsbG93IGN1c3RvbWl6aW5nIGZpbmQtZmlsZS1ob29rCgoqIGxpc3AvZmlsZXMuZWwgKGZpbmQt ZmlsZS1ob29rKTogTWFrZSBpbnRvIGRlZnZhci4gIChCdWcjMTM3ODApCi0tLQogbGlzcC9maWxl cy5lbCB8IDggKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDYgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xpc3AvZmlsZXMuZWwKaW5k ZXggZmRmNzU4YWQ5Mi4uM2QzZGVjZTY5MSAxMDA2NDQKLS0tIGEvbGlzcC9maWxlcy5lbAorKysg Yi9saXNwL2ZpbGVzLmVsCkBAIC00OTgsMTUgKzQ5OCwxMSBAQCBmaW5kLWZpbGUtbm90LWZvdW5k LWZ1bmN0aW9ucwogOzs7KHB1dCAnZmluZC1maWxlLWhvb2sgJ3Blcm1hbmVudC1sb2NhbCB0KQog OzsgSSBmb3VuZCBzb21lIGV4dGVybmFsIGZpbGVzIHN0aWxsIHVzaW5nIHRoZSBvYnNvbGV0ZSBm b3JtIGluIDIwMTguCiAoZGVmaW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdmaW5kLWZpbGUt aG9va3MgJ2ZpbmQtZmlsZS1ob29rICIyMi4xIikKLShkZWZjdXN0b20gZmluZC1maWxlLWhvb2sg bmlsCisoZGVmdmFyIGZpbmQtZmlsZS1ob29rIG5pbAogICAiTGlzdCBvZiBmdW5jdGlvbnMgdG8g YmUgY2FsbGVkIGFmdGVyIGEgYnVmZmVyIGlzIGxvYWRlZCBmcm9tIGEgZmlsZS4KIFRoZSBidWZm ZXIncyBsb2NhbCB2YXJpYWJsZXMgKGlmIGFueSkgd2lsbCBoYXZlIGJlZW4gcHJvY2Vzc2VkIGJl Zm9yZSB0aGUKIGZ1bmN0aW9ucyBhcmUgY2FsbGVkLiAgVGhpcyBpbmNsdWRlcyBkaXJlY3Rvcnkt bG9jYWwgdmFyaWFibGVzLCBpZiBhbnksCi1mb3IgdGhlIGZpbGUncyBkaXJlY3RvcnkuIgotICA6 Z3JvdXAgJ2ZpbmQtZmlsZQotICA6dHlwZSAnaG9vawotICA6b3B0aW9ucyAnKGF1dG8taW5zZXJ0 KQotICA6dmVyc2lvbiAiMjIuMSIpCitmb3IgdGhlIGZpbGUncyBkaXJlY3RvcnkuIikKIAogOzsg SSBmb3VuZCBzb21lIGV4dGVybmFsIGZpbGVzIHN0aWxsIHVzaW5nIHRoZSBvYnNvbGV0ZSBmb3Jt IGluIDIwMTguCiAoZGVmaW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICd3cml0ZS1maWxlLWhv b2tzICd3cml0ZS1maWxlLWZ1bmN0aW9ucyAiMjIuMSIpCi0tIAoyLjI4LjAKCg== --000000000000591e1f05b2b74942--