From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36707: [PATCH] Signal user-error on duplicate package refresh Date: Sun, 18 Aug 2019 20:18:05 +0200 Message-ID: References: <874l3j11v4.fsf@tcd.ie> <87lfw3qjle.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="269628"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "Basil L. Contovounesios" , 36707@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 18 20:19:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzPln-00181g-O2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 20:19:11 +0200 Original-Received: from localhost ([::1]:42456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzPlm-0005vt-3Y for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 14:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49492) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzPlf-0005uN-Ct for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 14:19:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzPle-0007qK-CG for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 14:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49814) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzPle-0007q2-9E for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 14:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzPle-0007N8-2r for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 14:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2019 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36707-submit@debbugs.gnu.org id=B36707.156615230528266 (code B ref 36707); Sun, 18 Aug 2019 18:19:02 +0000 Original-Received: (at 36707) by debbugs.gnu.org; 18 Aug 2019 18:18:25 +0000 Original-Received: from localhost ([127.0.0.1]:58635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzPl2-0007Lq-VC for submit@debbugs.gnu.org; Sun, 18 Aug 2019 14:18:25 -0400 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:45346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzPl0-0007LX-Ue for 36707@debbugs.gnu.org; Sun, 18 Aug 2019 14:18:23 -0400 Original-Received: by mail-pg1-f178.google.com with SMTP id o13so5555137pgp.12 for <36707@debbugs.gnu.org>; Sun, 18 Aug 2019 11:18:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F4ev9ZyhRvEHRNsaW1EvD1/LBfKk4ZO5samETPf0BPw=; b=RR0HGkIei8kNlj8uScjhWUGGZ3yTJDrHaGzhEac+3dZ+NTujdnuT7fKZXIUWj5i3fX NV2Jpplkk00swhyjFjlcZZJCrEmvg6j0rODQxs7HeJQFpJNPXuyeU8KrznMl7OwDGe1j 2gZSQbw22+CHp0vx80EmHckl3mq8cyA9BWcacdF1zvdvR5OFAYytafnC0nW4Zsyfy6Pk m2wsfAyOKZoXuWF7hw5dwspjljPYNqzjLVoExS2A4kdBKN3RmtlxvikTb167/NqkV2FR drWBQBeKhDjojbSbdZLgeWXM98WIT/PplVTjOPkf2eRv7gPL0VUCjxBzKd7ryN+5q8/H 8zJQ== X-Gm-Message-State: APjAAAXiGXtPjZnqPWJ7WT4uMo45U8GmZxtdW8t6kuGcRPdVpTcHZYmz YqZ4b69qC3uiJVLC+9W+AjmFA5UQEcPxHVDGcyI= X-Google-Smtp-Source: APXvYqxrFvzzPhTUdLB+4/1jqgKCbC+RzM3qB5TQ7HloeDPpxvrb94wICoYEh6EqA0JWFebCu073Nq4rKOtBMANbX3c= X-Received: by 2002:a63:5f01:: with SMTP id t1mr15216735pgb.200.1566152297235; Sun, 18 Aug 2019 11:18:17 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165352 Archived-At: Stefan Kangas writes: > Noam Postavsky writes: > > > "Basil L. Contovounesios" writes: > > > > > Stefan Kangas writes: > > > > > >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many times > > >> it will try to initiate more refreshes even if the first one has not finished > > >> yet. This is unnecessary and potentially confusing. > > >> > > >> This patch makes it check if there is already an refresh in progress and signal > > >> a user-error if there is one. > > > > > > Would it not be possible/better to discard the existing refresh and > > > start a new one, instead of signalling an error? This would help > > > e.g. when a refresh hangs for whatever reason. > > > > Not sure if it's better, supposing the user is hitting "r" repeatedly, > > that just interrupts the pending refreshes, preventing any progress. I > > would expect hanging to be cancelled by a timeout anyway. > > I agree with Noam that a timeout would make more sense. Not sure if > it already exists or if that's a separate issue. Are there any other objections to the patch? Otherwise, I'll go ahead and push it in a few days. Thanks, Stefan Kangas