From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#6581: 24.0.50; `equal-including-properties' uses `eq' to compare property values Date: Wed, 20 Oct 2021 07:49:59 -0700 Message-ID: References: <4C348D05.9000601@fastmail.net> <86bnm3igle.fsf@yandex.ru> <54B53D6B.5050903@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000799f2f05cec9e410" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9333"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 6581@debbugs.gnu.org, Christian Ohler , Dmitry Gutov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 20 16:51:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdCwE-0002CX-Tx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 16:51:31 +0200 Original-Received: from localhost ([::1]:40414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdCwD-0004Wz-7C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 10:51:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdCvm-0004UA-O2 for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 10:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdCvm-0003rF-AU for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 10:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdCvm-0005kw-5u for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Oct 2021 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy confirmed Original-Received: via spool by 6581-submit@debbugs.gnu.org id=B6581.163474140922040 (code B ref 6581); Wed, 20 Oct 2021 14:51:02 +0000 Original-Received: (at 6581) by debbugs.gnu.org; 20 Oct 2021 14:50:09 +0000 Original-Received: from localhost ([127.0.0.1]:55128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdCuu-0005jP-It for submit@debbugs.gnu.org; Wed, 20 Oct 2021 10:50:09 -0400 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:42576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdCus-0005ic-Cd for 6581@debbugs.gnu.org; Wed, 20 Oct 2021 10:50:07 -0400 Original-Received: by mail-pl1-f181.google.com with SMTP id w17so4467036plg.9 for <6581@debbugs.gnu.org>; Wed, 20 Oct 2021 07:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=zEpcvF7Qdeey3TRisfDUxIb4ZC4++Z0gUV++uMN1sQU=; b=arSjwjsyVuEwkwn9BEvwSU4059UHifNdWBI5rIPqHYfUtnL3t6CVq9fpX0wvF4sghJ 7kFxv8ksNtwrWzQ4oLAg9YW5PLfFSiJt3y+fkracU8jj8ISQbh+o4PgF/LErCIOCVTyN 1u/G4suHeDHV39y8dhySHXSmR1Gww1iYT6o4vhpn2nPiu7FiQFWqU6aw8yYDejGaCqWo SfxiArLkZBD4+8d1+2Xj0VZY8G9Md2/Cm3e8aydvrTkfKUCM0NJc7QSZk9LSD1Yw/WtP t9cmx9PAH5BpJ46RFRclgc4DVLhRgCln9GzORwJJml+aoaJvI9ObH5n/9oqWPBFl5tC9 iQmg== X-Gm-Message-State: AOAM533HNDSRywJbeMwH2QCFKpdW+s8XhrKjBzInT6i1D4lLIM3WTRbk AwbcmUX8h/LhEgRIjCnDAtaX+FWGyJSTtdR6O/c= X-Google-Smtp-Source: ABdhPJyNj/65xErxRmEggwL7YaYbVZ9g/JsrnyAy3Nk5DxkeZh7oUYkXYJwPmUpuWzPvubOgKGsI2ybeVtRFgu0BHGc= X-Received: by 2002:a17:90a:c70d:: with SMTP id o13mr7957701pjt.143.1634741400467; Wed, 20 Oct 2021 07:50:00 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 20 Oct 2021 07:49:59 -0700 In-Reply-To: (Stefan Monnier's message of "Tue, 13 Jan 2015 14:53:22 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217675 Archived-At: --000000000000799f2f05cec9e410 Content-Type: text/plain; charset="UTF-8" tags 6581 + patch thanks Stefan Monnier writes: >>> The intention is to use `equal-including-properties' when >>> comparing the property values. >> So you agree the behavior should be fixed? > > Yes. The attached patch should fix it. --000000000000799f2f05cec9e410 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Fix-bug-with-string-values-in-equal-including-proper.patch" Content-Disposition: attachment; filename="0001-Fix-bug-with-string-values-in-equal-including-proper.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 26c4fd8414290b19_0.1 RnJvbSA1MmNiODYxMGNjNDgwNWJlODllY2Y3NzI4NWQ5ZTZkMWVmYWY5MzY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogV2VkLCAyMCBPY3QgMjAyMSAxNDoxNjowNyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBi dWcgd2l0aCBzdHJpbmcgdmFsdWVzIGluIGVxdWFsLWluY2x1ZGluZy1wcm9wZXJ0aWVzCgoqIHNy Yy9pbnRlcnZhbHMuYyAoaW50ZXJ2YWxzX2VxdWFsXzEpOiBGYWN0b3Igb3V0IGZyb20KaW50ZXJ2 YWxzX2VxdWFsLiAgVXNlIEZlcXVhbCBmb3IgY29tcGFyaXNvbiBpZiB0aGlyZCBhcmd1bWVudAp1 c2VfZXF1YWwgaXMgdHJ1ZS4gIFRoaXMgZml4ZXMgYSBidWcgd2l0aCBzdHJpbmcgdmFsdWVzIGlu IHByb3BlcnR5Cmxpc3RzIGNvbXBhcmVkIHdpdGggJ2VxdWFsLWluY2x1ZGluZy1wcm9wZXJ0aWVz Jy4gIChCdWcjNjU4MSkKKGludGVydmFsc19lcXVhbCk6IFVwZGF0ZSBmb3IgdGhlIGFib3ZlLgoo Y29tcGFyZV9zdHJpbmdfaW50ZXJ2YWxzKTogQ2FsbCBpbnRlcnZhbHNfZXF1YWwxIHdpdGggdGhp cmQKYXJndW1lbnQgYXMgdHJ1ZS4KKiBzcmMvaW50ZXJ2YWxzLmggKGludGVydmFsc19lcXVhbF8x KTogRGVjbGFyZS4KKiB0ZXN0L3NyYy9mbnMtdGVzdHMuZWwgKGZucy10ZXN0cy1lcXVhbC1pbmNs dWRpbmctcHJvcGVydGllcykKKGZucy10ZXN0cy1lcXVhbC1pbmNsdWRpbmctcHJvcGVydGllcy9z dHJpbmctcHJvcC12YWxzKTogTmV3IHRlc3RzLgotLS0KIHNyYy9pbnRlcnZhbHMuYyAgICAgICB8 IDE4ICsrKysrKysrKysrKysrLS0tLQogc3JjL2ludGVydmFscy5oICAgICAgIHwgIDEgKwogdGVz dC9zcmMvZm5zLXRlc3RzLmVsIHwgMTkgKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFu Z2VkLCAzNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9p bnRlcnZhbHMuYyBiL3NyYy9pbnRlcnZhbHMuYwppbmRleCBmODhhNDFmMjU0Li5jZWY1ZDlhNGQ3 IDEwMDY0NAotLS0gYS9zcmMvaW50ZXJ2YWxzLmMKKysrIGIvc3JjL2ludGVydmFscy5jCkBAIC0x NjYsMTAgKzE2NiwxMSBAQCBtZXJnZV9wcm9wZXJ0aWVzIChyZWdpc3RlciBJTlRFUlZBTCBzb3Vy Y2UsIHJlZ2lzdGVyIElOVEVSVkFMIHRhcmdldCkKICAgICB9CiB9CiAKLS8qIFJldHVybiB0cnVl IGlmIHRoZSB0d28gaW50ZXJ2YWxzIGhhdmUgdGhlIHNhbWUgcHJvcGVydGllcy4gICovCisvKiBS ZXR1cm4gdHJ1ZSBpZiB0aGUgdHdvIGludGVydmFscyBoYXZlIHRoZSBzYW1lIHByb3BlcnRpZXMu CisgICBJZiB1c2VfZXF1YWwgaXMgdHJ1ZSwgdXNlIEZlcXVhbCBmb3IgY29tcGFyaXNvbnMgaW5z dGVhZCBvZiBFUS4gICovCiAKIGJvb2wKLWludGVydmFsc19lcXVhbCAoSU5URVJWQUwgaTAsIElO VEVSVkFMIGkxKQoraW50ZXJ2YWxzX2VxdWFsXzEgKElOVEVSVkFMIGkwLCBJTlRFUlZBTCBpMSwg Ym9vbCB1c2VfZXF1YWwpCiB7CiAgIExpc3BfT2JqZWN0IGkwX2NkciwgaTBfc3ltOwogICBMaXNw X09iamVjdCBpMV9jZHIsIGkxX3ZhbDsKQEAgLTIwNCw3ICsyMDUsOCBAQCBpbnRlcnZhbHNfZXF1 YWwgKElOVEVSVkFMIGkwLCBJTlRFUlZBTCBpMSkKICAgICAgIC8qIGkwIGFuZCBpMSBib3RoIGhh dmUgc3ltLCBidXQgaXQgaGFzIGRpZmZlcmVudCB2YWx1ZXMgaW4gZWFjaC4gICovCiAgICAgICBp ZiAoIUNPTlNQIChpMV92YWwpCiAJICB8fCAoaTFfdmFsID0gWENEUiAoaTFfdmFsKSwgIUNPTlNQ IChpMV92YWwpKQotCSAgfHwgIUVRIChYQ0FSIChpMV92YWwpLCBYQ0FSIChpMF9jZHIpKSkKKwkg IHx8ICghdXNlX2VxdWFsICYmICFFUSAoWENBUiAoaTFfdmFsKSwgWENBUiAoaTBfY2RyKSkpCisJ ICB8fCAodXNlX2VxdWFsICYmIE5JTFAgKEZlcXVhbCAoWENBUiAoaTFfdmFsKSwgWENBUiAoaTBf Y2RyKSkpKSkKIAlyZXR1cm4gZmFsc2U7CiAKICAgICAgIGkwX2NkciA9IFhDRFIgKGkwX2Nkcik7 CkBAIC0yMTgsNiArMjIwLDE0IEBAIGludGVydmFsc19lcXVhbCAoSU5URVJWQUwgaTAsIElOVEVS VkFMIGkxKQogICAvKiBMZW5ndGhzIG9mIHRoZSB0d28gcGxpc3RzIHdlcmUgZXF1YWwuICAqLwog ICByZXR1cm4gKE5JTFAgKGkwX2NkcikgJiYgTklMUCAoaTFfY2RyKSk7CiB9CisKKy8qIFJldHVy biB0cnVlIGlmIHRoZSB0d28gaW50ZXJ2YWxzIGhhdmUgdGhlIHNhbWUgcHJvcGVydGllcy4gICov CisKK2Jvb2wKK2ludGVydmFsc19lcXVhbCAoSU5URVJWQUwgaTAsIElOVEVSVkFMIGkxKQorewor ICByZXR1cm4gaW50ZXJ2YWxzX2VxdWFsXzEgKGkwLCBpMSwgZmFsc2UpOworfQogDAogCiAvKiBU cmF2ZXJzZSBhbiBpbnRlcnZhbCB0cmVlIFRSRUUsIHBlcmZvcm1pbmcgRlVOQ1RJT04gb24gZWFj aCBub2RlLgpAQCAtMjI5MSw3ICsyMzAxLDcgQEAgY29tcGFyZV9zdHJpbmdfaW50ZXJ2YWxzIChM aXNwX09iamVjdCBzMSwgTGlzcF9PYmplY3QgczIpCiAKICAgICAgIC8qIElmIHdlIGV2ZXIgZmlu ZCBhIG1pc21hdGNoIGJldHdlZW4gdGhlIHN0cmluZ3MsCiAJIHRoZXkgZGlmZmVyLiAgKi8KLSAg ICAgIGlmICghIGludGVydmFsc19lcXVhbCAoaTEsIGkyKSkKKyAgICAgIGlmICghIGludGVydmFs c19lcXVhbF8xIChpMSwgaTIsIHRydWUpKQogCXJldHVybiAwOwogCiAgICAgICAvKiBBZHZhbmNl IFBPUyB0aWxsIHRoZSBlbmQgb2YgdGhlIHNob3J0ZXIgaW50ZXJ2YWwsCmRpZmYgLS1naXQgYS9z cmMvaW50ZXJ2YWxzLmggYi9zcmMvaW50ZXJ2YWxzLmgKaW5kZXggYzFiMTkzNDVkMi4uNDA5NmRj MDJmZCAxMDA2NDQKLS0tIGEvc3JjL2ludGVydmFscy5oCisrKyBiL3NyYy9pbnRlcnZhbHMuaApA QCAtMjQzLDYgKzI0Myw3IEBAICNkZWZpbmUgVEVYVF9QUk9QX01FQU5TX0lOVklTSUJMRShwcm9w KQkJCQkJXAogCiBleHRlcm4gSU5URVJWQUwgY3JlYXRlX3Jvb3RfaW50ZXJ2YWwgKExpc3BfT2Jq ZWN0KTsKIGV4dGVybiB2b2lkIGNvcHlfcHJvcGVydGllcyAoSU5URVJWQUwsIElOVEVSVkFMKTsK K2Jvb2wgaW50ZXJ2YWxzX2VxdWFsXzEgKElOVEVSVkFMLCBJTlRFUlZBTCwgYm9vbCk7CiBleHRl cm4gYm9vbCBpbnRlcnZhbHNfZXF1YWwgKElOVEVSVkFMLCBJTlRFUlZBTCk7CiBleHRlcm4gdm9p ZCB0cmF2ZXJzZV9pbnRlcnZhbHMgKElOVEVSVkFMLCBwdHJkaWZmX3QsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHZvaWQgKCopIChJTlRFUlZBTCwgTGlzcF9PYmplY3QpLApkaWZm IC0tZ2l0IGEvdGVzdC9zcmMvZm5zLXRlc3RzLmVsIGIvdGVzdC9zcmMvZm5zLXRlc3RzLmVsCmlu ZGV4IDNkYzJlN2IzZWMuLmI0Y2IzYzEzMWEgMTAwNjQ0Ci0tLSBhL3Rlc3Qvc3JjL2Zucy10ZXN0 cy5lbAorKysgYi90ZXN0L3NyYy9mbnMtdGVzdHMuZWwKQEAgLTU3LDYgKzU3LDI1IEBAIGZucy10 ZXN0cy1lcXVhbGl0eS1uYW4KICAgICAgIChwdXRoYXNoIG5hbiB0IGgpCiAgICAgICAoc2hvdWxk IChlcSAoZnVuY2FsbCB0ZXN0IG5hbiAtbmFuKSAoZ2V0aGFzaCAtbmFuIGgpKSkpKSkKIAorKGVy dC1kZWZ0ZXN0IGZucy10ZXN0cy1lcXVhbC1pbmNsdWRpbmctcHJvcGVydGllcyAoKQorICAoc2hv dWxkIChlcXVhbC1pbmNsdWRpbmctcHJvcGVydGllcyAiIiAiIikpCisgIChzaG91bGQgKGVxdWFs LWluY2x1ZGluZy1wcm9wZXJ0aWVzICJmb29iYXIiICJmb29iYXIiKSkKKyAgKHNob3VsZCAoZXF1 YWwtaW5jbHVkaW5nLXByb3BlcnRpZXMgIygiYSIgMCAxIChrIHYpKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAjKCJhIiAwIDEgKGsgdikpKSkKKyAgKHNob3VsZC1ub3Qg KGVxdWFsLWluY2x1ZGluZy1wcm9wZXJ0aWVzICMoImEiIDAgMSAoayB2KSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMoImEiIDAgMSAoayB4KSkpKQorICAoc2hv dWxkLW5vdCAoZXF1YWwtaW5jbHVkaW5nLXByb3BlcnRpZXMgIygiYSIgMCAxIChrIHYpKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIygiYiIgMCAxIChrIHYpKSkp KQorCisoZXJ0LWRlZnRlc3QgZm5zLXRlc3RzLWVxdWFsLWluY2x1ZGluZy1wcm9wZXJ0aWVzL3N0 cmluZy1wcm9wLXZhbHMgKCkKKyAgIkhhbmRsZSBzdHJpbmcgcHJvcGVydHkgdmFsdWVzLiAgKEJ1 ZyM2NTgxKSIKKyAgKHNob3VsZCAoZXF1YWwtaW5jbHVkaW5nLXByb3BlcnRpZXMgIygiYSIgMCAx IChrICJ2IikpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMoImEiIDAg MSAoayAidiIpKSkpCisgIChzaG91bGQtbm90IChlcXVhbC1pbmNsdWRpbmctcHJvcGVydGllcyAj KCJhIiAwIDEgKGsgInYiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICMoImEiIDAgMSAoayAieCIpKSkpCisgIChzaG91bGQtbm90IChlcXVhbC1pbmNsdWRpbmct cHJvcGVydGllcyAjKCJhIiAwIDEgKGsgInYiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICMoImIiIDAgMSAoayAidiIpKSkpKQorCiAoZXJ0LWRlZnRlc3QgZm5z LXRlc3RzLXJldmVyc2UgKCkKICAgKHNob3VsZC1lcnJvciAocmV2ZXJzZSkpCiAgIChzaG91bGQt ZXJyb3IgKHJldmVyc2UgMSkpCi0tIAoyLjMwLjIKCg== --000000000000799f2f05cec9e410--