From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#66224: [PATCH] Add optional PREDICATE argument to read-directory-name Date: Sat, 13 Jan 2024 04:53:52 -0600 Message-ID: References: <877coch0q7.fsf@breatheoutbreathe.in> <874jje1xds.fsf@posteo.net> <87bkdly7t4.fsf@breatheoutbreathe.in> <871qehr5vs.fsf@web.de> <877co9y5jt.fsf@breatheoutbreathe.in> <877co4tmav.fsf@web.de> <87bkdf47g5.fsf@breatheoutbreathe.in> <87pm1t3lqx.fsf@web.de> <87v8blzw89.fsf@breatheoutbreathe.in> <87il66og65.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38307"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, philipk@posteo.net, 66224@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 13 11:54:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rObek-0009kF-O9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jan 2024 11:54:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rObeR-0007Qx-SW; Sat, 13 Jan 2024 05:54:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rObeN-0007Px-Jo for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 05:54:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rObeN-0006WP-4G for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 05:54:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rObeL-0006qa-Jh for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 05:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2024 10:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66224-submit@debbugs.gnu.org id=B66224.170514323926311 (code B ref 66224); Sat, 13 Jan 2024 10:54:01 +0000 Original-Received: (at 66224) by debbugs.gnu.org; 13 Jan 2024 10:53:59 +0000 Original-Received: from localhost ([127.0.0.1]:38535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rObeJ-0006qJ-3D for submit@debbugs.gnu.org; Sat, 13 Jan 2024 05:53:59 -0500 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:46098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rObeH-0006q6-33 for 66224@debbugs.gnu.org; Sat, 13 Jan 2024 05:53:57 -0500 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-555e07761acso8730375a12.0 for <66224@debbugs.gnu.org>; Sat, 13 Jan 2024 02:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705143232; x=1705748032; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=yLbGgvEvMjTbjTML7Zxglk78bg33sCvUbTRXOkx1seU=; b=HvexdRORkQSq3DrsIeTIC91hI2Itnz8ugT29lYx0tVi6xzcvoAEpT2kNNadZHGJz8h kmgo5KcnYz4wZHWAb1x+WDIMtTPJOnbESVFfmNcVcIBWwHjbg8TofW0l9kMY98i3R64V Mo+dUwn8iiJ6IMDnprY0d3f8thWnl8ejxIceNZDtlJ9s2D+P2UYZ8OOWZy6SKGb3t+pL oED5GLPTgIZlLvoHpVkPn7bGqdua+W5f6Q+mkoJBqJ2MMgh2eFzHmhNJU13cjieo/lQ/ q5x1KJpsCKYVdIhqBdbJQP8qa/jLQE/c/ku50m/b3CW6K2EGWoTuujJZNLv/xk8vvqij xEZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705143232; x=1705748032; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yLbGgvEvMjTbjTML7Zxglk78bg33sCvUbTRXOkx1seU=; b=XLQ//9ubPmn7zsCtxmenUn7DFpdOhM/2rgm0LEnAXyvX4v+XGXcR9e4ymhbmv8sE7H crwfaUS8r/C05hQOYqJmHkrHMiELQXGrit7duQVxbtzVKSl/Wz2cOOGc/ig2C38KqWVH QSJYwXBjLYbonHbhEtE4EtIwnLCjc0frNg1+xzq9t9YzbzYC+WhgjK5xG4C7T9j1iHvw 6RUtsJfSA7Mw6+PabbbW5mIxcdhgJZnWO9sbHOzETquvJ9FPyOzdk+pI93yRgTrjCibU rcr0ht3AHcN53sJedCm9pUMmngHHX+B1fZB6NaUlPu159DNRpH+g2SLOKIi3QyqsrUCt 2l/g== X-Gm-Message-State: AOJu0YxXRsZdgs8krOzhNwLDpgJ4UvraD0FxiciD577/HD73QcStdcuK PNCCtkEl3I0CqvyI/zPFpEIps3gSRf9oyqZ3vcn2ngEF X-Google-Smtp-Source: AGHT+IEAJxCv91umGdzw2HaCWRwlORitd4ltTd8wkPjiu0hhqgXb5qt+IQpZ7RnuWgdJrbbgsCbwwM5M1CEFkBxzDao= X-Received: by 2002:a05:6402:78a:b0:559:e97:c967 with SMTP id d10-20020a056402078a00b005590e97c967mr74790edy.77.1705143232649; Sat, 13 Jan 2024 02:53:52 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 13 Jan 2024 04:53:52 -0600 In-Reply-To: <87il66og65.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 12 Nov 2023 12:42:42 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278120 Archived-At: Joseph Turner writes: > Joseph Turner writes: > >> Michael Heerdegen writes: >> >>> Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of >>> text editors" writes: >>> >>>> I'm not sure what you mean. In both of the following examples, PREDICATE >>>> is used to narrow the completion candidates to only empty directories: >>>> >>>> (read-directory-name "Prompt: " "~/" nil t nil #'directory-empty-p) >>>> (read-directory-name "Prompt: " "~/" nil nil nil #'directory-empty-p) >>> >>> In the second version also non-empty directories will be accepted. >> >> Yes, PREDICATE narrows the completion candidates but doesn't determine a >> valid return value. > > Ping! I'm happy to keep discussing this patch if others are interested. Could you please send the latest version of your patch?