From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#15112: 24.3; package.el byte compile autoloads Date: Wed, 25 Nov 2020 21:44:41 -0500 Message-ID: References: <8738q96sb1.fsf@blah.blah> <85zhjtibwn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38413"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Kevin Ryde , 15112@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 03:45:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki7He-0009st-Io for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 03:45:22 +0100 Original-Received: from localhost ([::1]:60238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki7Hd-0006qI-IZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 21:45:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki7HK-0006pk-Rh for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 21:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ki7HK-0007CK-Jz for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 21:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ki7HK-0004h0-Gd for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 21:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 02:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15112 X-GNU-PR-Package: emacs Original-Received: via spool by 15112-submit@debbugs.gnu.org id=B15112.160635869018006 (code B ref 15112); Thu, 26 Nov 2020 02:45:02 +0000 Original-Received: (at 15112) by debbugs.gnu.org; 26 Nov 2020 02:44:50 +0000 Original-Received: from localhost ([127.0.0.1]:37636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki7H8-0004gL-BG for submit@debbugs.gnu.org; Wed, 25 Nov 2020 21:44:50 -0500 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:39386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki7H6-0004g8-4P for 15112@debbugs.gnu.org; Wed, 25 Nov 2020 21:44:48 -0500 Original-Received: by mail-ej1-f52.google.com with SMTP id mc24so699253ejb.6 for <15112@debbugs.gnu.org>; Wed, 25 Nov 2020 18:44:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=CTlPjJBAVaXPyfko7Jpb2uhArfeyDo+nBwlKDhUOv+8=; b=GofLu50PlVNx8a69hDRpCz10+HXVOKKY32IeDWyTpWEBb5u3WBxnKhjoqwx7gdFUyW WBP8IduCEFXcAUU4vhcjNAzcNnn+8aMl6fTzCB9PWGbZi0WzglJdr8EnCq15JoEOJXY5 BCo9GbI8qdLCEsD908noZx5YbvO8vTQMb7EDlfsdBi/CpRKn3MtidcUA+8lK0FVn/Geh aafet71hShQ9VhvhqrQw+1ar4HDKRRH6mbHrCoh0FlOvjqm+ONHErqhrjXhbsa4iDK9q Ck6blaCmuJLWXBqqa2LMe978tKnGite0AyLTcLss+EVaISJtLZfm9Ak7Z0SJPr4204IW KHjg== X-Gm-Message-State: AOAM533lC9FSKcWQ9Vexn0vXkfPmpG9VPB1/vcPtbjVGrL3YnDsRv4uI zKp+LrAphgz2lVYuWi5mNN8qZK8AdohornIMw3s= X-Google-Smtp-Source: ABdhPJzlL8E29ZS8j03dA9Ib7IjUTRX9neFDNJlBFkCjLDs/z5YPJwkaBzkETxpzAcGQUKSE9Da2hwHwnJ0RvkGJ3W4= X-Received: by 2002:a17:906:451:: with SMTP id e17mr798286eja.477.1606358682376; Wed, 25 Nov 2020 18:44:42 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 25 Nov 2020 21:44:41 -0500 In-Reply-To: <85zhjtibwn.fsf@gmail.com> (Noam Postavsky's message of "Wed, 28 Aug 2019 10:48:24 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194255 Archived-At: Noam Postavsky writes: > Stefan Kangas writes: > >> package-autoload-ensure-default-file now uses autoload-rubric internally >> and no longer contains the line quoted above with "no-byte-compile". >> However, autoload-rubric still contains it. >> >> I guess the question is if it's there for good reason or could perhaps >> be omitted. If there's a good reason for it, perhaps this bug should be >> closed as wontfix. >> >> Noam, I noted that you added a comment to this particular line recently >> in commit 1f7b602f84. Could you perhaps shed some light on why we use >> no-byte-compile here? > > As the comment says "#$ is byte-compiled into nil", and we use #$ in the > generated autoloaded file. So byte-compiling would break it. > > I think it would work to use load-file-name instead. I made a little experiment and of course byte-compiling these files gives us a ton of headaches, see below. So I'm not sure this is all worth it. Do we have reason to believe that byte-compiling these files would give any significant performance increase? ELC net/tramp-loaddefs.elc In toplevel form: net/tramp-loaddefs.el:28:36: Warning: reference to free variable =E2=80=98tramp-methods=E2=80=99 net/tramp-loaddefs.el:28:36: Warning: assignment to free variable =E2=80=98tramp-methods=E2=80=99 net/tramp-loaddefs.el:28:217: Warning: reference to free variable =E2=80=98tramp-default-host-alist=E2=80=99 net/tramp-loaddefs.el:28:217: Warning: assignment to free variable =E2=80=98tramp-default-host-alist=E2=80=99 net/tramp-loaddefs.el:361:175: Warning: reference to free variable =E2=80=98tramp-default-method-alist=E2=80=99 net/tramp-loaddefs.el:361:175: Warning: assignment to free variable =E2=80=98tramp-default-method-alist=E2=80=99 net/tramp-loaddefs.el:373:36: Warning: reference to free variable =E2=80=98tramp-foreign-file-name-handler-alist=E2=80=99 net/tramp-loaddefs.el:373:36: Warning: assignment to free variable =E2=80=98tramp-foreign-file-name-handler-alist=E2=80=99 ELC net/tramp-rclone.elc net/tramp-loaddefs.el:521:7366: Warning: reference to free variable =E2=80=98tramp-local-host-regexp=E2=80=99 net/tramp-loaddefs.el:521:7424: Warning: reference to free variable =E2=80=98tramp-default-user-alist=E2=80=99 ELC net/tramp-sh.elc net/tramp-loaddefs.el:521:7541: Warning: assignment to free variable =E2=80=98tramp-default-user-alist=E2=80=99 In end of data: net/tramp-loaddefs.el:768:1: Warning: the following functions are not known= to be defined: tramp--with-startup, tramp-set-completion-function, tramp-tramp-file-p, tramp-file-name-method, tramp-dissect-file-name, tramp-register-foreign-file-name-handler, tramp-compat-file-name-quoted= -p ELC net/tramp-smb.elc ELC net/tramp-sudoedit.elc ELC net/tramp-uu.elc ELC net/tramp.elc In toplevel form: net/tramp-rclone.el:39:1: Error: Symbol=E2=80=99s value as variable is void= : tramp-methods make[3]: *** [Makefile:295: net/tramp-rclone.elc] Error 1 make[3]: *** Waiting for unfinished jobs.... In toplevel form: net/tramp-sh.el:35:1: Error: Symbol=E2=80=99s value as variable is void: tr= amp-methods make[3]: *** [Makefile:295: net/tramp-sh.elc] Error 1 In toplevel form: net/tramp-smb.el:31:1: Error: Symbol=E2=80=99s value as variable is void: t= ramp-methods make[3]: *** [Makefile:295: net/tramp-smb.elc] Error 1 In toplevel form: net/tramp-sudoedit.el:37:1: Error: Symbol=E2=80=99s value as variable is vo= id: tramp-methods make[3]: *** [Makefile:295: net/tramp-sudoedit.elc] Error 1 In toplevel form: net/tramp.el:89:1: Error: Symbol=E2=80=99s value as variable is void: tramp= -methods make[3]: *** [Makefile:295: net/tramp.elc] Error 1 make[3]: Leaving directory '/home/skangas/wip/emacs/lisp' make[2]: *** [Makefile:318: compile-main] Error 2 make[2]: Leaving directory '/home/skangas/wip/emacs/lisp' make[1]: *** [Makefile:411: lisp] Error 2 make[1]: Leaving directory '/home/skangas/wip/emacs' make: *** [Makefile:1126: bootstrap] Error 2