From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' Date: Tue, 19 Oct 2021 11:00:57 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3560"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51262@debbugs.gnu.org To: Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 20:02:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mctRI-0000bR-Mu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 20:02:16 +0200 Original-Received: from localhost ([::1]:41366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mctRH-0004yn-L4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 14:02:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mctR4-0004vz-6E for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 14:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mctR3-0001pX-QH for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 14:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mctR3-00088R-KG for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 14:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51262 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51262-submit@debbugs.gnu.org id=B51262.163466647031200 (code B ref 51262); Tue, 19 Oct 2021 18:02:01 +0000 Original-Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 18:01:10 +0000 Original-Received: from localhost ([127.0.0.1]:51914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mctQE-000878-Ax for submit@debbugs.gnu.org; Tue, 19 Oct 2021 14:01:10 -0400 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:56015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mctQ8-00086L-IP for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 14:01:09 -0400 Original-Received: by mail-pj1-f45.google.com with SMTP id om14so540021pjb.5 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 11:01:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=YclT5OSLDft3DnUWF1tknHSxiaNccpBwzqyoAk6K0RM=; b=VuSlNGgKQfU8QTnoawho6UXjWkWRwWih1OzTUESFqVO9IW62xXOYa09lLnZ8TB6yTr 2u+T2NmQoulcprNewTBSgIyDmKMdKSDEST+Qm7YWUlcsC/U+NBaMXz/U1K9SslyVHHhc cq94lEFbUJfBIlo/d7aTlFi5waBtPAoRCg/kkcqO/QoAM0ReMOleMIcEgct8Pq7PtZ8r 1H19fqeSTnPWqTuylYsgrZCgc5FTP61Gfuz5gQkquL9YYlRTO3RlkLkzAXkqR3P9vMLm nLa0Ch9z/2NCelDLKotA2bk2+3rAQPuL8qOL+QCWqa8ATRpXGybV8cNKs10YaR1BCIoT rjfA== X-Gm-Message-State: AOAM533F8htN83M55pnCmP8jKp3j1uXjkCd2ISnZmJPhi2ZTA4QtMGqh uulvTmObUC+jxHmbJiDF8sH/4XKACYLqBXDNFPo= X-Google-Smtp-Source: ABdhPJzhp3RfKAwVxUrMDJvwql5hefQDfzpUp26M2BP9idiOteQtCArqDHL//GXCXdOY0OquU2Wf1iOByvPcu6+GdoI= X-Received: by 2002:a17:902:c1cb:b0:13f:8e99:2158 with SMTP id c11-20020a170902c1cb00b0013f8e992158mr28094231plc.32.1634666458483; Tue, 19 Oct 2021 11:00:58 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 Oct 2021 11:00:57 -0700 In-Reply-To: ("Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?="'s message of "Tue, 19 Oct 2021 10:53:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217592 Archived-At: close 51262 28.1 thanks Jan Syn=C3=A1=C4=8Dek writes: > It looks like the following part of my ~/.gitconfig triggers the issue: > ... > [color] > ui =3D always Aha, so that's the culprit. Presumably without that, git detects that it's a "dumb" terminal and doesn't output any color escape sequences. > Colors as in interpreted escape sequences? That was my first assumption, but it's actually just font-locking. It seems like your proposed patch does fix the reported issue, and I could see no other adverse effects; the colors are there there even with your patch. I have therefore now pushed this to the emacs-28 branch (commit 5c1a575ef4) with some minor touch-ups to the commit message. I'm therefore closing this bug report. Thanks again for the bug report and patch!