From: Stefan Kangas <stefan@marxist.se>
To: "Jan Synáček" <jan.synacek@gmail.com>
Cc: 51262@debbugs.gnu.org
Subject: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry'
Date: Tue, 19 Oct 2021 11:00:57 -0700 [thread overview]
Message-ID: <CADwFkmk-W4Zh7uiBSQcFhBGsJedZ58-Ah8_KYrxoGLT3R9NMow@mail.gmail.com> (raw)
In-Reply-To: <CACA+5f0MTA3xS5Y7XRCu+TkrmnuLBjhRT-yyKW_k4mDWN-80tg@mail.gmail.com> ("Jan Synáček"'s message of "Tue, 19 Oct 2021 10:53:41 +0200")
close 51262 28.1
thanks
Jan Synáček <jan.synacek@gmail.com> writes:
> It looks like the following part of my ~/.gitconfig triggers the issue:
> ...
> [color]
> ui = always
Aha, so that's the culprit. Presumably without that, git detects that
it's a "dumb" terminal and doesn't output any color escape sequences.
> Colors as in interpreted escape sequences?
That was my first assumption, but it's actually just font-locking.
It seems like your proposed patch does fix the reported issue, and I
could see no other adverse effects; the colors are there there even with
your patch.
I have therefore now pushed this to the emacs-28 branch (commit
5c1a575ef4) with some minor touch-ups to the commit message. I'm
therefore closing this bug report.
Thanks again for the bug report and patch!
prev parent reply other threads:[~2021-10-19 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 10:45 bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' Jan Synáček
2021-10-19 5:16 ` Stefan Kangas
2021-10-19 8:15 ` Jan Synáček
2021-10-19 8:33 ` Stefan Kangas
2021-10-19 8:53 ` Jan Synáček
2021-10-19 18:00 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmk-W4Zh7uiBSQcFhBGsJedZ58-Ah8_KYrxoGLT3R9NMow@mail.gmail.com \
--to=stefan@marxist.se \
--cc=51262@debbugs.gnu.org \
--cc=jan.synacek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).