From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#40728: 27.0.91; Removed public functions from debugger.el Date: Mon, 24 Aug 2020 04:26:26 -0400 Message-ID: References: <83imhugoyq.fsf@gnu.org> <87h7x4zm2k.fsf@runbox.com> <83v9lk2k97.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5064"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gemini Lasswell , 40728@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 24 10:27:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kA7os-00016D-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 10:27:10 +0200 Original-Received: from localhost ([::1]:43872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kA7oq-0001aZ-Ql for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 04:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA7ok-0001aP-Q8 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 04:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kA7ok-0002uQ-G1 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 04:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kA7ok-0001XW-CW for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 04:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40728 X-GNU-PR-Package: emacs Original-Received: via spool by 40728-submit@debbugs.gnu.org id=B40728.15982575945878 (code B ref 40728); Mon, 24 Aug 2020 08:27:02 +0000 Original-Received: (at 40728) by debbugs.gnu.org; 24 Aug 2020 08:26:34 +0000 Original-Received: from localhost ([127.0.0.1]:55948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA7oI-0001Wk-1l for submit@debbugs.gnu.org; Mon, 24 Aug 2020 04:26:34 -0400 Original-Received: from mail-yb1-f182.google.com ([209.85.219.182]:34316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kA7oG-0001WX-Mm for 40728@debbugs.gnu.org; Mon, 24 Aug 2020 04:26:33 -0400 Original-Received: by mail-yb1-f182.google.com with SMTP id u6so4718582ybf.1 for <40728@debbugs.gnu.org>; Mon, 24 Aug 2020 01:26:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=ajbmk+iYUJDMI5OS8A21RXj9aoVzbXaDtKcOYTLbZmI=; b=o+LqL+q4qFge8B+F9ST18M5Wjcmm9BQ+TIHVIFFGe7gTKjTDGMv9SfYG/LfjHwwSjG 4mWd0tSGrLX783IGt6VGELXgxr6BNIxX21zcMKMI0sGewg5v95CNoySRdLHR8164jzdC D+/x1/3Lljx8jh9waR2XGxRr6PohbsrF+CB1KNt2f5YopmVMejn42MMg0I7qxaGTRW2a lK0wdLPu3PEDMgnhiKqIXJMvZKxD6nouEPxbPlStt3HzqaAqL5OeFzauOHKrgQ6yCTRc 7Oeh95Av28DpbovX9oBaQ3uN0iRNPQwVBbRcKztN2O4z7a5TjSrpXfRDoH/GAF499+Z5 eqHw== X-Gm-Message-State: AOAM531N62dl0bZ6aBAZhM1DRkIA7iX4VfTds8iWZe6my4LKNaykW4h3 luGvdIMMjf3VptmUBWSQWjZOZ7OmjM/XuKCo5GE= X-Google-Smtp-Source: ABdhPJwV1PLTpHqh0+kDZ6Vc4ggg4+nmRHEbwTSZ1m0bLyF7QsHQbie910EEkMFHtjU/Lb8tiY36ilanS1tRNY/Tw0E= X-Received: by 2002:a25:4ed7:: with SMTP id c206mr6363095ybb.129.1598257586764; Mon, 24 Aug 2020 01:26:26 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 24 Aug 2020 04:26:26 -0400 In-Reply-To: (Philipp Stephani's message of "Tue, 28 Apr 2020 10:26:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186113 Archived-At: Philipp Stephani writes: > Am Di., 28. Apr. 2020 um 08:32 Uhr schrieb Eli Zaretskii : >> >> > From: Gemini Lasswell >> > Cc: Philipp Stephani , 40728@debbugs.gnu.org >> > Date: Mon, 27 Apr 2020 13:54:27 -0700 >> > >> > Eli Zaretskii writes: >> > >> > > Gemini, could you please write replacements for the functions you >> > > removed, or defalias them to some equivalent replacements? I agree >> > > that public functions should not be removed, not without deprecating >> > > them first (if indeed they don't make sense). >> > >> > Here is a patch to bring those functions back. >> >> Thanks! >> >> Philipp, any comments? If not, I'd like to install this on the >> release branch. > > I haven't tested the patch in detail, but it looks fine, thanks. > I guess you want to use `define-obsolete-function-alias' instead of > `defalias' to mark the aliases as obsolete as well. > The commit message should contain a magic string such as "Don't merge > to master" to prevent reinstating the functions in Emacs 28. It seems like the patch here was never installed on the release branch. Should it be? Best regards, Stefan Kangas