From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#67968: [PATCH] A small patch to make emacs support transparent image (png, webp, svg) Date: Sun, 24 Dec 2023 06:36:51 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67968@debbugs.gnu.org To: Qiutum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 24 15:38:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHPcO-00057b-Tm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Dec 2023 15:38:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHPc6-0005Qk-2n; Sun, 24 Dec 2023 09:37:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHPc4-0005QB-Tv for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2023 09:37:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rHPc4-0004wV-KT for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2023 09:37:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rHPcA-0007bT-Fi for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2023 09:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Dec 2023 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67968 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67968-submit@debbugs.gnu.org id=B67968.170342862629132 (code B ref 67968); Sun, 24 Dec 2023 14:38:02 +0000 Original-Received: (at 67968) by debbugs.gnu.org; 24 Dec 2023 14:37:06 +0000 Original-Received: from localhost ([127.0.0.1]:51839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHPbF-0007Zn-Bo for submit@debbugs.gnu.org; Sun, 24 Dec 2023 09:37:05 -0500 Original-Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:42170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHPbD-0007ZI-Fv for 67968@debbugs.gnu.org; Sun, 24 Dec 2023 09:37:03 -0500 Original-Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5534dcfdd61so5656454a12.0 for <67968@debbugs.gnu.org>; Sun, 24 Dec 2023 06:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703428611; x=1704033411; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=7dn5s6vys9+S+hTqJPiRu6bUyK/IgDmydKC3p85DbPc=; b=W8aZrMHToVshBx3bI9ZjRn267ij6bkc1eyTzgawsDSq5Q85JnUIGlYrlH12quNsD+x 677naryqz2fzTKqBzyDghFI7aLDGH57DKDwUrgMiXdyDcK42BWMGEbgglz3boyDLhN2y uuMPshceDSNvErTz/YwRNZ9Rcx3UqfsoHwHdnxz/0C9bbduGpT+Fe1xgHUrUnksyyrNl xFcENF7uTqJczRugpiNHQ0q/u4vktupVmZ1CyjnyksdPrlMKTGG26IO8g/PzWMlO1yKc Jx0G63Ln5dCJOjUWj8nPTYKshJ8w+2PBc/ynrwl0AHxeFWEVT1/J6d28X1VHlbvlTgEF xFQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703428611; x=1704033411; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7dn5s6vys9+S+hTqJPiRu6bUyK/IgDmydKC3p85DbPc=; b=uwHW+xEbtiHnttYSG3gzOYrLMl4aZCH4VC4udN8msodfvFuOkZ8N4+deCG6+1bxtqz GtG6/iJ7VoPzSdjjFhYIWCMDMQbIrENCi3E2sRdVYP0tFzcTWrJnpTwcSS6XiJTZm3ux 6uDlK+kIWZchn0Pk3VOK12fEN+LanqhOfOS9ViGZ7gacijhVtY2tHeatie50JB/a39Kh mEuK3ujzhLAYOLRwfBA2JEyonBH6Ud/5fYesQfnASOKaci4rchraN4AG8HbeXb9i33el UZvyTlbvhkdhwibBzqrAYJ3OU+Uswz6ROIlvsFlQzZ9K8gm5WixbNJaqE+fW4X/s5LHb DW9Q== X-Gm-Message-State: AOJu0YyNAmeN5EF247f+zwsWd9IsPZM1TQlOOM35p2ICu6kHfhvsbm2+ EW3rMJGNP8Q/sx2FoDrTznu8+sO2GzCGw2kC5HDegxFaRR4= X-Google-Smtp-Source: AGHT+IE75pAW4x1nr658pnXWWDAzSKbI0H3/ARHfjjVl/txKYO+K2eCQ5Irva6FTO5NPqXlxI3SYDRgEDDAAn/LuN1s= X-Received: by 2002:a50:c01e:0:b0:554:afc1:1cc with SMTP id r30-20020a50c01e000000b00554afc101ccmr1195884edb.0.1703428611658; Sun, 24 Dec 2023 06:36:51 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Dec 2023 06:36:51 -0800 In-Reply-To: (Qiutum's message of "Fri, 22 Dec 2023 19:38:09 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276806 Archived-At: Qiutum writes: > Hi everyone, > > Recently, I've been reading the code of image.c and wondering how to make emacs support transparent image. Then I find that a small change on the > src/image.c can make it worked (and wonder why this have not been solved since the solution is so simple). > > This patch can support the transparent png, webp and svg. The core of the patch is to change the code, > > PUT_PIXEL (mask_img, x, y, *p > 0 ? PIX_MASK_DRAW : PIX_MASK_RETAIN); > > to > > PUT_PIXEL (mask_img, x, y, *p > 0 ? *p : PIX_MASK_RETAIN); > > Then all worked like a magic. > > I have checked my patch in linux by default configure option "../configure" for dwm and pgtk build for hyprland, both are fine. I don't know whether it > could support other platforms since I don't have them. > > Please check my patch and happy to hear comments. I thought we already supported transparency in png, webp and svg? Could you please explain more about the problem you are trying to solve?