From: Stefan Kangas <stefan@marxist.se>
To: adam plaice <plaice.adam+lists@gmail.com>
Cc: 37656@debbugs.gnu.org, Emacs developers <emacs-devel@gnu.org>
Subject: bug#37656: 27.0.50; Arbitrary code execution with special `mode:'
Date: Wed, 16 Oct 2019 01:17:51 +0200 [thread overview]
Message-ID: <CADwFkmk+03=J8YUy51xzBxSK2+u0DuMLq3Ur63Wr_YWv6e=C=g__2927.31894166849$1571181555$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=U1zfUsD4jTPj44mNvQX-h2gVrvXCkvjM5V7brhS71_Q@mail.gmail.com>
Stefan Kangas <stefan@marxist.se> writes:
> > The below patch seems to fix it by disabling the feature it exploits.
>
> Here is a more complete patch. Does it look like the right fix?
flymake.el was first added to Emacs in version 22.1:
4bcbcb9df3 2004-05-29 Eli Zaretskii New file.
The "multiple mode specification feature" dates back to:
9fa7bfe524 1993-09-11 Richard M. Stallman
(hack-local-variables-prop-line): Ignore any specification
for `mode:', since set-auto-mode has already handled it.
(set-auto-mode): Clean up. Handle more than one `mode:' spec in -*-.
The code that my proposed patch changes has stayed untouched since
this 1993 commit. If we agree that disabling this feature is the
solution here, a backported security fix should therefore hopefully be
a one liner all the way back to version 22.1.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2019-10-15 23:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJw81dZZmX=z-YFDwvEkuWR6xH+cf=mR9h-fcZTphwdXWrA5wg@mail.gmail.com>
2019-10-15 22:27 ` bug#37656: 27.0.50; Arbitrary code execution with special `mode:' Stefan Kangas
[not found] ` <CADwFkmnqfbsEEWkWMA2xnN1O+-JsTcCKrSYv0e3g1+jXrxRY5g@mail.gmail.com>
2019-10-15 22:55 ` Stefan Kangas
2019-10-15 23:17 ` Stefan Kangas [this message]
2019-10-16 0:35 ` Adam Plaice
2019-10-16 7:57 ` Eli Zaretskii
2019-10-16 0:55 ` Phil Sainty
[not found] ` <CADwFkmk+03=J8YUy51xzBxSK2+u0DuMLq3Ur63Wr_YWv6e=C=g@mail.gmail.com>
2019-10-16 7:58 ` Eli Zaretskii
2019-10-16 11:51 ` Adam Plaice
2019-10-16 17:09 ` Eli Zaretskii
2019-10-16 19:09 ` Phil Sainty
2019-10-16 19:34 ` Eli Zaretskii
2019-10-16 21:02 ` Adam Plaice
2019-10-08 8:48 bug#37656: 27.0.50; Opening file with specially crafted local variables can cause arbitrary code execution Inbox x adam plaice
2019-10-15 21:05 ` bug#37656: 27.0.50; Arbitrary code execution with special `mode:' adam plaice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmk+03=J8YUy51xzBxSK2+u0DuMLq3Ur63Wr_YWv6e=C=g__2927.31894166849$1571181555$gmane$org@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=37656@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=plaice.adam+lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).