unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>,
	71469-done@debbugs.gnu.org,
	Konstantin Kharlamov <Hi-Angel@yandex.ru>
Subject: bug#71469: font-lock does not apply standard faces and their descendants
Date: Tue, 17 Dec 2024 18:51:00 -0800	[thread overview]
Message-ID: <CADwFkm=yqGZTUGNwBAKNTs6Kxt_gbOEgRebNyAKO_kruzb90hg@mail.gmail.com> (raw)
In-Reply-To: <jwved4usnsn.fsf-monnier+emacs@gnu.org>

Version: 31.1

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> We have occasionally declared things obsolete with the understanding
>> that they'll be deleted much later than the normal "10 years, give or
>> take".  See the comment in `interactive-p', for example.
>>
>> The patch below gives me 64 warnings in our tree.  I'm not sure if it's
>> worth installing or not.
>
> FWIW, it's a +1 from me (assuming we then silence the resulting
> warnings, of course).

Thanks.

There have been no objections to the suggested patch, so I have now
installed a version of it on master as commit 3d3c1094604.  The
installed change silences all warnings, and updates the manual and NEWS.

The discussion in this thread focused on the wording of the warning, and
there were several good suggestions.  In the end, I settled on the
following, which I hope strikes a compromise between being brief, exact,
and telling the user in clear terms how to fix the warning:

    use the quoted symbol instead: 'font-lock-foo-face

Getting rid of these variables should help avoid the confusion that the
OP had regarding faces and variables.

With that, I'm closing this bug report.





      parent reply	other threads:[~2024-12-18  2:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 11:59 bug#71469: font-lock does not apply standard faces and their descendants Konstantin Kharlamov
2024-06-10 12:55 ` Eli Zaretskii
2024-06-10 13:41   ` bug#71469: [PATCH] " Konstantin Kharlamov
2024-06-10 15:17     ` Eli Zaretskii
2024-06-10 17:26       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-05  1:39         ` Stefan Kangas
2024-10-05 13:06           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-08 12:57             ` Robert Pluim
2024-10-08 13:25               ` Konstantin Kharlamov
2024-10-09  8:43                 ` Robert Pluim
2024-10-09  8:58                   ` Konstantin Kharlamov
2024-10-09 12:48                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-09 13:20                     ` Robert Pluim
2024-10-09 14:04                     ` Konstantin Kharlamov
2024-10-09 14:27                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-18  2:51             ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=yqGZTUGNwBAKNTs6Kxt_gbOEgRebNyAKO_kruzb90hg@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=71469-done@debbugs.gnu.org \
    --cc=Hi-Angel@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).