From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Date: Fri, 30 Oct 2020 16:04:58 +0000 Message-ID: References: <955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at> <83mu553e0x.fsf@gnu.org> <953c6df9-59b4-8b57-0be3-600d147fe9c7@ims.co.at> <83y2k2pabb.fsf@gnu.org> <83wnzmnioj.fsf@gnu.org> <83lfg1nfv1.fsf@gnu.org> <83d01dnegn.fsf@gnu.org> <2ae49edc-098f-9ace-595d-9e29bf3d2c8b@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: thomas.hisch@ims.co.at, 41852@debbugs.gnu.org To: martin rudalics , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 17:08:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYWwu-000A1P-2A for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 17:08:20 +0100 Original-Received: from localhost ([::1]:35768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYWwt-0008NP-3P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 12:08:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYWuh-000723-K1 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 12:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYWug-0005pv-0K for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 12:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYWuf-0006Kv-Rz for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 12:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 16:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41852-submit@debbugs.gnu.org id=B41852.160407391024289 (code B ref 41852); Fri, 30 Oct 2020 16:06:01 +0000 Original-Received: (at 41852) by debbugs.gnu.org; 30 Oct 2020 16:05:10 +0000 Original-Received: from localhost ([127.0.0.1]:59393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYWtp-0006Jh-N6 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 12:05:10 -0400 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:46469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYWtk-0006Ih-R9 for 41852@debbugs.gnu.org; Fri, 30 Oct 2020 12:05:05 -0400 Original-Received: by mail-ed1-f45.google.com with SMTP id t11so7134309edj.13 for <41852@debbugs.gnu.org>; Fri, 30 Oct 2020 09:05:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ZCuiRXYjCnrmpyQZlj+Pn/VRS5TiZgJNqiqlCfFvPN0=; b=a85kJpF5oNzydE3qsCGUs6GaJ6BSaPlxUSo3Q+Hp3ranVplN1XOQIJxuT7gFZW2SFN Dp1YaGMISNxsNlHP2v7ySjQKErxHpI/KqGCRwSCUf81xVx/I/x26Gu/v4yk968xfs8Pl EF5EPSU20xNgaOunGY3lbqpxxHCec4Mld7sFzxLygpfCIjz23gB7M4Ajmnc4DzqS5VuZ aNnh0SHGm9DxX/9rlwcWYkZdEhaFFZxcGaZzcm6Xd28UNxshfCYDp0UYwonwJTA3iTmb Alqoxi3evkddHG3P8QSyQZWIO2RdS0k4C1gKHymqfEGoXz4Fr8xsQ1UMXKf9SdDwRadc 5eXA== X-Gm-Message-State: AOAM533TaVXR12KtO8VcGoW5gTv/WwS7X4sERGWZzvRdpGGi3q649rou BA83KwIdKjAwIOzinMQ34jqDJ5+GCBLgEuHd6xtAlVvv X-Google-Smtp-Source: ABdhPJyKvjXrh0jjuHqoSqwoju5qpu7QWMDkUdZVWyIyVM6M4k5QxYeak5Oh8SLvwv8W4wh38IYDDt6+ElAQAL0Ht50= X-Received: by 2002:aa7:d28c:: with SMTP id w12mr3300429edq.282.1604073899247; Fri, 30 Oct 2020 09:04:59 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 30 Oct 2020 16:04:58 +0000 In-Reply-To: <2ae49edc-098f-9ace-595d-9e29bf3d2c8b@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192145 Archived-At: martin rudalics writes: > > +default) will also change the text height of the 'header-line' face. > > I'd prefer "font size" instead of "text height" here. Fixed. > Also, I'd like to see some clarification > > (1) that only the size of the header line face for a buffer where > 'text-scale-mode-header-line' has been set is affected (the line above > is IMHO too general to state this restriction), Could you be more specific? It already says it's buffer local, but it seems like you think it should say something more? Do you mean to be very explicit about it, like this? When the new buffer local variable 'text-scale-remap-header-line-face' is non-nil, 'text-scale-adjust' will also change the font size of the 'header-line' face in the current buffer. This will also affect any face that inherits from it. > (2) that text in the header line or elsewhere in such a buffer not > inheriting from (the remapped) header line face is unaffected, and I'm not sure I understand what you mean. If text-scale-mode is enabled, typically through running e.g. `text-scale-increase', the `default' face is scaled. The result, AFAICT, is that all faces in the buffer change size (well, not the mode line). And that makes sense since all other implicitly inherits from it, right? This works even for anonymous faces, e.g.: (progn (fundamental-mode) (insert (propertize "foo" 'face '(:height 1.5))) (text-scale-increase)) What am I missing? > (3) whether and how existing customizations of the header line face are > taken into account. > > Wrt (3) I assume that 'tabulated-list-mode' can already get derailed > when a user customizes header line face to use some large or small font > size (a scenario where face remapping is not involved at all). I tried customizing the `Height' for the `header-line' face, and it seems to work as expected: With no text-scale-mode it is as big as it is customized to be. When I run `text-scale-increase', it scales up accordingly (relative to its customized size). So I don't know what, if anything, should be added here. Since it works as expected, perhaps there is nothing to add? > Note that maybe 'text-scale-mode-header-line' should be also watched by > 'set-buffer-redisplay'. I tried adding `text-scale-remap-header-line-face' to the list of variables that are fed to `add-variable-watcher' at the end of frame.el. That doesn't work, unfortunately. I believe that since the remapping is done on a Lisp level, `text-scale-mode' isn't called even with a variable watcher. Is there a way to work around that? Or am I doing it wrong? Thanks for taking the time to review this.