From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Konstantin Kharlamov <Hi-Angel@yandex.ru>
Cc: 71772@debbugs.gnu.org
Subject: bug#71772: [PATCH] bug#71772: avoid producing invalid XML/HTML w/ multline comment style
Date: Thu, 25 Jul 2024 09:02:45 +0000 [thread overview]
Message-ID: <CADwFkm=xP1HZVKh3WVE_TyYoyxrkUyWa-=SNnaatiDkBOkHGOA@mail.gmail.com> (raw)
In-Reply-To: <86ed7i53iv.fsf@gnu.org>
close 71772 30.1
thanks
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
>> Date: Sun, 21 Jul 2024 00:34:22 +0300
>>
>> Gentle ping. This is a simple bugfix and a pre-release will be in a few
>> days, so would be nice to have it there.
>
> Stefan, would you please look into this?
The first patch looks good to me and seems safe. So I've installed it
on emacs-30 as commit 082300300fe.
The second patch seems to be mostly stylistic, and I think we do prefer
the explicit `setq-local's there? So I'm not installing that for now.
I don't really have a strong opinion though, so if anyone feels
differently then please install it on master.
prev parent reply other threads:[~2024-07-25 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 9:58 bug#71772: nxml-mode: avoid producing invalid XML/HTML w/ multline comment style Konstantin Kharlamov
[not found] ` <handler.71772.B.171930958114742.ack@debbugs.gnu.org>
2024-06-26 4:27 ` bug#71772: Acknowledgement (nxml-mode: avoid producing invalid XML/HTML w/ multline comment style) Konstantin Kharlamov
2024-06-28 7:34 ` bug#71772: [PATCH] bug#71772: avoid producing invalid XML/HTML w/ multline comment style Konstantin Kharlamov
2024-07-20 21:34 ` Konstantin Kharlamov
2024-07-25 7:34 ` Eli Zaretskii
2024-07-25 9:02 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=xP1HZVKh3WVE_TyYoyxrkUyWa-=SNnaatiDkBOkHGOA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=71772@debbugs.gnu.org \
--cc=Hi-Angel@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).