From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#30539: 26.0; `char-displayable-p' is much slower in Emacs 25 and 26 Date: Wed, 18 Nov 2020 07:35:06 -0800 Message-ID: References: <8c79c39f-7abb-4591-a676-17fb46af5a8f@default> <923b8123-937d-4ffb-9988-5359fdcbb6bc@default> <87woz44grg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14989"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 30539@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 18 16:36:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfPVE-0003n1-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Nov 2020 16:36:12 +0100 Original-Received: from localhost ([::1]:46284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfPVD-00089W-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Nov 2020 10:36:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfPV5-000883-TT for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2020 10:36:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfPV4-0004DH-CV for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2020 10:36:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kfPV4-0007Vg-9T for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2020 10:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2020 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30539 X-GNU-PR-Package: emacs Original-Received: via spool by 30539-submit@debbugs.gnu.org id=B30539.160571371428798 (code B ref 30539); Wed, 18 Nov 2020 15:36:02 +0000 Original-Received: (at 30539) by debbugs.gnu.org; 18 Nov 2020 15:35:14 +0000 Original-Received: from localhost ([127.0.0.1]:36157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfPUI-0007UQ-A1 for submit@debbugs.gnu.org; Wed, 18 Nov 2020 10:35:14 -0500 Original-Received: from mail-ej1-f47.google.com ([209.85.218.47]:42498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfPUG-0007UD-NS for 30539@debbugs.gnu.org; Wed, 18 Nov 2020 10:35:13 -0500 Original-Received: by mail-ej1-f47.google.com with SMTP id i19so3330248ejx.9 for <30539@debbugs.gnu.org>; Wed, 18 Nov 2020 07:35:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=79SNyrEtXjEn9EgXgEZRAAVd5bG/TmFf13WwniHDrHA=; b=A4y7kpIExVAsZ4BhhYYxg1GbpqhQpydv/PM1dyC9TbgPWmu6hlY5i58QoIu5d40WDn 28ZNs3QldgOMHu6MlL5tE+nn+bMMwtr0VdqAE/ZlLVUq47xPyKqG0jSdeT29SK3JeZgj FJiSrBuJm+rFAJLACCbr9unupVsJfvBVOT56EGrOUmbol7fyfrom4SnJrjvPfD8LrhZn r+5ylEqeTooF+TuoUYjrDbXDzQPWRRQpdDomHKh78hyjH3iZjTD0n1rW/r15jF08MVWI wjF22mo5o50fp4myDQqllyDhKHcyFE8+hqHR7MRVx7jwDRzpdH4SxgDqYx1KgqFVxeyX S8Iw== X-Gm-Message-State: AOAM531llqQS+57syEdfgFu62UKOWYhkX9592yqEb09Fg5qF67JqgSE7 WotsiY/TpqRqZ0Bc5IaduMD73qTt/WvK2cEJT245IzcR X-Google-Smtp-Source: ABdhPJzj7q+iYp/xYIdnEupqi1fNIXKkr6+xfBbsAf4uEJ8JFnhB46nN/s4lUWjua01auaRt8y5TqfhJYiY+siBz/c8= X-Received: by 2002:a17:906:1918:: with SMTP id a24mr1302055eje.432.1605713707109; Wed, 18 Nov 2020 07:35:07 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Nov 2020 07:35:06 -0800 In-Reply-To: <87woz44grg.fsf@gmail.com> (Noam Postavsky's message of "Thu, 22 Feb 2018 20:49:23 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193624 Archived-At: Noam Postavsky writes: > Drew Adams writes: > >> Can someone please confirm that they can repro this problem? > > I can reproduce on a Windows 10 box. It looks like something was being > cached before, where now it's not. E.g., try the following function > (char-names as defined in your throw-mule-bug-2.el). In Emacs 24, > there's only one slow call. > > (defun my-test-each-char () > (interactive) > (view-echo-area-messages) > (pcase-dolist (`(,name . ,ch) char-names) > (read-char (format "continue? (next: %s)" name)) > (let ((t0 (current-time)) > dt displayable) > (setq displayable (char-displayable-p ch)) > (setq dt (subtract-time (current-time) t0)) > (message "%s display:%s (%fs)" name displayable (float-time dt))))) > > Doing (setq inhibit-compacting-font-caches t) brings back reasonable > performance. > > I can't reproduce on my GNU/Linux box, although that may just be due to > different fonts installed. In particular, char-displayable-p never gave > me nil. Given this change: commit f34f49f35e5c000a6ee070678f43d2ca38b76cad Author: Eli Zaretskii Date: Sat Sep 7 12:26:08 2019 +0300 Set inhibit-compacting-font-caches to t by default on MS-Windows Is there anything left to do here, or should this bug be closed?