From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Tue, 24 Dec 2024 03:01:56 +0000 Message-ID: References: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@gutov.dev> <8634pewsej.fsf@gnu.org> <8634oy7s3s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, Eli Zaretskii , dev@rjt.dev To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 24 04:04:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPvDK-0002y4-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Dec 2024 04:04:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPvDH-0000bY-Rc; Mon, 23 Dec 2024 22:04:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPvDG-0000au-LI for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 22:04:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPvDG-0003GE-CK for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 22:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=sfEtA1yRk2TcQxfJtq3UZ4XzZM7jpt9kNChDk9P/arU=; b=MwzjRXI0r/vfAWl9+0Sc4+ChQMpk2XOCoWdMukBlHPK75cOUjRHvUbM4H5hTnlndPHHKmlb/GJESMZfcC18Lnxn4XF2T8bxdTy78HnNY++UuR4nYDYq/sd2/sX/AQht56cdlMKlTVhi49Y45ABrOg9/NtDi+0KO+MN0xwDj5st5Z3hmIXZLGhwtc/BnVpiP/48kOCtMJPFzY7V3kUOXmsI+0CpGMb5q6yuj/Z7nLpg4n8oBPSLMaPOb9HCygshjz2F2o2NtxdaPkRGOvXcRwvdot5SUzXuDw/QOWL1aUbQF6AiixU8oGQBgscQz16fx9cv20IDSGZyQaS97QZZKMGQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPvDG-0003R4-6b for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 22:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2024 03:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.173500938513105 (code B ref 71209); Tue, 24 Dec 2024 03:04:02 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 24 Dec 2024 03:03:05 +0000 Original-Received: from localhost ([127.0.0.1]:58813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPvCL-0003PI-1b for submit@debbugs.gnu.org; Mon, 23 Dec 2024 22:03:05 -0500 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:58429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPvCI-0003Ol-5w for 71209@debbugs.gnu.org; Mon, 23 Dec 2024 22:03:03 -0500 Original-Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d414b8af7bso8911263a12.0 for <71209@debbugs.gnu.org>; Mon, 23 Dec 2024 19:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735009316; x=1735614116; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=sfEtA1yRk2TcQxfJtq3UZ4XzZM7jpt9kNChDk9P/arU=; b=SIp5JVRRpyst2iso95qocDLNmE6P2eeCw8XlN4WcK25AcPDpdekV1dHZFvAob/FSej RC1r05fANuMJus7CpAkY7DaitltUxOCWU0KFyFF/XJHYy+gcF0ox8m/KvbkWpSGq5tJ2 lQMw45Amjbg07WWufDztsR9ILaKCriXNT3SH30ZUNdjEkDLKpZ2C2D71GZPq88Nbw1uT bZLPLomQCtpkjzCaBzOYJfVBBcRyXYBoqiL78DdoykTRgLr9+MMSa8u5SqHNl111y3qv MdhSG/JfFp/Yh2aQGeDVSCZJhVta1Uj9kJtalg3TUsL9KUnN2MWyI4oL96IkdoOgsLVW a4KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735009316; x=1735614116; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sfEtA1yRk2TcQxfJtq3UZ4XzZM7jpt9kNChDk9P/arU=; b=u5jDAr2kKYag28Wgq/HE3FXln+qyKEtglcZbgPaDS/jo2qbV70gHSoQJ3meMGOX6ge dz2APSgZQG54NbERcgCJ40rJswMdZbuTuKUhLMPawTpWAjNgNaG5SV09lUIXA1FY1tnU LzGzMWACZBwBnFgHpZN47KOIZRuMgMzlVn5r5L+a3xQVjiSygaTQWhdfJwzj3s2ZZB51 q7+a6GE/L3zAOiBoZKwfEfpaTqrPJpePNDOl8n29GxHisCzlNBbQo7X0MtKg3RVoNaft vSfF192de+KqVoxcFvOdmGo3gum4ACNrAiNhJoFOB/i1QOYoQbGg93tjmN17CK1HkmqO ROzA== X-Forwarded-Encrypted: i=1; AJvYcCWJP9U1rOElvNbUve5hcAPBWKR6UPL+RPmXnfB8Dz5P776Aui8d0C7P/OdQ5tlbqVYrNEbJIA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw3dUr8vEEGph2aQ90jsY+SZi6Pcc9WZtHvxxJEJNIf0t+zitcK ngDYLK4c6VShQnf/pxwCOliTcn/GxHNabmeX1SY4RU8nRbVBWf9Un9iBm2RHbaST/sIyj36lSC0 4UGF2NEgnq2obTizp7NusgIw53pQ= X-Gm-Gg: ASbGncvKukWa92AdJQc8Hg0iXgykhtpRXVSlg2e7NRGotEhL8MrU9C7l1QA1ExVmALY gihdGwxVUQ0lw4zBo4sgXK40ifQpuMfQAivrRW8g= X-Google-Smtp-Source: AGHT+IG+K5pFN8qlkJrrtXALcueu9+6wtmLu3PP3zKEoZ0zaTHLG4Qbl7i9g51WIN+5sFVLypPAsFAgnj9HLXvhBC90= X-Received: by 2002:a05:6402:4402:b0:5d2:60d9:a2a0 with SMTP id 4fb4d7f45d1cf-5d81de5d896mr14124017a12.33.1735009316435; Mon, 23 Dec 2024 19:01:56 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 24 Dec 2024 03:01:56 +0000 In-Reply-To: (Noah Peart's message of "Thu, 27 Jun 2024 05:29:21 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297674 Archived-At: Noah Peart writes: > Ah yes, sorry to be slow, I can submit a patch for those settings. I'll = take a look today! Any updates here? Thanks! > > On Thu, Jun 27, 2024 at 3:38=E2=80=AFAM Eli Zaretskii wrot= e: > > Ping! Ping! Noah, are you still interested in working on this? > > > Cc: 71209@debbugs.gnu.org, dev@rjt.dev > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > From: Eli Zaretskii > > > > Ping! Noah, would you please answer Dmitry? > > > > > Cc: 71209@debbugs.gnu.org > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > From: Dmitry Gutov > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > ;; for (auto x: ...) > > > > (for_range_loop > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > ;; auto& x > > > > (reference_declarator > > > > (identifier) @font-lock-variable-name-face) > > > > ;; auto[&] [x, y] > > > > (structured_binding_declarator > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > I suppose most people keep the default font-locking for variable-n= ame > > > > and variable-use, so these missing rules go unnoticed. > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > >