From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format Date: Sun, 18 Oct 2020 15:01:31 -0700 Message-ID: References: <87imb7e242.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17337"; mail-complaints-to="usenet@ciao.gmane.io" To: Stephen Berman , 44068@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 19 00:02:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUGkm-0004OW-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 00:02:12 +0200 Original-Received: from localhost ([::1]:47712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUGkl-0001sc-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Oct 2020 18:02:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUGkd-0001sO-HC for bug-gnu-emacs@gnu.org; Sun, 18 Oct 2020 18:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUGkd-0002vy-85 for bug-gnu-emacs@gnu.org; Sun, 18 Oct 2020 18:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUGkd-0006J6-6G for bug-gnu-emacs@gnu.org; Sun, 18 Oct 2020 18:02:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Oct 2020 22:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44068 X-GNU-PR-Package: emacs Original-Received: via spool by 44068-submit@debbugs.gnu.org id=B44068.160305850024186 (code B ref 44068); Sun, 18 Oct 2020 22:02:03 +0000 Original-Received: (at 44068) by debbugs.gnu.org; 18 Oct 2020 22:01:40 +0000 Original-Received: from localhost ([127.0.0.1]:39238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUGkF-0006I2-SL for submit@debbugs.gnu.org; Sun, 18 Oct 2020 18:01:40 -0400 Original-Received: from mail-ej1-f51.google.com ([209.85.218.51]:34305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUGkE-0006Hc-9D for 44068@debbugs.gnu.org; Sun, 18 Oct 2020 18:01:38 -0400 Original-Received: by mail-ej1-f51.google.com with SMTP id u8so11230181ejg.1 for <44068@debbugs.gnu.org>; Sun, 18 Oct 2020 15:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=kjRsHnLrpDeIswi+CeQXjbdTZqWDE5RGVzE1un+zk0I=; b=ObRRWIM9Hni1bd6izrW2ELY/gGcT30wE914uihfRpswGfa8p+4sjXn+dPp2321NG1F QqV38XhAGz8Er+QBeqciYig0CKDP1k54zMTzF++MBD6czGTGyE1iAvVtdQp4fyIMyikP xI9uePBlrbXCl1xu51jR5doQWlEFZJyt0y4c5HjZhSNOTWEgClIAqzSkASn9ovPfCrxr JCIMNZGMvU+UCz0fSfEGWMUIYYDFso0MARTjb/2u02gsfykCUAT5MtGY7OaOPs+sqnEU ELeHZ4glk7+Z+QvkIsxqwlrYUgx9vJ0q6tB7S/QitqH5i56eXH0SZU4+PYa9B9I0Ghw2 A7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=kjRsHnLrpDeIswi+CeQXjbdTZqWDE5RGVzE1un+zk0I=; b=ZhVERrWK/cnBJnYBbqWIF1HD0qiyYaWdUHclE8dB51AQD2FXcH+5OJV8IHnswkvPOa dH2VnCPiXUH0v/qSd+ZEYeq8YNAR6bcDv//OwYQBtYgNf5Fa3xRHF1Za9dzWUFkb/v5v RIgX3tqY+zB3YZeZsfl2yCZJZe2QIdnLDu8A7R1LCV7LaPrFHGIJzip0H7Ydzbj4fbb4 ha+TWDi1ubaadzRfKAdkg4AgzskiQtscDMn4vwhXaXn+K0uEKlqwJ4Zzyj0guEq1aFg/ rbjHWq4duiSw0+RI883izS2WqdFHq6N/SsQyPgTVa+zNQCeAnPSkzih1iCohItJCRo81 NBUA== X-Gm-Message-State: AOAM531v0UpCRbhUsDKIl0QHc5+IkQl0MSwvEbr7/drL84b0W/Vu0Eym RLoyw5+J9EnXqBK+vb73UjMKTvB8cL2J4VPg+eM= X-Google-Smtp-Source: ABdhPJzVarbKo8kONs7CX7xvcPMjtZ6r4bVeO5a5x38CKZ/VKq0XjI0rLRTqR+lB/gjgl0cOMCL6JM+2NXSPCEoxqaw= X-Received: by 2002:a17:906:f90a:: with SMTP id lc10mr14647997ejb.272.1603058492316; Sun, 18 Oct 2020 15:01:32 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 18 Oct 2020 15:01:31 -0700 In-Reply-To: <87imb7e242.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190919 Archived-At: Stephen Berman writes: > On trying out the new tabulated-list implementation of the bookmarks > list I noticed that, when clicking on the File header, the sort > indicator is not displayed, unlike with the Bookmark header. Then I > noticed that the same thing happens in the tabulated buffer list (C-x > C-b). Then I grepped for all uses of tabulated-list-format in the Emacs > sources and found the same problem in most of them. The reason is that > in these modes the width of at least one of the columns is too narrow, > so that tabulated-list-init-header omits the indicator. In most cases > the problematic column is the final one, but in a couple of cases there > are also non-final too narrow columns. And I think these bugs are due > to a misleading description in tabulated-list-format's doc string. Your analysis sounds correct to me. > The attached patch corrects the doc string and the problematic uses of > tabulated-list-format. The patch also fixes a typo and tries to > improve column alignment in timer-list-mode: this is one of the few > modes derived from tabulated-list-mode whose column widths didn't need > to be corrected, but the alignment seemed suboptimal; however, when > the header line uses a variable-pitch face, the alignment is still > suboptimal even with the patch, and I don't know how to fix that. Thanks for the patch. I've tested it and it indeed fixes several bugs in this area. But it got me thinking: for the final column at least, maybe we should just make tabulated-list-mode work as advertised, and itself figure out that it should use this length? That way, we would solve any bugs also for external packages that have been misled by the doc string. Or would that have any downsides?