From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44529: [PATCH] Convert apropos-internal from C to Lisp Date: Tue, 24 Nov 2020 17:57:27 -0800 Message-ID: References: <83tuty4iyv.fsf@gnu.org> <83tutx3n83.fsf@gnu.org> <834klx2obm.fsf@gnu.org> <83k0ut0yby.fsf@gnu.org> <83o8jxrxxt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36198"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44529@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 25 02:58:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khk4b-0009I2-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 02:58:21 +0100 Original-Received: from localhost ([::1]:48872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khk4a-0007wW-DM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 20:58:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khk4I-0007vp-0g for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 20:58:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khk4H-0007SR-Pw for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 20:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khk4H-0001da-P8 for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 20:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2020 01:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44529 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44529-submit@debbugs.gnu.org id=B44529.16062694556260 (code B ref 44529); Wed, 25 Nov 2020 01:58:01 +0000 Original-Received: (at 44529) by debbugs.gnu.org; 25 Nov 2020 01:57:35 +0000 Original-Received: from localhost ([127.0.0.1]:33676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khk3r-0001cu-Db for submit@debbugs.gnu.org; Tue, 24 Nov 2020 20:57:35 -0500 Original-Received: from mail-ej1-f46.google.com ([209.85.218.46]:43798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khk3p-0001cg-Mg for 44529@debbugs.gnu.org; Tue, 24 Nov 2020 20:57:34 -0500 Original-Received: by mail-ej1-f46.google.com with SMTP id k27so732202ejs.10 for <44529@debbugs.gnu.org>; Tue, 24 Nov 2020 17:57:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=h5i1OTq0H4WXYFQ/Y7z4OylxOLNPIo/K2dqoECMqRX8=; b=XkrNbyNb01pTwsiDZeoPLgeag2R1nRe82m5Sjd2bWd4cVvqj9gVHBiXTLciQWcSkOk Lo7y1jMXCln3scmriBJKcCy8j2dp4MLI07Ob7B1wKKndj6I7OTYuX0J33NnOQb6QnLv4 hBqgBpbXw+fTXHkgp7UgDpUiMn/1HVTPK7dRIj10XYQ1f42CwKY+IfpG3MRx+FSNZKka KJztdjcvgh57cR7mfnaQtM0fmLRH+l1G7M+H1XIO74bzjJFssNW1n4ZNzaRUW6+D/Byy RxFmAO0Ka5SxX3E6OcPx7Fwa8XyHqY3qi9KLBppuVy6mcJgEJTAycSQzTLTxpuPy1OJF ygDA== X-Gm-Message-State: AOAM533feApd9ARkgJeBMgW+ZLBxCfuVaE/v1aPtKjToD+TEGGuU2Q5V xYE94BNKBFV40k9dr3fZZUzWgKbIkgIXqB3qjBA= X-Google-Smtp-Source: ABdhPJzc1q87uyYhmRnPxxO4FKxGe1rtjki4XTccWRaqwiD7LWuvGxZ4oraGO4AAfY7T4yaHw2cTof/gkJWiB0nNvt4= X-Received: by 2002:a17:906:4e90:: with SMTP id v16mr1163203eju.477.1606269447972; Tue, 24 Nov 2020 17:57:27 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 24 Nov 2020 17:57:27 -0800 In-Reply-To: <83o8jxrxxt.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Nov 2020 19:52:46 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194143 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Sun, 15 Nov 2020 17:07:14 -0800 >> Cc: 44529@debbugs.gnu.org >> >> The attached patch moves it to subr.el instead, as requested. > > Thanks. > >> This runs insignificantly faster in C, and is already fast enough on >> reasonably modern hardware. We might as well lift it to Lisp. >> This benchmark can be used to verify: >> >> (benchmark-run 10 (apropos-command "test")) >> => (0.12032415399999999 2 0.014772391999999995) ; C >> => (0.13513192100000002 2 0.017216643000000004) ; Lisp > > Btw, did you try with less trivial strings? E.g., what happens if you > replace "test" with "set" or "file"? (Sorry for the late reply.) I see results consistent with the previously reported 10 % difference, or even slightly better than that: (benchmark-run 10 (apropos-command "file")) => (0.6285004230000001 26 0.176056903) ; C => (0.667433809 26 0.19296271500000006) ; Lisp (/ 0.667433809 0.6285004230000001) => 1.0619 (benchmark-run 10 (apropos-command "set")) => (0.463329467 19 0.12921543499999996) ; C => (0.486383881 19 0.13347332099999998) ; Lisp (/ 0.486383881 0.463329467) => 1.0497