unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50880@debbugs.gnu.org
Subject: bug#50880: Add "Contributing to Emacs" help command (see C-h C-h)
Date: Wed, 29 Sep 2021 18:10:38 -0700	[thread overview]
Message-ID: <CADwFkm=rATCabq7c7QvpN_Tq1EjTF-iJqdZefMt0FQeE-ct0gg@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmkOr9HhdZZ_r3ExvuzviFOHi6e4pR3T_+eSQg5o3jABJA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

tags 50880 + patch
thanks

Stefan Kangas <stefan@marxist.se> writes:

> We could pick any key, like "b" for "contriButing".  Or, you know, "h"
> for "Happens to be free".  ;-)

So how about the attached?  I put it on `C-h C-x' because I figured that
we might want to use "b" for "bugs" in the future perhaps, and "u" just
wasn't that nice.  Most of the other ones are taken except for "i", "q",
"r", "y" and "z".

[-- Attachment #2: 0001-New-help-function-view-emacs-contributing.patch --]
[-- Type: text/x-diff, Size: 2575 bytes --]

From f05c916f2c37cbdf419d214f6d6b8bd11c9ffbcd Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Thu, 30 Sep 2021 02:52:58 +0200
Subject: [PATCH] New help function view-emacs-contributing

* lisp/help.el (view-emacs-contributing): New function.
(help-for-help): Display new function.
(help-map): Bind it to "C-h C-x".  (Bug#50880)
* lisp/startup.el (fancy-about-text, normal-about-screen): Use
above new function.
---
 lisp/help.el    | 7 +++++++
 lisp/startup.el | 4 ++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lisp/help.el b/lisp/help.el
index 02e9b9e8e4..3d15ce2530 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -70,6 +70,7 @@ help-map
     (define-key map "\C-s" 'search-forward-help-for-help)
     (define-key map "\C-t" 'view-emacs-todo)
     (define-key map "\C-w" 'describe-no-warranty)
+    (define-key map "\C-x" 'view-emacs-contributing)
 
     ;; This does not fit the pattern, but it is natural given the C-\ command.
     (define-key map "\C-\\" 'describe-input-method)
@@ -292,6 +293,7 @@ 'help
        ("describe-distribution"
         "Emacs ordering and distribution information")
        ("C-m" "Order printed manuals")
+       ("view-emacs-contributing" "Contributing to Emacs")
        ("view-emacs-todo" "Emacs TODO")
        ("describe-no-warranty"
         "Information on absence of warranty"))
@@ -504,6 +506,11 @@ view-emacs-problems
   (interactive)
   (view-help-file "PROBLEMS"))
 
+(defun view-emacs-contributing ()
+  "Display info on how to contribute to Emacs."
+  (interactive)
+  (info "(emacs) Contributing"))
+
 (defun view-emacs-debugging ()
   "Display info on how to debug Emacs problems."
   (interactive)
diff --git a/lisp/startup.el b/lisp/startup.el
index 505d7b83f4..af22908b35 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -1649,7 +1649,7 @@ fancy-about-text
 	      (goto-char (point-min))))
      "\tMany people have contributed code included in GNU Emacs\n"
      :link ("Contributing"
-	    ,(lambda (_button) (info "(emacs)Contributing")))
+            ,(lambda (_button) (view-emacs-contributing)))
      "\tHow to report bugs and contribute improvements to Emacs\n"
      "\n"
      :link ("GNU and Freedom" ,(lambda (_button) (describe-gnu-project)))
@@ -2237,7 +2237,7 @@ normal-about-screen
 
   (insert-button "Contributing"
 		 'action
-		 (lambda (_button) (info "(emacs)Contributing"))
+                 (lambda (_button) (view-emacs-contributing))
 		 'follow-link t)
   (insert "\tHow to report bugs and contribute improvements to Emacs\n\n")
 
-- 
2.30.2


  reply	other threads:[~2021-09-30  1:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 22:55 bug#50880: Add "Contributing to Emacs" help command (see C-h C-h) Stefan Kangas
2021-09-29  7:06 ` Lars Ingebrigtsen
2021-09-29  9:11   ` Stefan Kangas
2021-09-29  9:18     ` Gregory Heytings
2021-09-29  9:41       ` Stefan Kangas
2021-09-29 16:55         ` Juri Linkov
2021-09-29 17:41           ` Stefan Kangas
2021-09-29 17:45             ` Lars Ingebrigtsen
2021-09-29 17:55           ` Eli Zaretskii
2021-09-29 18:36           ` Gregory Heytings
2021-09-29 16:00     ` Lars Ingebrigtsen
2021-09-29 16:52       ` Stefan Kangas
2021-09-30  1:10         ` Stefan Kangas [this message]
2021-09-30  6:10           ` Lars Ingebrigtsen
2021-09-30  7:49           ` Gregory Heytings
2021-09-30 11:51             ` Gregory Heytings
2021-09-30 20:01             ` Stefan Kangas
2021-10-01  7:24               ` Lars Ingebrigtsen
2021-10-01 10:17                 ` Eli Zaretskii
2021-10-01 10:20                   ` Lars Ingebrigtsen
2021-10-01 10:28                     ` Eli Zaretskii
2021-10-01 10:32                       ` Lars Ingebrigtsen
2021-10-01 11:00                         ` Eli Zaretskii
2021-10-01 17:08                           ` bug#50880: [External] : " Drew Adams
2021-10-01 18:45                           ` Stefan Kangas
2021-10-01 18:58                             ` Eli Zaretskii
2021-10-02 23:17                   ` Richard Stallman
2021-10-02 23:51                     ` Stefan Kangas
2021-10-03  5:57                     ` Eli Zaretskii
2021-10-03 11:55                       ` Stefan Kangas
2021-10-03 19:10                         ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=rATCabq7c7QvpN_Tq1EjTF-iJqdZefMt0FQeE-ct0gg@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=50880@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).