From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36603: [PATCH] Simplify calling convention of describe_map Date: Tue, 20 Aug 2019 18:02:56 +0200 Message-ID: References: <85pnkzkg2j.fsf@gmail.com> <85mug3kesc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="30825"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36603@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 20 18:12:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i06kS-0007tk-Ko for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 18:12:40 +0200 Original-Received: from localhost ([::1]:39390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i06kR-0000YH-Bi for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 12:12:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41461) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i06c8-0005u6-F3 for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 12:04:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i06c7-0000Yu-Df for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 12:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i06c7-0000Ym-AD for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 12:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i06c7-00019H-55 for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 12:04:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 16:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36603-submit@debbugs.gnu.org id=B36603.15663169964334 (code B ref 36603); Tue, 20 Aug 2019 16:04:03 +0000 Original-Received: (at 36603) by debbugs.gnu.org; 20 Aug 2019 16:03:16 +0000 Original-Received: from localhost ([127.0.0.1]:33695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i06bL-00017q-VX for submit@debbugs.gnu.org; Tue, 20 Aug 2019 12:03:16 -0400 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:39667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i06bK-00017d-59 for 36603@debbugs.gnu.org; Tue, 20 Aug 2019 12:03:14 -0400 Original-Received: by mail-pf1-f176.google.com with SMTP id f17so3645953pfn.6 for <36603@debbugs.gnu.org>; Tue, 20 Aug 2019 09:03:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EKfIR+3awi03wM2U8MjDkf6cZSEcDHBBt7UyeMrBYqI=; b=MuqxiRprxx6qQi2BVUMTNiMnUu60ccDEmhw1H8+9kstQqkxGriK8hLuWxFCm0uGbRE LNFnE2QLSH/GPEK1Q7loQLDQsCeXIrwVj7t3XzFvuY4sjRh/nYwV8cxx6tVf5QvKcnhs DvC0Y8zcEntUj+Q2MX65uhaQFB+uB9NlyBX31rHS9RLACkZd7n9RflA/SbSV6sLIpj1q g/Uf7zHy60N65S0yA3CjkoLU2HmouvOeAnjyUzJzmDGraEbj7qRWRxgskCMOVzlAQ6NH KBIiHd+dnJxUy7Wv78vaDDgShb2KIf8RSEAyGEmz/rURezIRKODPhOUL0nG8aw4M+NsU /mXQ== X-Gm-Message-State: APjAAAUXFvbHTQS+AK0aUJ+FXq6RcqwfgD+tAbkvg4UWyMJmnwhsD3J4 KMF1NTxvmop+kILxZb8/crhnfy/n/zq5SX2gVq0= X-Google-Smtp-Source: APXvYqw7iHSQJ23ryYPaxWtXUnc6ef9RrfVvBsBNo8WDZjH5v9nGJ2ukrY5/JX8YugTtBPyA9jIP6lJFQqmFO5X+9SM= X-Received: by 2002:aa7:9552:: with SMTP id w18mr30238356pfq.107.1566316988323; Tue, 20 Aug 2019 09:03:08 -0700 (PDT) In-Reply-To: <85mug3kesc.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165423 Archived-At: Noam Postavsky writes: > > Noam Postavsky writes: > > > Stefan Kangas writes: > > > >> + Lisp_Object seen_orig = Qnil; > >> + Lisp_Object *seen = &seen_orig; > > > > Do we really need the seen_orig variable? It looks like there is no > > reason for having seen as a pointer at all, but maybe I'm missing > > something. > > Actually, maybe the patch is wrong (i.e., over-simplifying), because it > has describe_map start with a fresh seen pointer each time; but the > current code passes the same pointer to each describe_map call in a > loop. Thanks for that feedback. I'll take another look and get back to you. Best regards, Stefan Kangas