From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#28182: maybe implement CTRL++ to zoom text Date: Sun, 6 Oct 2019 01:56:28 +0200 Message-ID: References: <87y3qcs3nf.fsf@jidanni.org> <87tva69q12.fsf@mail.linkov.net> <87v9uixqew.fsf@mail.linkov.net> <83lfu8h6pn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="199153"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Tak Kunihiro , Juri Linkov , Richard Stallman , 28182@debbugs.gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 06 01:57:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGtvL-000pf3-TV for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Oct 2019 01:57:20 +0200 Original-Received: from localhost ([::1]:59414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGtvK-0005Gy-R9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Oct 2019 19:57:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57127) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGtv5-0005Gr-De for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 19:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGtv4-0008Ry-C8 for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 19:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36523) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGtv4-0008Ru-9Q for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 19:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iGtv4-0006vt-4J for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 19:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Oct 2019 23:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28182-submit@debbugs.gnu.org id=B28182.157031980826626 (code B ref 28182); Sat, 05 Oct 2019 23:57:01 +0000 Original-Received: (at 28182) by debbugs.gnu.org; 5 Oct 2019 23:56:48 +0000 Original-Received: from localhost ([127.0.0.1]:45344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGtup-0006vN-Ms for submit@debbugs.gnu.org; Sat, 05 Oct 2019 19:56:47 -0400 Original-Received: from mail-pf1-f182.google.com ([209.85.210.182]:35744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGtuo-0006vA-Dm for 28182@debbugs.gnu.org; Sat, 05 Oct 2019 19:56:46 -0400 Original-Received: by mail-pf1-f182.google.com with SMTP id 205so6175368pfw.2 for <28182@debbugs.gnu.org>; Sat, 05 Oct 2019 16:56:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DI8uCVmWmWO0LWu5FEi3QzcH80dbIhqqRvWG++GOWkY=; b=lFmgS/F/UV5m1JmZao6zC17SpOg0o1jvJYrNb8MAAecTT99V/szU5a1RYc1kb0+m9m z5thp4p3lSUntDT8HYFkMqBD0AX7wF7lZ8LWc58IM2YOzsxOtx4pLY/a8MtbIadf4ADS o1xx95X10MHf8yqtC89+jwKaxwjHUVamvlkfX98T/hpyxXTPpJ6OQ7PZ80AU3gJDbF+s tCbB/zyRSgcZpbQLwwDTBhYuK98+zYucajESbxiHM1ibQ82e/kpLN4muMhUnkQkClF9f ienF9SP0H5Tk96yHFFVYxJ3vfD9RjocdcUR/2zprdhmzWBP04+bFQU8kiWj8PBRttJKY m5Gg== X-Gm-Message-State: APjAAAWe8tMG4IoObZts0kFACrEAUxo1xMYmbNXhXhoolJ/oiFReJ8MA gE4Qq3OAkl3UbwZdqU67Rb1GIqp6cnvq4rhBW0A= X-Google-Smtp-Source: APXvYqxlJPzksQLKWbbYezawjMUzoO2zpS+BX41PCRaynskL9XcPF6qI5uP75TMedYBTbvgV90vjXmUE33PVAWIUGyE= X-Received: by 2002:a62:e917:: with SMTP id j23mr25164620pfh.50.1570319800494; Sat, 05 Oct 2019 16:56:40 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168403 Archived-At: Stefan Kangas writes: > > Eli Zaretskii writes: > > > > I've attached a tentative patch along those lines. WDYT? > > > > Any reason to make the new behavior be the default, i.e. break > > backward compatibility? Why not make this an opt-in feature instead? > > I think it's a better default, since it's more in line with user > expectations. The "Ctrl+mouse whell changes font size" behaviour is > pretty ubiquitous in browsers, text editors and IDEs. From the top of > my head, you can change the font size (sometimes called "zoom") using > this shortcut in Firefox, Chrome, Safari, Eclipse, LibreOffice, Adobe > Reader, evince, and many, many others. From searching the web, this > seems to be the default also in Atom, Sublime Text, TextMate, > Notepad++ and IntelliJ. VSCode stands out by making this optional. > > We could of course make it an opt-in feature should we want to do that. > > > > I'm not sure exactly how to reformulate the doc string for > > > mouse-wheel-scroll-amount to fit the new behaviour. I'll have to > > > think about it a bit more. Do let me know if you have any ideas. > > > > I'm not sure we need to change the doc string, but we definitely need > > to change the :version tag. > > Fixed that in the attached patch. I don't feel comfortable pushing this without an explicit go-ahead. What do you think? Thanks in advance. Best regards, Stefan Kangas