unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 57961@debbugs.gnu.org
Subject: bug#57961: 29.0.50; [PATCH] image-dired thumbnail generation fails for PDFs on macOS
Date: Wed, 28 Sep 2022 06:45:49 -0400	[thread overview]
Message-ID: <CADwFkm=mrv3Y9BM+gy3f_6AoUnpAMPGygw0nDz2ZzD5exbtZvg@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmnsO-hYYyK7W17GMspspHzpC=kB+SJr00w3VEhSB7S0Sw@mail.gmail.com> (Stefan Kangas's message of "Wed, 21 Sep 2022 06:09:31 -0700")

close 57961 29.1
thanks

Stefan Kangas <stefankangas@gmail.com> writes:

> Given that we already hard-code the use of JPEG, perhaps we should just
> hard-code ".jpg" here too?

I took a closer look at this, and I decided that while forcing the file
extension to ".jpg", we might as well take the opportunity to simplify
the naming of thumbnails.

So I did that in commit 6cffaa3b6d, and I'm therefore closing this bug report.





      parent reply	other threads:[~2022-09-28 10:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m14jx1n4xs.fsf.ref@yahoo.es>
2022-09-20 20:53 ` bug#57961: 29.0.50; [PATCH] image-dired thumbnail generation fails for PDFs on macOS Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-21 11:42   ` Lars Ingebrigtsen
2022-09-21 13:09   ` Stefan Kangas
2022-09-21 13:58     ` Stefan Kangas
2022-09-28 10:45     ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=mrv3Y9BM+gy3f_6AoUnpAMPGygw0nDz2ZzD5exbtZvg@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=57961@debbugs.gnu.org \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).