bug#46472: Make lisp/mail/uce.el obsolete

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 112 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> I'd like to see the patch for master, please.

Please see the attached.

[-- Attachment #2: master-0001-Recommend-against-using-uce.el.patch --]
[-- Type: text/x-diff, Size: 1740 bytes --]

From e2c046477798b15f30748752716b03986b356080 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Tue, 12 Oct 2021 06:30:20 +0200
Subject: [PATCH] Recommend against using uce.el

* lisp/mail/uce.el: Recommend against its use.  (Bug#46472)
Do not merge to master.
---
 lisp/mail/uce.el | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/lisp/mail/uce.el b/lisp/mail/uce.el
index b07004de38..0a0c827acd 100644
--- a/lisp/mail/uce.el
+++ b/lisp/mail/uce.el
@@ -358,7 +358,30 @@ uce-reply-to-uce
       ;; Run hooks before we leave buffer for editing.  Reasonable usage
       ;; might be to set up special key bindings, replace standard
       ;; functions in mail-mode, etc.
-      (run-hooks 'mail-setup-hook 'uce-setup-hook))))
+      (run-hooks 'mail-setup-hook 'uce-setup-hook)))
+  (pop-to-buffer (get-buffer-create "uce-reply-to-uce warning"))
+  (insert "\
+-- !!! NOTE !!! ---------------------------------------------
+
+Replying to spam is at best pointless, but most likely actively
+harmful.
+
+- You will confirm that your email address is valid, thus ensuring
+  you get more spam.
+
+- You will leak information and open yourself up for further
+  attack.  For example, they could use your \"geolocation\" to find
+  your home address and phone number.
+
+- The sender address is likely fake.
+
+- You help them refine their methods of spamming.
+
+Therefore, we strongly recommend that you do not use this package.
+Use a spam filter instead, or just delete the spam.
+
+-------------------------------------------------------------
+"))
 
 (defun uce-insert-ranting (&optional _ignored)
   "Insert text of the usual reply to UCE into current buffer."
-- 
2.30.2