unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: "Bruno Félix Rezende Ribeiro" <oitofelix@gnu.org>
Cc: 37548@debbugs.gnu.org
Subject: bug#37548: Implement sanitation of single-file package long description
Date: Mon, 30 Sep 2019 19:39:26 +0200	[thread overview]
Message-ID: <CADwFkm=hLMKv19N8u=pJXVB00Mki7HqcHWreTQZy756KPJ=8hQ@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=mHf1BY=d628dJv1vwhTwQWpBq=34VB4LpaSVZrEPgLg@mail.gmail.com>

Stefan Kangas <stefan@marxist.se> writes:

> Maybe it would make more sense to create a new function in package.el
> that takes care of this?  That way we don't have the same
> functionality in two places.

I noticed something else:  There is actually already code duplication
in package.el -- there is code to strip the commentary section in both
package--get-description and describe-package-1.

Perhaps it would make sense to look this all over and see how we can do better?

I also have two general questions, which are applicable to both your
recent patches:

1. It looks likely that this together with your other patch and your
previous contributions will together amount to more than 15 lines of
code.  That means that you would have to sign Copyright Assignment
papers for GNU Emacs.  I see you're emailing from gnu.org, so I assume
there are no surprises for you here; I guess Eli can help you sort
that out if it's not already.

2. Could you please provide a commit message formatted as a changelog
entry?  Details on this are in the CONTRIBUTE file in the repository.

Best regards,
Stefan Kangas





  reply	other threads:[~2019-09-30 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29  5:42 bug#37548: Implement sanitation of single-file package long description Bruno Félix Rezende Ribeiro
2019-09-30 17:27 ` Stefan Kangas
2019-09-30 17:39   ` Stefan Kangas [this message]
2019-10-08  8:36     ` Bruno Félix Rezende Ribeiro
2019-10-08  8:40       ` Eli Zaretskii
2019-11-11 19:02       ` Stefan Kangas
2019-11-14 11:28         ` Eli Zaretskii
2020-01-23 20:56         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=hLMKv19N8u=pJXVB00Mki7HqcHWreTQZy756KPJ=8hQ@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=37548@debbugs.gnu.org \
    --cc=oitofelix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).