From: Stefan Kangas <stefankangas@gmail.com>
To: James Thomas <jimjoe@gmx.net>
Cc: 65914@debbugs.gnu.org
Subject: bug#65914: Exclude current buffer from eww-switch-to-buffer
Date: Fri, 15 Sep 2023 05:05:23 -0700 [thread overview]
Message-ID: <CADwFkm=h4fMzjHQoKcVkHt0VaH=vgeOR6MedjfgN4wkEZv_k-w@mail.gmail.com> (raw)
In-Reply-To: <87y1ha1he8.fsf@gmx.net> (James Thomas's message of "Wed, 13 Sep 2023 16:15:03 +0530")
James Thomas <jimjoe@gmx.net> writes:
> Tags: patch, notabug
[BTW, we typically don't use the "notabug" for patches.]
> This patch excludes the current buffer from the completion list of the
> above command. The main motivation is avoiding one cycling keystroke in
> icomplete.
>
> For eg. a use-case of cycling visits between the last 3 visited eww
> buffers:
> Currently (to visit each buffer in succession), after pressing s, one
> would have to cycle thrice in icomplete before pressing C-j. With this
> patch, it would only need to be done twice (a mnemonic to remember the
> number of times to cycle could be 'the last 2 *other* buffers' rather
> than 'the last 3 buffers' it is currently).
>
> Moreover, if you remember that the target eww buffer was the last n-th
> buffer you opened, you may now simply cycle n times. Eg. n is 1 for the
> previous buffer.
Thanks, I would like to install this patch.
Could you please send the patch as an attachment instead? We prefer
that patches are created with a command like `git format-patch -1'.
Please also include:
- The bug number of this bug in the commit message, like so: Bug#65914
- A ChangeLog entry, as described in the CONTRIBUTE file.
That would make it easier for us to review and install this patch.
Thanks in advance.
> * lisp/net/eww.el (eww-switch-to-buffer):
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 4ddda216afc..e43ef2bfe8b 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -2062,7 +2062,8 @@ eww-switch-to-buffer
> (let ((completion-extra-properties
> '(:annotation-function (lambda (buf)
> (with-current-buffer buf
> - (format " %s" (eww-current-url)))))))
> + (format " %s" (eww-current-url))))))
> + (curbuf (current-buffer)))
> (pop-to-buffer-same-window
> (read-buffer "Switch to EWW buffer: "
> (cl-loop for buf in (nreverse (buffer-list))
> @@ -2070,9 +2071,10 @@ eww-switch-to-buffer
> return buf)
> t
> (lambda (bufn)
> - (with-current-buffer
> - (if (consp bufn) (cdr bufn) (get-buffer bufn))
> - (derived-mode-p 'eww-mode)))))))
> + (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bufn)))
> + (and (with-current-buffer bufn
> + (derived-mode-p 'eww-mode))
> + (not (eq bufn curbuf))))))))
>
> (defun eww-toggle-fonts ()
> "Toggle whether to use monospaced or font-enabled layouts."
>
> --
next prev parent reply other threads:[~2023-09-15 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 10:45 bug#65914: Exclude current buffer from eww-switch-to-buffer James Thomas
2023-09-15 12:05 ` Stefan Kangas [this message]
2023-09-16 0:31 ` James Thomas
2023-10-01 16:53 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=h4fMzjHQoKcVkHt0VaH=vgeOR6MedjfgN4wkEZv_k-w@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=65914@debbugs.gnu.org \
--cc=jimjoe@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).