From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65590: 29.0.50; esh-var-test/interp-concat-cmd fails on macOS Date: Wed, 13 Sep 2023 09:10:52 -0700 Message-ID: References: <7422c797-ff06-b05b-81e9-21b349be30ef@gmail.com> <2a74d651-d8ff-6981-192f-d2820da2edee@gmail.com> <60337c54-6344-7f1b-d6c9-1a21b0d65950@gmail.com> <6d07d208-b7f0-0dd2-b80a-3e05686fef9e@gmail.com> <721e36cb-2fed-fe1b-03ca-2c003474866d@gmail.com> <93bf6090-efb3-80e5-e0fc-88265f96b04f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34464"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65590@debbugs.gnu.org, michael.albinus@gmx.de To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 18:12:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgSTf-0008l7-M0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 18:12:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgSTO-00011w-Ox; Wed, 13 Sep 2023 12:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgST8-0000oz-E9 for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:11:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgST7-0000Y2-SS for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:11:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgSTD-0001Bh-4y for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 12:12:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 16:12:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65590 X-GNU-PR-Package: emacs Original-Received: via spool by 65590-submit@debbugs.gnu.org id=B65590.16946214674461 (code B ref 65590); Wed, 13 Sep 2023 16:12:03 +0000 Original-Received: (at 65590) by debbugs.gnu.org; 13 Sep 2023 16:11:07 +0000 Original-Received: from localhost ([127.0.0.1]:35752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgSSI-00019r-PS for submit@debbugs.gnu.org; Wed, 13 Sep 2023 12:11:07 -0400 Original-Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:61563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgSSG-00019M-Ib for 65590@debbugs.gnu.org; Wed, 13 Sep 2023 12:11:05 -0400 Original-Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so120973941fa.2 for <65590@debbugs.gnu.org>; Wed, 13 Sep 2023 09:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694621453; x=1695226253; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=BTLAR0uSkaXi2RPYUVxguxJ7IQL5+QfX9D+hk5htTFw=; b=B2a/3ZxA/LzKvMwaLpYxdIGd9LJa/eTXev8xgXbe69/fDbB73UEEL9LikZFZKHFg8N UlZX9UZPMAZjKgJvTwo9u4Nf6oU+hX74fkadsQd5Y9YZA/jvLytEIWVxydTwo/6V6a3m AKYZ7RNEuapFRo8o8eep9SLVKO1j0Y+IEMlFhrfDSfdQU7Bf0zTNGYzE2DEI+7seDKH8 SDko7DHMKAQiMHukfH0bzkaHbiEigPxB1VNmiSW2MmfjRs96iDthjlNQpO9B+gimdfiJ ty2RqfGwCF4tn5TInVmgYuxCwogijiG16YyFqfr+FUaQw6aAdfYCXgsnHwHhXdFVzalp dFHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694621453; x=1695226253; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BTLAR0uSkaXi2RPYUVxguxJ7IQL5+QfX9D+hk5htTFw=; b=d/0T9Ps17p8JOO08HuGCE+k7PG/qhOjorvr5UcCxIsgExHeaDCcQEYctV5m6ah6k/Q L1mh5436D7pv4bCSlBZ3IylhO4WHXFzHAWJ7r4SWPNmzjsTeo8mslGn1+5a/BpMLb9gR cIIP33PwIsOJ/7WUbWWJyf8+odoxxNBQi7izjEWGhUVr5K3bNjuoeQfO8RYpjjDI/bU9 RxzibPC0K1qMWUDNwHbMBMAOxfKy/5UpbJ4ODpGsul5jzi9G5idUSyBv1oWezqOGmiwm HbTroNo7IK2piAc0LZX3fRH3nxPC5233D0J4TvlfrYGuNETSeewsDXClW/D2sLraLZJr FRVw== X-Gm-Message-State: AOJu0Yw07ZasWJN/T8ebBpJSj2VsxGHcNpivdL0g7RG6aI1TyH8XJmuu p1OCp10QgHkylOti+f3DD1K3gUdy2ucHialaWOArM/Wb X-Google-Smtp-Source: AGHT+IEoOaQWWy17jFhHaWgIOGIzM09Q17PE3f19kKmIIzXE711tjWqgs+wADMoS0mA1Jbi94eEMXAz/RjGGLh6nwS4= X-Received: by 2002:a2e:3514:0:b0:2bc:f439:b5a5 with SMTP id z20-20020a2e3514000000b002bcf439b5a5mr2730336ljz.14.1694621452845; Wed, 13 Sep 2023 09:10:52 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 09:10:52 -0700 In-Reply-To: <93bf6090-efb3-80e5-e0fc-88265f96b04f@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270328 Archived-At: Jim Porter writes: > On 9/1/2023 10:00 AM, Jim Porter wrote: >> I also pushed a small fix to the debugging code to master as >> da8b323f82417697f9b772689810099f426fe616, but that shouldn't affect this >> case (much). > > I pushed a couple more correctness fixes for Eshell's process management > to master as fad91b56d13. Hopefully these will help matters (but to be > fair, I'm a little skeptical that the bug I fixed is the same as this > bug...) Sorry for the slow turnaround time. I'm currently seeing these test failures on master: Running 46 tests (2023-09-13 16:46:00+0200, selector =E2=80=98(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))=E2=80=99) Loading em-alias... Loading em-banner... Loading em-basic... Loading em-cmpl... Loading em-extpipe... Loading em-glob... Loading em-hist... Loading em-ls... Loading em-pred... Loading em-prompt... Loading em-script... Loading em-term... Loading em-unix... passed 1/46 esh-cmd-test/and-operator (0.259946 sec) passed 2/46 esh-cmd-test/backquoted-lisp-form (0.001679 sec) passed 3/46 esh-cmd-test/backquoted-lisp-form/splice (0.001686 sec) passed 4/46 esh-cmd-test/for-loop (0.006714 sec) passed 5/46 esh-cmd-test/for-loop-for-items-shadow (0.004334 sec) passed 6/46 esh-cmd-test/for-loop-list (0.003476 sec) passed 7/46 esh-cmd-test/for-loop-multiple-args (0.006086 sec) passed 8/46 esh-cmd-test/for-loop-name (0.002023 sec) passed 9/46 esh-cmd-test/for-loop-name-shadow (0.003343 sec) passed 10/46 esh-cmd-test/for-loop-pipe (0.112573 sec) passed 11/46 esh-cmd-test/if-else-statement (0.031268 sec) passed 12/46 esh-cmd-test/if-else-statement-ext-cmd (0.126054 sec) passed 13/46 esh-cmd-test/if-else-statement-lisp-form (0.005082 sec) passed 14/46 esh-cmd-test/if-else-statement-lisp-form-2 (0.004613 sec) passed 15/46 esh-cmd-test/if-else-statement-pipe (0.239692 sec) passed 16/46 esh-cmd-test/if-statement (0.003869 sec) passed 17/46 esh-cmd-test/if-statement-pipe (0.226295 sec) passed 18/46 esh-cmd-test/let-rebinds-after-defer (0.113418 sec) passed 19/46 esh-cmd-test/lisp-command (0.002054 sec) passed 20/46 esh-cmd-test/lisp-command-args (0.002587 sec) passed 21/46 esh-cmd-test/lisp-command-with-quote (0.001719 sec) passed 22/46 esh-cmd-test/or-operator (0.233849 sec) passed 23/46 esh-cmd-test/pipeline-wait/head-proc (0.113463 sec) passed 24/46 esh-cmd-test/pipeline-wait/multi-proc (1.045003 sec) passed 25/46 esh-cmd-test/pipeline-wait/subcommand (0.119225 sec) passed 26/46 esh-cmd-test/pipeline-wait/subcommand-with-pipe (0.137609= sec) passed 27/46 esh-cmd-test/pipeline-wait/tail-proc (0.124454 sec) passed 28/46 esh-cmd-test/quoted-lisp-form (0.002298 sec) Test esh-cmd-test/reset-in-pipeline/lisp backtrace: signal(ert-test-failed (((should (eshell-command-result--equal comma ert-fail(((should (eshell-command-result--equal command (eshell-test eshell-command-result-equal("echo $(format \"%s\" eshell-in-pipeline #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name esh-cmd-test/reset-in-pipeline/lisp : ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-cmd-tests command-line() normal-top-level() Test esh-cmd-test/reset-in-pipeline/lisp condition: Command logs: command: "echo $(format "%s" eshell-in-pipeline-p) | *cat= " ---------------------------------------- [process] started external process =E2=80=98cat=E2=80=99 (ert-test-failed ((should (eshell-command-result--equal command (eshell-test-command-result command) result)) :form (eshell-command-result--equal "echo $(format \"%s\" eshell-in-pipeline-p) | *cat" nil "nil") :value nil :explanation (nonequal-result (command "echo $(format \"%s\" eshell-in-pipeline-p) | *cat") (result nil) (expected "nil")))) FAILED 29/46 esh-cmd-test/reset-in-pipeline/lisp (0.087616 sec) at lisp/eshell/esh-cmd-tests.el:203 Test esh-cmd-test/reset-in-pipeline/subcommand backtrace: signal(ert-test-failed (((should (eshell-command-result--equal comma ert-fail(((should (eshell-command-result--equal command (eshell-test eshell-command-result-equal("echo {echo | echo $eshell-in-pipeline-p #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name esh-cmd-test/reset-in-pipeline/subcom ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-cmd-tests command-line() normal-top-level() Test esh-cmd-test/reset-in-pipeline/subcommand condition: Command logs: command: "echo {echo | echo $eshell-in-pipeline-p} | *cat= " ---------------------------------------- [process] started external process =E2=80=98cat=E2=80=99 (ert-test-failed ((should (eshell-command-result--equal command (eshell-test-command-result command) result)) :form (eshell-command-result--equal "echo {echo | echo $eshell-in-pipeline-p} | *cat" nil "last") :value nil :explanation (nonequal-result (command "echo {echo | echo $eshell-in-pipeline-p} | *cat") (result nil) (expected "last")))) FAILED 30/46 esh-cmd-test/reset-in-pipeline/subcommand (0.078130 sec) at lisp/eshell/esh-cmd-tests.el:184 passed 31/46 esh-cmd-test/simple-command-result (0.003985 sec) passed 32/46 esh-cmd-test/subcommand (0.005324 sec) passed 33/46 esh-cmd-test/subcommand-args (0.002383 sec) passed 34/46 esh-cmd-test/subcommand-lisp (0.001339 sec) passed 35/46 esh-cmd-test/subcommand-shadow-value (0.002534 sec) passed 36/46 esh-cmd-test/unless-else-statement (0.017221 sec) Test esh-cmd-test/unless-else-statement-ext-cmd backtrace: signal(ert-test-failed (((should (eshell-command-result--equal comma ert-fail(((should (eshell-command-result--equal command (eshell-test eshell-command-result-equal("unless {[ foo =3D bar ]} {echo no} {echo #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name esh-cmd-test/unless-else-statement-ex ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-cmd-tests command-line() normal-top-level() Test esh-cmd-test/unless-else-statement-ext-cmd condition: Command logs: command: "unless {[ foo =3D bar ]} {echo no} {echo yes}" ---------------------------------------- [process] started external process =E2=80=98[<1>=E2=80=99 (ert-test-failed ((should (eshell-command-result--equal command (eshell-test-command-result command) result)) :form (eshell-command-result--equal "unless {[ foo =3D bar ]} {echo no} {echo yes}" "yes" "no") :value nil :explanation (nonequal-result (command "unless {[ foo =3D bar ]} {echo no} {echo yes}") (result "yes") (expected "no")))) FAILED 37/46 esh-cmd-test/unless-else-statement-ext-cmd (0.031509 sec) at lisp/eshell/esh-cmd-tests.el:431 passed 38/46 esh-cmd-test/unless-else-statement-lisp-form (0.007760 se= c) passed 39/46 esh-cmd-test/unless-statement (0.003845 sec) passed 40/46 esh-cmd-test/until-loop (0.010837 sec) passed 41/46 esh-cmd-test/until-loop-ext-cmd (0.125156 sec) passed 42/46 esh-cmd-test/until-loop-lisp-form (0.009843 sec) passed 43/46 esh-cmd-test/while-loop (0.012687 sec) passed 44/46 esh-cmd-test/while-loop-ext-cmd (0.155605 sec) passed 45/46 esh-cmd-test/while-loop-lisp-form (0.004418 sec) passed 46/46 esh-cmd-test/while-loop-pipe (0.120805 sec) Ran 46 tests, 43 results as expected, 3 unexpected (2023-09-13 16:46:05+0200, 4.562085 sec) 3 unexpected results: FAILED esh-cmd-test/reset-in-pipeline/lisp FAILED esh-cmd-test/reset-in-pipeline/subcommand FAILED esh-cmd-test/unless-else-statement-ext-cmd