From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#10758: thumbs and image-dired to use built-in ImageMagick Date: Tue, 7 Dec 2021 23:46:58 +0100 Message-ID: References: <8xfwemx6yr.fsf@fencepost.gnu.org> <87k18jw6w0.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12729"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 10758@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 07 23:48:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mujFu-00037F-Dp for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Dec 2021 23:48:14 +0100 Original-Received: from localhost ([::1]:47034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mujFt-0008VQ-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Dec 2021 17:48:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mujFi-0008Uw-VP for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 17:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mujFi-0000FR-Nv for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 17:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mujFi-00021s-Jx for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 17:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Dec 2021 22:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10758 X-GNU-PR-Package: emacs Original-Received: via spool by 10758-submit@debbugs.gnu.org id=B10758.16389172307583 (code B ref 10758); Tue, 07 Dec 2021 22:48:02 +0000 Original-Received: (at 10758) by debbugs.gnu.org; 7 Dec 2021 22:47:10 +0000 Original-Received: from localhost ([127.0.0.1]:38947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mujEr-0001yE-SP for submit@debbugs.gnu.org; Tue, 07 Dec 2021 17:47:10 -0500 Original-Received: from mail-pl1-f174.google.com ([209.85.214.174]:33697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mujEm-0001xT-Ak for 10758@debbugs.gnu.org; Tue, 07 Dec 2021 17:47:08 -0500 Original-Received: by mail-pl1-f174.google.com with SMTP id y7so300648plp.0 for <10758@debbugs.gnu.org>; Tue, 07 Dec 2021 14:47:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=aeNOSnn/KVLCa1n6ECUHY9ciJTvNQ2uEx+BMJuMxfKk=; b=of+hn+qcVYd5ERAKe6GUxmGZZmJ2pHCZsyJVHjLcsiH7gjEvlLoyeFUhLejyZKvXpC nOXLM5Vh6UhER6Q6G9kTC2WTidimvZq5a0bgs4X27xZHgWz8P8qA7PTnP0flW2qTAQIm Zw8yWjNzzAj7HKssF8TR73jhMnmpw7vInqLvN+xBYSoTiY4PuLezjLFyAxF2miUN37aA GoFJhPF/vzGkbys6SaiCnhKFsu3GGYl2h9QlVCQPSg93APjAxxGMX5jgFuXmCOLUXYU7 aAnvr0ivi+bUJd7+Q2FC/X9GjhKFFrIyGLIrhylgF+oJbigK8ZtwBJWpcNrktr3xvXqj rKZg== X-Gm-Message-State: AOAM533QWiVfW9a/ZCq0V90Cd7LfO2Dao1XBefRgBEmlOpaS0/DMBjkg zuBJ6xNjuF0BIxzDwPjjnQStM/eq0VVGk76+6H7FyHq1 X-Google-Smtp-Source: ABdhPJyKxoQteZrMG+/fNEO7jAonBznxIBpnZWcEAiP4xkaIl62+mkNhIEbvtfcnOlNvXDy0M7oh6UF3FBXxd1+K920= X-Received: by 2002:a17:902:c145:b0:142:50c3:c2a with SMTP id 5-20020a170902c14500b0014250c30c2amr54609693plj.32.1638917218570; Tue, 07 Dec 2021 14:46:58 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 7 Dec 2021 23:46:58 +0100 In-Reply-To: (Stefan Kangas's message of "Wed, 27 Oct 2021 15:13:58 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221886 Archived-At: close 10758 29.1 thanks Stefan Kangas writes: > I fixed this in `image-dired' (see separate patch). > > I guess we could rebase thumbs.el to also use the built-in image viewing > support, but I took a look and this external conversion seems built into > the foundation of how that library works. So this looks to me like it > would amount to a rewrite of thumbs.el. I could be wrong of course, but > that was my conclusion after poking at it for an hour or so. > > Furthermore, at this point, image-dired.el is by far the more powerful > package, and it seems better implemented overall. Although it borrows > heavily from thumbs.el (or at least it used to), thumbs.el seems fully > redundant these days. However, it has some features that image-dired.el > does not, especially when it comes to modifying images. > > So rather than attempting a rewrite of thumbs.el, the better solution > seems to me to add any important missing features from thumbs.el to > image-dired.el, and then obsoleting the former (not necessarily in that > order, but either way is fine to me). No further comments within 6 weeks, so I think we can say that this bug is resolved for now, and we can look into making thumbs.el obsolete later. I'm therefore closing this bug as fixed for image-dired.el. If that conclusion is incorrect, please re-open.