From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 2 Nov 2021 12:26:18 -0700 Message-ID: References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <834k8ujso8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33401"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 20:28:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhzSK-0008UV-07 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 20:28:24 +0100 Original-Received: from localhost ([::1]:52898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhzSI-0001UF-Ue for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 15:28:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhzR0-00085E-LO for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 15:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhzR0-0004t8-9i for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 15:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhzR0-00079U-6b for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 15:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163588118727452 (code B ref 51556); Tue, 02 Nov 2021 19:27:02 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 19:26:27 +0000 Original-Received: from localhost ([127.0.0.1]:38126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzQR-00078i-01 for submit@debbugs.gnu.org; Tue, 02 Nov 2021 15:26:27 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:38665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzQO-00078H-Qx for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 15:26:25 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id e65so305764pgc.5 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 12:26:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=SbhEPnA+LWLLrffkJViUviuGThxiiRkqYQcvsbdaD2U=; b=4ZdjhNcja++alvTljzsdqohHAt6UhixHsJsNG/lzohWS6KEcy5CDQe8OPBVHCD5SXY 3NY7mnnxSc6Gx3bAFG6aJ4OKANoLgPqvbZQL4rMouOcYCu3k7rWpb5pv24aKmPKx9Zzu WOTT+9rN1BCYBlZnigxU7dHuf9nB3zVQMYqKz6G6MzZoicus60ZZ7SWsJT99R4Xux6ON 4liBh7qaTz1CzG7zz6o21AAin7PNiy+VGg8jotMJPIL42LD03eHuD3CLFQP1Jj/yPqzv GF2g05AK0ZPbs/XfgAE0lxPcOlNA8RI4pp3+16+Sj97N/IiuNlsoqKMj2IuuiLYubz9N xPGw== X-Gm-Message-State: AOAM533OS0kaQ6Kh5No9Zdazce/Rg6tffwwBLvt2ZMBeoRqexmUL6iIc c5N2ICnMcJ9i/XA5SG9k1Vxpetm/WsYl+aI/IEo= X-Google-Smtp-Source: ABdhPJwYbsS/76Mn8765lg4g257ev/+YGOKCzix1ND1HqVXG3fWModSXnIMPaS7AeVM+CFuc0hszUmZFn4bPwgVpCKU= X-Received: by 2002:a05:6a00:244d:b0:44d:c279:5155 with SMTP id d13-20020a056a00244d00b0044dc2795155mr38494884pfj.0.1635881179233; Tue, 02 Nov 2021 12:26:19 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 12:26:18 -0700 In-Reply-To: <834k8ujso8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218831 Archived-At: Eli Zaretskii writes: >> It is certainly the correct solution for all the sets of scalable icons >> that I have reviewed. Which SVG icons do you have in mind? Could you >> point me to them? > > Try splash.svg, as a trivial example (and forget that it's too large > for an icon, this is just an example). That's correct, this approach won't work for multi-color SVG's. But see Jim Porter's reply. >> For the icons I know of, the best solution if you need to change the >> color of this or that icon, is to either change the active defface to >> use the correct color, or to introduce a new defface. This is, not by >> accident, the chosen solution also for icons on the web. > > We have a disconnect here, because I don't follow. Are you talking > only about SVG that use only the gray color for its lines? I'm talking about what Jim Porter calls "Single-color SVGs". This case is applicable to all sets of free and scalable icons that I have reviewed. This includes the most popular and extensive icon sets, such as fontawesome, octicons and material icons. In all these cases, the SVG files may or may not come with a foreground color, but that is an implementation accident: they are mainly intended for use in a web browser, where the web browser will override the foreground color with the foreground color specified by CSS. In Emacs, we don't let faces override a foreground color specified in an SVG file (that won't work in general, as is clear from the "splash.svg" example), so if we want this functionality, we must take care to remove the foreground color in the SVG file. > I said "should allow", and you say "need". Aha. Thanks for clarifying. Then your position does not seem to be all that different from mine. Perhaps it is only a difference in priorities, or perhaps there will exist no difference in practice. >> Furthermore, the patch I have already posted here is sufficient for the >> purposes of this bug report. I suggest we install it. > > On master? I don't object. Thank you, installed as commit 11702a6dd7.