From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#38072: when `byte-compile-file' finds out that a file is `no-byte-compile', it ignores `load' parameter Date: Mon, 7 Sep 2020 09:37:29 -0700 Message-ID: References: <834kocrbg1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4536"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pogonyshev@gmail.com, 38072@debbugs.gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 18:39:06 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFKAb-00014c-6b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 18:39:05 +0200 Original-Received: from localhost ([::1]:44878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFKAa-0001n3-8n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 12:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFK9a-0000DJ-FS for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 12:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFK9a-0008Aa-6B for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 12:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFK9a-0003Ff-41 for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 12:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Sep 2020 16:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38072-submit@debbugs.gnu.org id=B38072.159949665712469 (code B ref 38072); Mon, 07 Sep 2020 16:38:02 +0000 Original-Received: (at 38072) by debbugs.gnu.org; 7 Sep 2020 16:37:37 +0000 Original-Received: from localhost ([127.0.0.1]:50620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFK9B-0003F3-Bz for submit@debbugs.gnu.org; Mon, 07 Sep 2020 12:37:37 -0400 Original-Received: from mail-ej1-f51.google.com ([209.85.218.51]:40676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFK99-0003Er-Sc for 38072@debbugs.gnu.org; Mon, 07 Sep 2020 12:37:36 -0400 Original-Received: by mail-ej1-f51.google.com with SMTP id z22so18924024ejl.7 for <38072@debbugs.gnu.org>; Mon, 07 Sep 2020 09:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=LmgWGnyC5tKFTh7zE2eqmjAX24a0G64DjMnkbi/gl2o=; b=najit0zgw6mt6pzW3mBJk2hElt0rFM/RNn98ZEKL9TYiUKEgmpofQoZG2nrSbVNqd+ eynzamywQfAnX9Eid1nEY6epEOdHz1oO8PyFUe0flGxJY6spIUZbhaV2ISRFSl11l2Pp erAYJbbxYxufzqj6RkXhHcYKIPV3RqIjliT07+8iWAeW5xx9Adh2hDVpene4aGCk4+WN k12fvkyn5Yk69o3KJZ8GYkTfVOTXMzqVpKnvPeBM3yKDKnuuoRj2HX6W5GjJ0cAX8RhG 9w5CawQ4awGfUf+vOYoo1GUUWYDR2lQGMyjaJsFdRiquLW1Qi8McbuP2BRGCSEfjBw2a YowA== X-Gm-Message-State: AOAM530AouJdC3yFGBsa5be3Vd/RtFPLGg/D0aCAro6qiPbovrnjavwd DrmEnBuxwKMuYPOedxJtWVlT62FJeBO34wVwLBQ= X-Google-Smtp-Source: ABdhPJxA+Q1GTvpLTwIsN0XfXOQdzq4CQ9OPwmll4Ee5Hnb30XPNXqHcpo3WjujEHnUejndbrXQLdiFP+PqXRqJtCqE= X-Received: by 2002:a17:906:bb0e:: with SMTP id jz14mr22721152ejb.525.1599496649943; Mon, 07 Sep 2020 09:37:29 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 7 Sep 2020 09:37:29 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187452 Archived-At: Stefan Monnier writes: > FWIW, I find the "and load" feature to be a mistake: the function should > return whether or not it successfully compiled the file, but shouldn't > offer to load the result, since the callers can just as easily do > it themselves (and then they can easily control what happens when > compilation did not succeed). > So, I'd suggest we deprecate that "feature" rather than try and decide > which behavior is better. It's pretty convenient when running interactively though. I've tried using `C-u M-x byte-compile-file' (instead of my usual eval-buffer) for the last couple of days, and I kind of like getting both byte-compilation and load-file in one command. But if we do deprecate this, is there a better alternative that we can point users to? Should we just tell them to run two commands?