From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 2 Nov 2021 11:43:08 -0700 Message-ID: References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2849"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 19:50:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhyro-0000WM-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 19:50:40 +0100 Original-Received: from localhost ([::1]:37064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhyrm-0003Y1-Ci for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 14:50:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhylO-0001TR-JE for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhylO-0003NS-AS for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhylO-0003q3-6F for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163587859614680 (code B ref 51556); Tue, 02 Nov 2021 18:44:02 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:43:16 +0000 Original-Received: from localhost ([127.0.0.1]:38064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyke-0003oh-Ic for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:43:16 -0400 Original-Received: from mail-pg1-f175.google.com ([209.85.215.175]:34475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhykd-0003oQ-3s for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:43:15 -0400 Original-Received: by mail-pg1-f175.google.com with SMTP id j9so230278pgh.1 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 11:43:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=nmigvNx+lR4vq9A0s2YXIxB2otyjH4cULSQoHdaTPdU=; b=HgG0PTfEBhpudmny7YtvcT1721ToIvzk2oqY2Ps1yVOQGYfF1+xzyZzpWFaSaCkTYw 8ERYKWN3Q+Iye3QsyLqnlNwPz6aL0YSwRi88u7YSJDs2a9OHZz1UCbDG5CzgWpvYZPSQ Cncb2gATEP4KW6/G2g2wqMcdR7YNT7VhDzZ7cbtnTRa0aPm/TzgYxnaUYN6E5E6VnqiX GklluPHgLS731Vx3h0KFdFWH9QJVFTDQnQ8nC/rPd5Gf1ZHFtxkuc9UKsfH/FXqPUzkw 3kLXAM2OHDa3Z2t3W9eJQ3IA+7ZPWZ+TPFDwIsWylL4IN0WqTyeOeagc6HzQOiakNDA5 C04Q== X-Gm-Message-State: AOAM530KunVfATEa+h9VMTYeBoRZ5lMBFp/hasA8TbBTSrvBl84Qwbp4 gbA3MfidEAINOH5/Jx5L4azXk9JXKC3ePWqhCNQ= X-Google-Smtp-Source: ABdhPJxGxa/EEURp0RYOibqH2dSkqvJzMDiwX9dd7a/ob+llgD3r+Kof1qNudD0HO8L7EGG+c0HgyI6eof7w2OQ3UjI= X-Received: by 2002:a63:330f:: with SMTP id z15mr29355369pgz.42.1635878589388; Tue, 02 Nov 2021 11:43:09 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 11:43:08 -0700 In-Reply-To: <83a6imjv2o.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218825 Archived-At: Eli Zaretskii writes: > If the solution you propose only works for SVG that specify no > foreground, then it won't be able to solve all of the situations where > a different theme makes an icon barely visible or unpleasant to the > eye. It is certainly the correct solution for all the sets of scalable icons that I have reviewed. Which SVG icons do you have in mind? Could you point me to them? For the icons I know of, the best solution if you need to change the color of this or that icon, is to either change the active defface to use the correct color, or to introduce a new defface. This is, not by accident, the chosen solution also for icons on the web. > Which is why I think a better solution would be to allow themes > to specify different icons where necessary. Color themes should not *need* to provide their own icons when all they want is to change the color of an icon. That puts an unnecessary and completely avoidable burden on theme developers, for starters because they would need to learn how to edit SVG files (which is not trivial). It is also less flexible, as how icons look is orthogonal to what color they have. If you propose that this should exist as an option, that is fine by me, but I don't see any need for it. I don't think we should impose an inflexible solution when I have already indicated in several messages that I'm working on a better one. The solution you propose goes in the completely opposite direction of that work, so I hope that we won't do that. Furthermore, the patch I have already posted here is sufficient for the purposes of this bug report. I suggest we install it.