From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37837: [PATCH] Make sb-image.el obsolete Date: Sat, 2 Nov 2019 04:21:27 +0100 Message-ID: References: <83d0eq4nrb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202738"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37837@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 02 04:22:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQjzd-000qc1-2A for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Nov 2019 04:22:25 +0100 Original-Received: from localhost ([::1]:44984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQjza-0004ib-RM for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 23:22:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45478) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQjzK-0004iP-1g for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 23:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQjzG-000645-1v for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 23:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQjzF-00063Z-Ud for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 23:22:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQjzF-0002HV-LS for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 23:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Nov 2019 03:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37837 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37837-submit@debbugs.gnu.org id=B37837.15726649068741 (code B ref 37837); Sat, 02 Nov 2019 03:22:01 +0000 Original-Received: (at 37837) by debbugs.gnu.org; 2 Nov 2019 03:21:46 +0000 Original-Received: from localhost ([127.0.0.1]:57913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQjz0-0002Gu-F6 for submit@debbugs.gnu.org; Fri, 01 Nov 2019 23:21:46 -0400 Original-Received: from mail-pf1-f195.google.com ([209.85.210.195]:45788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQjyy-0002Gh-GO for 37837@debbugs.gnu.org; Fri, 01 Nov 2019 23:21:45 -0400 Original-Received: by mail-pf1-f195.google.com with SMTP id z4so2242036pfn.12 for <37837@debbugs.gnu.org>; Fri, 01 Nov 2019 20:21:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V8Zu8HKD8AWqJJqgYy4HtNHa703uZt5bFrvyEIZLZ1M=; b=U9N4/zdPxWmmIhv6rcwD0k2+gATF84nuczEpYcM9cX8/K47Bm+/i8x8GVr1nciQ5eE /Xv5kk+mh0Uo9VyMBhIBXjKSpnNr+zt1Ckcq7sWzd7JZ6DSskVppAlOmorVHEv2as38h dhfTmBpVgrwZUjOWLm5YCEUnIboe4lHgT8p0RisZFqEIrQn8NKsyO3lAF0C++Fthmmx5 NtmPIOBYTUBl9xVUTXKE5mMfn3+Ky1HKPjvKXnIqjJlLnC04yF8qGrQLgEUtaKBGd6rF 8OkxR4k62gw5l3zmgmyIBuQDP1Kt5FzL5lm9/+WjiCFOlcqF11iw8Urm8QAvk2UwGCu3 fd5A== X-Gm-Message-State: APjAAAUDq7I9Dzdmebmm/oJfv62kWPzgFG6qVrcyxCz6aLY/egzITk4l hdkU3r7eSup51eOUpL1U1fQivfgjE9qUBKpe6XU= X-Google-Smtp-Source: APXvYqydfIltKBXi+CJKuzkZniKDCfNPQfPFHprn31HhKn1s6PffvK91XYE0370WYk8j/V2FwskdR+K+fpcF2Ffnc9g= X-Received: by 2002:a63:a05c:: with SMTP id u28mr18048491pgn.333.1572664898472; Fri, 01 Nov 2019 20:21:38 -0700 (PDT) In-Reply-To: <83d0eq4nrb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170746 Archived-At: Eli Zaretskii writes: > > > From: Stefan Kangas > > Date: Sun, 20 Oct 2019 22:28:40 +0200 > > > > sb-image.el says: > > > > ;; Supporting Image display for Emacs 20 and less, Emacs 21, and XEmacs, > > ;; is a challenging task, which doesn't take kindly to being byte compiled. > > ;; When sharing speedbar.elc between these three applications, the Image > > ;; support can get lost. > > ;; > > ;; By splitting out that hard part into this file, and avoiding byte > > ;; compilation, one copy speedbar can support all these platforms together. > > > > I suggest to get rid of this compatibility kludge. Is the attached > > patch an acceptable way to do that? > > Did we decide to drop support of those older Emacs versions? I'm not aware of any general requirement to maintain backwards compatibility with ancient Emacs versions on master. For example, we have dropped all compatibility function and variable aliases. Users of Emacs 21 or older should surely just use whatever was shipped with the version of Emacs that they are using. Or am I missing something? To be clear, this package is not distributed on GNU ELPA as far as I can tell. Best regards, Stefan Kangas