From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51049: 28.0.50; tool-bar :vert-only property is broken, not documented and of limited use Date: Tue, 5 Oct 2021 19:57:51 -0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13070"; mail-complaints-to="usenet@ciao.gmane.io" To: 51049@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 06 01:58:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXuK2-0003BH-Eb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 01:58:10 +0200 Original-Received: from localhost ([::1]:56154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXuK0-0005qk-CW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Oct 2021 19:58:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXuJu-0005qb-EG for bug-gnu-emacs@gnu.org; Tue, 05 Oct 2021 19:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58811) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXuJu-0001oz-6r for bug-gnu-emacs@gnu.org; Tue, 05 Oct 2021 19:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXuJu-0004t5-47 for bug-gnu-emacs@gnu.org; Tue, 05 Oct 2021 19:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Oct 2021 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51049 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163347828018778 (code B ref -1); Tue, 05 Oct 2021 23:58:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Oct 2021 23:58:00 +0000 Original-Received: from localhost ([127.0.0.1]:42124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXuJr-0004sn-L4 for submit@debbugs.gnu.org; Tue, 05 Oct 2021 19:57:59 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXuJn-0004sc-K6 for submit@debbugs.gnu.org; Tue, 05 Oct 2021 19:57:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXuJn-0005qR-Be for bug-gnu-emacs@gnu.org; Tue, 05 Oct 2021 19:57:55 -0400 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:38470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXuJl-0001in-Mm for bug-gnu-emacs@gnu.org; Tue, 05 Oct 2021 19:57:55 -0400 Original-Received: by mail-pl1-f169.google.com with SMTP id x4so542755pln.5 for ; Tue, 05 Oct 2021 16:57:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=fLQDWgr9Y0Wdc0vVqB8yUcbsnYmgZBQnL1agzTROqqU=; b=2jBLhW2Yh1+1mde+BvHBsaLVf6qNpO6CwwfSGUb0WU+Kk5BeoE+Sas0aZ4vQ30jRW1 OMU3uNRZE7dVBJ4NNkIkFCV5mitAwlaHbBv4B/RHgq4Fp2l+hc6tWpZ/rNipLd9qHb1g KbhkCKOjNeSOiX2bTyqdyiTuBI01W1vxJ/uup5aARfODUu9eORnjCGOaIR8sSSu3HmcG pKwI7uGSXaScvQor//E7tE5r1DzCuxyO/+fBIKcfCc7ra15OWnjQILwepjFfFjIRqBjk KVNK5GwM/z+nyPzOk1VqMQhXrPb6Db0bWwfrXj5tRYBGlGXSWTuS9ibMB2KMcbpoMKUb XaCQ== X-Gm-Message-State: AOAM5324XgLzWrITOyMYgsSghV2WUCTfUFfEFyE5P9lpYy7hdEzXwMjg 2MhNYPQRwKwdhO3lOX0geOu1REqn7rsp9X+EXs6bgxAV X-Google-Smtp-Source: ABdhPJxzHuJ69A6aeRM3zM7f1Mhn5kSMHLenBAvOmYgg2dDKDOGA1IFjn9PhX3kltsR1/OD2nE+EAhShpwnmWw9TA3w= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr7910882pls.71.1633478272069; Tue, 05 Oct 2021 16:57:52 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Oct 2021 19:57:51 -0400 Received-SPF: pass client-ip=209.85.214.169; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f169.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216506 Archived-At: According to commit d2bd51898e4 the :vert-only property for toolbar items is supposed to be "for tool bar items with labels not shown horizontally". These properties are used in some places in our sources, but are not documented in (info "(elisp) Tool Bar"). They also don't seem to be working, at least not in GTK: 0. emacs -Q 1. (custom-set-variables '(tool-bar-position 'left)) 2. M-x mpc RET (Note that the entire tool-bar in mpc.el has the :vert-only property.) This is extra strange as AFAICT, the only place where we check for this property is in gtkutil.c. So the only place where it was implemented, the feature is broken? I also do wonder if this property is at all useful. If anything, I would like the option to *hide* labels in horizontal mode, as having labels makes the toolbar change size when I switch between windows to with different major modes. This makes windows jump around horizontally, which is eminently unusable. (But this would be more useful as a global user option than as properties, set to t by default, to avoid the jumping.) So should the :vert-only property be documented? Fixed? Removed? In GNU Emacs 28.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-09-30 built on joffe Repository revision: ec9e8a9961362cd238879c9e96617ebd2f64af9a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LC_CTYPE: sv_SE.UTF-8 value of $LC_TIME: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix