From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips Date: Mon, 10 Jun 2019 03:14:12 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000008e4e1f058aede687" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95622"; mail-complaints-to="usenet@blaine.gmane.org" To: 36156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 10 03:15:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ha8u2-000Oh8-4O for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 03:15:14 +0200 Original-Received: from localhost ([::1]:39412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ha8u0-0005BX-2W for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Jun 2019 21:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45394) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ha8tt-0005BI-VQ for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ha8tr-0003PO-Ty for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42130) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ha8tq-0003OS-Tf for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ha8tq-00017N-Nr for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2019 01:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15601292694233 (code B ref -1); Mon, 10 Jun 2019 01:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Jun 2019 01:14:29 +0000 Original-Received: from localhost ([127.0.0.1]:55674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha8tI-00016D-V5 for submit@debbugs.gnu.org; Sun, 09 Jun 2019 21:14:29 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha8tH-000165-0E for submit@debbugs.gnu.org; Sun, 09 Jun 2019 21:14:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45269) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ha8tG-00055u-4Y for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:14:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ha8tF-00030E-7p for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:14:26 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:38559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ha8tF-0002zr-0q for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 21:14:25 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id d18so7416241wrs.5 for ; Sun, 09 Jun 2019 18:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=wPZWvbnloGcsftahcEuY4zeIT4QqgQR53rXScUEzu34=; b=Dg871TcQ+94ZvXuAocRWdBcjwOsIqwMBVfssK1UMAWqHwM99KneJUNbkvsVfYtdKU3 2e3w4AOYqkGt+e57gQiZDWCXgVdf0SfFSaVCukpCMbwvOIXg/vV1z+HfbGrBP7hD6/BX s6Rk8AEDzUx11mm1I43NNkghX3LZ0A87UTsKv7GaOvjnsVtN4DkkWoXwmC1oQCdKGaJp nqKBCKWGne0eAzw6dmOGLiqt2Poyp4MknvPJaH3huueF32qCBrwnYsUkqTYCA8j0tFPc smqELGWWyBqlmSOE3SYuPO8/LAa+VznTJMDFWfT+Zqc6sVbnRse962phJJlxUg32JdZf 2J6Q== X-Gm-Message-State: APjAAAUSLcZAQwXVKZ5ccPfDE7FhGHxLTXBEI2ruCSj7tCSH169tgu4H X9vqoIfPJuItOgJcNlmWRnAb4Zu3t63f6gBPwwyLYA== X-Google-Smtp-Source: APXvYqx99tTX+qrgbwhDTvOKSFUHsko28MXn1bTc56hf2nTrD8odGRTCUchL087xXINv1KRxuL/fMOFttzYDFFZwwYM= X-Received: by 2002:adf:90c3:: with SMTP id i61mr26921765wri.48.1560129263513; Sun, 09 Jun 2019 18:14:23 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160314 Archived-At: --0000000000008e4e1f058aede687 Content-Type: text/plain; charset="UTF-8" I have implemented the following item from etc/TODO: ** The toolbar should show keyboard equivalents in its tooltips. I'm an absolute beginner to Emacs internals and had a lot of fun solving this. Please let me know what you think. Thanks, Stefan Kangas --0000000000008e4e1f058aede687 Content-Type: application/octet-stream; name="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti.patch" Content-Disposition: attachment; filename="0001-Make-toolbar-show-keyboard-equivalents-in-its-toolti.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwpon4pi0 RnJvbSAwODJmNjQwNTMzNGQ0Y2ZmYWE3N2NmMTdkY2NiM2U2NGU5MjNjZGZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDkgSnVuIDIwMTkgMDQ6Mjc6MDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIHRvb2xiYXIgc2hvdyBrZXlib2FyZCBlcXVpdmFsZW50cyBpbiBpdHMgdG9vbHRpcHMKCiog c3JjL2tleWJvYXJkLmMgKHBhcnNlX3Rvb2xfYmFyX2l0ZW0pOiBBZGQgZXF1aXZhbGVudCBrZXkg YmluZGluZyB0bwp0aGUgdG9vbHRpcCBzdHJpbmcgb2YgdG9vbGJhciBidXR0b25zLgoqIGV0Yy9O RVdTOiBBbm5vdW5jZSBpdC4KKiBldGMvVE9ETzogUmVtb3ZlIGl0cyBlbnRyeS4KKiBzcmMvZm5z LmMgKGNvbmNhdDQpOiBOZXcgZnVuY3Rpb24uCiogc3JjL2xpc3AuaCAoY29uY2F0NCk6IERlY2xh cmUuCi0tLQogZXRjL05FV1MgICAgICAgfCAgMyArKysKIGV0Yy9UT0RPICAgICAgIHwgIDIgLS0K IHNyYy9mbnMuYyAgICAgIHwgIDcgKysrKysrKwogc3JjL2tleWJvYXJkLmMgfCAxMyArKysrKysr KysrKysrCiBzcmMvbGlzcC5oICAgICB8ICAxICsKIDUgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdT CmluZGV4IGM5ZGE5OGIwYWQuLjc3MjY0NDM1NTEgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBi L2V0Yy9ORVdTCkBAIC0xMjEsNiArMTIxLDkgQEAgVGhpcyBpcyBpbnRlbmRlZCBtb3N0bHkgdG8g aGVscCBkZXZlbG9wZXJzLgogKiogRW1hY3Mgbm93IHJlcXVpcmVzIEdUSyAyLjI0IGFuZCBHVEsg My4xMCBmb3IgdGhlIEdUSyAyIGFuZCBHVEsgMwogYnVpbGRzIHJlc3BlY3RpdmVseS4KIAorLS0t CisqKiBUaGUgdG9vbGJhciBub3cgc2hvd3MgdGhlIGVxdWl2YWxlbnQga2V5IGJpbmRpbmcgaW4g aXRzIHRvb2x0aXBzLgorCiAMCiAqIFN0YXJ0dXAgQ2hhbmdlcyBpbiBFbWFjcyAyNy4xCiAKZGlm ZiAtLWdpdCBhL2V0Yy9UT0RPIGIvZXRjL1RPRE8KaW5kZXggZjhjMmQyODVlZS4uYjljOGMwYWFl OSAxMDA2NDQKLS0tIGEvZXRjL1RPRE8KKysrIGIvZXRjL1RPRE8KQEAgLTE3Niw4ICsxNzYsNiBA QCBTZWUgdGhlICd0ZXN0JyBkaXJlY3RvcnkgZm9yIGV4YW1wbGVzLgogKiogSW4gRW1hY3MgSW5m bywgZXhhbXBsZXMgb2YgdXNpbmcgQ3VzdG9taXplIHNob3VsZCBiZSBjbGlja2FibGUKICAgIGFu ZCB0aGV5IHNob3VsZCBjcmVhdGUgQ3VzdG9tIGJ1ZmZlcnMuCiAKLSoqIFRoZSB0b29sYmFyIHNo b3VsZCBzaG93IGtleWJvYXJkIGVxdWl2YWxlbnRzIGluIGl0cyB0b29sdGlwcy4KLQogKiogQWRk IGZ1bmN0aW9uIHRvIHJlZHJhdyB0aGUgdG9vbCBiYXIuCiAKICoqIFJlZGVzaWduIHRoZSBsb2Fk LWhpc3RvcnkgZGF0YSBzdHJ1Y3R1cmUgc28gaXQgY2FuIGNvcGUgYmV0dGVyCmRpZmYgLS1naXQg YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggZWFhMmMwN2ZiZS4uZjA4OTUwMzkzOSAxMDA2 NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNTM2LDYgKzUzNiwxMyBAQCBj b25jYXQzIChMaXNwX09iamVjdCBzMSwgTGlzcF9PYmplY3QgczIsIExpc3BfT2JqZWN0IHMzKQog ICByZXR1cm4gY29uY2F0ICgzLCAoKExpc3BfT2JqZWN0IFtdKSB7czEsIHMyLCBzM30pLCBMaXNw X1N0cmluZywgMCk7CiB9CiAKKy8qIEFSR1NVU0VEICovCitMaXNwX09iamVjdAorY29uY2F0NCAo TGlzcF9PYmplY3QgczEsIExpc3BfT2JqZWN0IHMyLCBMaXNwX09iamVjdCBzMywgTGlzcF9PYmpl Y3QgczQpCit7CisgIHJldHVybiBjb25jYXQgKDQsICgoTGlzcF9PYmplY3QgW10pIHtzMSwgczIs IHMzLCBzNH0pLCBMaXNwX1N0cmluZywgMCk7Cit9CisKIERFRlVOICgiYXBwZW5kIiwgRmFwcGVu ZCwgU2FwcGVuZCwgMCwgTUFOWSwgMCwKICAgICAgICBkb2M6IC8qIENvbmNhdGVuYXRlIGFsbCB0 aGUgYXJndW1lbnRzIGFuZCBtYWtlIHRoZSByZXN1bHQgYSBsaXN0LgogVGhlIHJlc3VsdCBpcyBh IGxpc3Qgd2hvc2UgZWxlbWVudHMgYXJlIHRoZSBlbGVtZW50cyBvZiBhbGwgdGhlIGFyZ3VtZW50 cy4KZGlmZiAtLWdpdCBhL3NyYy9rZXlib2FyZC5jIGIvc3JjL2tleWJvYXJkLmMKaW5kZXggYmI0 ZDE4NWM5MS4uMDJhZTA1ZTA4ZCAxMDA2NDQKLS0tIGEvc3JjL2tleWJvYXJkLmMKKysrIGIvc3Jj L2tleWJvYXJkLmMKQEAgLTgyOTcsNiArODI5NywxOSBAQCBwYXJzZV90b29sX2Jhcl9pdGVtIChM aXNwX09iamVjdCBrZXksIExpc3BfT2JqZWN0IGl0ZW0pCiAgIGlmIChDT05TUCAoZ2V0X2tleW1h cCAoUFJPUCAoVE9PTF9CQVJfSVRFTV9CSU5ESU5HKSwgMCwgMSkpKQogICAgIHJldHVybiAwOwog CisgIC8qIElmIHRoZXJlIGlzIGEga2V5IGJpbmRpbmcsIGFkZCBpdCB0byB0aGUgaGVscCwgd2hp Y2ggd2lsbCBiZQorICAgICBkaXNwbGF5ZWQgYXMgYSB0b29sdGlwIGZvciB0aGlzIGVudHJ5LiAq LworICBMaXNwX09iamVjdCBiaW5kaW5nID0gUFJPUCAoVE9PTF9CQVJfSVRFTV9CSU5ESU5HKTsK KyAgTGlzcF9PYmplY3Qga2V5cyA9IEZ3aGVyZV9pc19pbnRlcm5hbCAoYmluZGluZywgUW5pbCwg UXQsIFFuaWwsIFFuaWwpOworICBpZiAoIU5JTFAgKGtleXMpKQorICAgIHsKKyAgICAgIEFVVE9f U1RSSU5HIChiZWcsICIgIFsiKTsKKyAgICAgIEFVVE9fU1RSSU5HIChlbmQsICJdIik7CisgICAg ICBMaXNwX09iamVjdCBvcmlnID0gUFJPUCAoVE9PTF9CQVJfSVRFTV9IRUxQKTsKKyAgICAgIExp c3BfT2JqZWN0IGRlc2MgPSBGa2V5X2Rlc2NyaXB0aW9uIChrZXlzLCBRbmlsKTsKKyAgICAgIHNl dF9wcm9wIChUT09MX0JBUl9JVEVNX0hFTFAsIGNvbmNhdDQgKG9yaWcsIGJlZywgZGVzYywgZW5k KSk7CisgICAgfQorCiAgIC8qIEVuYWJsZSBvciBkaXNhYmxlIHNlbGVjdGlvbiBvZiBpdGVtLiAg Ki8KICAgaWYgKCFFUSAoUFJPUCAoVE9PTF9CQVJfSVRFTV9FTkFCTEVEX1ApLCBRdCkpCiAgICAg c2V0X3Byb3AgKFRPT0xfQkFSX0lURU1fRU5BQkxFRF9QLApkaWZmIC0tZ2l0IGEvc3JjL2xpc3Au aCBiL3NyYy9saXNwLmgKaW5kZXggNzdmYzIyZDExOC4uNGZhZjlkMGJmMSAxMDA2NDQKLS0tIGEv c3JjL2xpc3AuaAorKysgYi9zcmMvbGlzcC5oCkBAIC0zNjEzLDYgKzM2MTMsNyBAQCAjZGVmaW5l IENPTlNfVE9fSU5URUdFUihjb25zLCB0eXBlLCB2YXIpCQkJCVwKIGV4dGVybiBMaXNwX09iamVj dCBkb195ZXNfb3Jfbm9fcCAoTGlzcF9PYmplY3QpOwogZXh0ZXJuIExpc3BfT2JqZWN0IGNvbmNh dDIgKExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCk7CiBleHRlcm4gTGlzcF9PYmplY3QgY29uY2F0 MyAoTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCk7CitleHRlcm4gTGlzcF9P YmplY3QgY29uY2F0NCAoTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0LCBMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpOwogZXh0ZXJuIGJvb2wgZXF1YWxfbm9fcXVpdCAoTGlzcF9PYmplY3QsIExpc3Bf T2JqZWN0KTsKIGV4dGVybiBMaXNwX09iamVjdCBuY29uYzIgKExpc3BfT2JqZWN0LCBMaXNwX09i amVjdCk7CiBleHRlcm4gTGlzcF9PYmplY3QgYXNzcV9ub19xdWl0IChMaXNwX09iamVjdCwgTGlz cF9PYmplY3QpOwotLSAKMi4yMS4wCgo= --0000000000008e4e1f058aede687--