From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 9 Aug 2022 09:11:07 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3684"; mail-complaints-to="usenet@ciao.gmane.io" To: 57079@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 18:22:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLRzc-0000ox-Qu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 18:22:08 +0200 Original-Received: from localhost ([::1]:51094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLRzb-0000N8-Hl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 12:22:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLRpr-0005Lv-01 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLRpq-00017u-Ik for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLRpq-0007Pw-9q for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57079 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166006147428452 (code B ref -1); Tue, 09 Aug 2022 16:12:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Aug 2022 16:11:14 +0000 Original-Received: from localhost ([127.0.0.1]:44586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLRp3-0007Oq-Oo for submit@debbugs.gnu.org; Tue, 09 Aug 2022 12:11:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLRp1-0007Oi-0m for submit@debbugs.gnu.org; Tue, 09 Aug 2022 12:11:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLRp0-00033v-Rh for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:11:10 -0400 Original-Received: from mail-vs1-f49.google.com ([209.85.217.49]:37437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLRoz-00011g-AM for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:11:10 -0400 Original-Received: by mail-vs1-f49.google.com with SMTP id 66so12389710vse.4 for ; Tue, 09 Aug 2022 09:11:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=kQSP3WorPzo2qX6aFSsiMumKvlHoGhnxuJAo/NOP2ao=; b=L5Tp6OJlNP/M9IoSLHSPUjNG4hkvWCQN8eMyD2x4uY2RRZXeyciV4Wd6WI3khBIU3I SiyP//0Gb6xA0mj8hfZOrmR+EzlSOu0AbCWlpabjy13vheCN7/TqaPn4YlflhVCkKh7V W6wY8MANVv8r/OlfsYWwfGo+Aw/8umUGplet38frAJxdKcLUrlnjY4YvUlJeTM7k5Ul/ AMLR5i531j350d+jFxivmMxo5GOXSi3sY0e0xFs9HFqy6HqFLmIkZiWVC7voXHA320OF brpEnudK1X+FGKKjXcyqWASNWeoyuQ7YmJSVcg1AN3vIUJ1KF+R1Br2c3ZAR56+MaS9o nhIg== X-Gm-Message-State: ACgBeo28Q7CHLzoaB+RXza/qroHpeTQARLTMzk+CDUJZzNk0YJ46pihR bAdbaMrUeLlOCo4Swq2gwj7vfg1n/hbfTX6ZkzOM3jkd X-Google-Smtp-Source: AA6agR5MiDk8veBFouP28tnEOTW+sWP66XXF8PfDajbH8uY5iYWUTk93vqeUyZdTfXRy9VPgWp2NexzPDbBLdNakvrk= X-Received: by 2002:a05:6102:7c6:b0:37d:34bd:8564 with SMTP id y6-20020a05610207c600b0037d34bd8564mr9685712vsg.59.1660061467854; Tue, 09 Aug 2022 09:11:07 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Aug 2022 09:11:07 -0700 Received-SPF: pass client-ip=209.85.217.49; envelope-from=stefankangas@gmail.com; helo=mail-vs1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239163 Archived-At: Severity: minor `seq-uniq' is not very performant compared to `-uniq' (from dash.el) and even slower compared to the recently removed `gnus-delete-duplicates': (benchmark-run 10000 (seq-uniq '(a c b c c a d))) => (0.355001481 1 0.2518970439999748) (benchmark-run 10000 (-uniq '(a c b c c a d))) => (0.006599549 0 0.0) (benchmark-run 10000 (gnus-delete-duplicates '(a c b c c a d))) => (0.0034537929999999997 0 0.0) Could we improve the performance of `seq-uniq' for lists? PS. `gnus-delete-duplicates' was recently removed but looks like this: (defun gnus-delete-duplicates (list) "Remove duplicate entries from LIST." (let ((result nil)) (while list (unless (member (car list) result) (push (car list) result)) (pop list)) (nreverse result)))