From: Stefan Kangas <stefan@marxist.se>
To: Glenn Morris <rgm@gnu.org>, Eli Zaretskii <eliz@gnu.org>
Cc: 50752@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
shuguang79@qq.com
Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key
Date: Sun, 24 Oct 2021 13:11:26 -0700 [thread overview]
Message-ID: <CADwFkm=Oz-OZLLfAdrHkS1zzsBwE0=+q6PZ8Zd5z=Q+HTxVtVQ@mail.gmail.com> (raw)
In-Reply-To: <881r4fq5b8.fsf@fencepost.gnu.org>
Glenn Morris <rgm@gnu.org> writes:
> It's very late to comment, but was the approach of adding an optional
> argument to easy-menu-define that specifies the precise string to intern
> (in place of "(downcase (car menu))"), and using that argument where
> needed in those Emacs files that were converted to use easymenu,
> rejected?
I think at this point, the main counter-argument is that we have one of
the fixes ready, whereas the other one isn't. I have been mulling your
message over the past couple of days, and I can't really see that your
proposed solution is significantly better. The chosen solution allows
us to side-step the issue with a small and localized change.
Furthermore, the approach we have chosen here is IMO not that
complicated, at least not on a basic level. Written in Lisp, it would
be very straight-forward indeed, but it turned out that with the
structure of our code it was easier to just write it in C.
So I would suggest pushing my fix to emacs-28, so that we can give it as
much testing as possible. At this stage, it feels important to make
sure there is some fix on the emacs-28 branch so that we can start
testing it and gather feedback.
next prev parent reply other threads:[~2021-10-24 20:11 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:39 bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Shuguang Sun via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-23 17:15 ` Juri Linkov
2021-09-23 21:45 ` Lars Ingebrigtsen
2021-10-12 22:22 ` Stefan Kangas
2021-10-13 11:28 ` Lars Ingebrigtsen
2021-10-13 11:59 ` Eli Zaretskii
2021-10-13 12:04 ` Lars Ingebrigtsen
2021-10-13 12:19 ` Stefan Kangas
2021-10-13 12:58 ` Lars Ingebrigtsen
2021-10-13 15:26 ` Stefan Kangas
2021-10-13 15:42 ` Lars Ingebrigtsen
2021-10-19 3:22 ` Stefan Kangas
2021-10-19 3:40 ` Lars Ingebrigtsen
2021-10-19 3:52 ` Lars Ingebrigtsen
2021-10-19 11:56 ` Eli Zaretskii
2021-10-19 12:07 ` Lars Ingebrigtsen
2021-10-19 12:17 ` Lars Ingebrigtsen
2021-10-19 12:37 ` Eli Zaretskii
2021-10-19 12:45 ` Lars Ingebrigtsen
2021-10-19 13:24 ` Lars Ingebrigtsen
2021-10-19 16:01 ` Eli Zaretskii
2021-10-19 15:41 ` Eli Zaretskii
2021-10-19 15:57 ` Lars Ingebrigtsen
2021-10-19 16:12 ` Eli Zaretskii
2021-10-19 16:15 ` Lars Ingebrigtsen
2021-10-19 16:21 ` Lars Ingebrigtsen
2021-10-19 16:30 ` Eli Zaretskii
2021-10-19 17:12 ` Lars Ingebrigtsen
2021-10-19 17:37 ` Eli Zaretskii
2021-10-19 18:21 ` Lars Ingebrigtsen
2021-10-20 11:28 ` Eli Zaretskii
2021-10-20 11:55 ` Glenn Morris
2021-10-24 20:11 ` Stefan Kangas [this message]
2021-10-25 13:06 ` Lars Ingebrigtsen
2021-10-25 13:19 ` Eli Zaretskii
2021-10-25 13:21 ` Lars Ingebrigtsen
2021-10-25 13:51 ` Eli Zaretskii
2021-10-25 13:55 ` Lars Ingebrigtsen
2021-10-25 14:12 ` Eli Zaretskii
2021-10-26 8:38 ` Stefan Kangas
2021-10-26 13:04 ` Eli Zaretskii
2021-10-26 20:24 ` Stefan Kangas
2021-10-27 14:00 ` Eli Zaretskii
2021-10-28 5:29 ` Stefan Kangas
2021-10-28 7:33 ` Eli Zaretskii
2021-10-28 8:06 ` Stefan Kangas
2021-10-28 9:35 ` Eli Zaretskii
2021-10-28 10:49 ` Stefan Kangas
2021-10-28 12:49 ` Eli Zaretskii
2021-10-28 20:44 ` Stefan Kangas
2021-10-21 2:45 ` Lars Ingebrigtsen
2021-10-21 7:26 ` Eli Zaretskii
2021-10-21 13:04 ` Lars Ingebrigtsen
2021-10-20 7:45 ` Lars Ingebrigtsen
2021-10-20 12:24 ` Eli Zaretskii
2021-10-19 11:43 ` Eli Zaretskii
2021-10-19 21:54 ` Stefan Kangas
2021-10-20 12:59 ` Eli Zaretskii
2021-10-13 16:09 ` Eli Zaretskii
2021-10-15 5:59 ` Eli Zaretskii
2021-10-15 18:34 ` Stefan Kangas
2021-10-19 3:18 ` Stefan Kangas
2021-09-23 22:28 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=Oz-OZLLfAdrHkS1zzsBwE0=+q6PZ8Zd5z=Q+HTxVtVQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=50752@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=rgm@gnu.org \
--cc=shuguang79@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).