From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' Date: Tue, 19 Oct 2021 01:33:56 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24333"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51262@debbugs.gnu.org To: Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 10:35:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mckau-0006Av-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 10:35:36 +0200 Original-Received: from localhost ([::1]:34702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mckas-0004xB-TV for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 04:35:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mckaN-0004vI-4k for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mckaM-0003XC-Rb for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mckaM-0002bg-HX for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 04:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 08:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51262 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51262-submit@debbugs.gnu.org id=B51262.16346324459922 (code B ref 51262); Tue, 19 Oct 2021 08:35:02 +0000 Original-Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 08:34:05 +0000 Original-Received: from localhost ([127.0.0.1]:49362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckZQ-0002Zx-Jj for submit@debbugs.gnu.org; Tue, 19 Oct 2021 04:34:04 -0400 Original-Received: from mail-pg1-f174.google.com ([209.85.215.174]:44591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mckZO-0002ZL-OH for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 04:34:03 -0400 Original-Received: by mail-pg1-f174.google.com with SMTP id c4so11632865pgv.11 for <51262@debbugs.gnu.org>; Tue, 19 Oct 2021 01:34:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z1H1HlRfGxNyoGeoBt8tqIdccqvOvjr90a2oKzJh6NE=; b=IohRFOPvoveMSccJeTaxcY1BiAA7Mj8UCNYAJ71j16d2dR0lndzTTRbWhdd+8Ot08T 5Z+9Lfkh9lGgczbPDmmp8PXOtTjd5js18P11+9hewTM6lfCNFPxhu5l6ro3nNQrrRSfX sRCY1HwAJjfs1cr7hnwA+L1UWg2CqttX+oW/VzbEKfjrtfU0ItJVCOU69oH2NdU/pCP4 b8Vv7eEIsKCMAoCD1gljFQxZFHhyC9llsHr+6t8hHiY5PzYb3bHKIf9qXyKDcYD1rR/X Hi94fQQRVUSRrZcPbK8zRrKDXwVWLKnf20wwrmF43lY1HqiqBWhsTQVPdUJlyxDrLshs MJOg== X-Gm-Message-State: AOAM530hLbCL1FE9/5+VJ/rjrsY/Ur63u3cldNg2W9icONSGBTMkW0Kw zLPMJSVahGnhZfCC1f1mtV4JHrC5georQzc8ecI= X-Google-Smtp-Source: ABdhPJywd7za0ijviUxczKm8INB4zBr1SCxxI0E6Q3E7pWWdBwPm4KyHAFNjJCs4z0klT+RFHqCapO1aUlhR3vS5SJg= X-Received: by 2002:a05:6a00:1950:b0:44d:9402:3396 with SMTP id s16-20020a056a00195000b0044d94023396mr27114531pfk.70.1634632436758; Tue, 19 Oct 2021 01:33:56 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 Oct 2021 01:33:56 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217553 Archived-At: Jan Syn=C3=A1=C4=8Dek writes: > Sure. Sorry for not doing it earlier. For some reason, I assumed that thi= s was > obvious. Thanks. > Here's the reproducer (built from the latest commit on the emacs-28 branc= h): (I just used the emacs.git repository here.) > 7) emacs -Q > 8) > 9) > 10) > > This is what I see on my system (I hope that gmail doesn't remove the esc= apes): > > * (HEAD -> master)520684e..: Jan Synacek 2021-10-19 first commit > ^[[33mcommit 520684e773918234874a35738b094ca39b63a822^[ [m > Author: Jan Synacek > Date: Tue Oct 19 10:04:02 2021 +0200 > > first commit Here, I actually see the colours, and no escape sequences. The question is what is different in our setups. Could you post the output of M-x report-emacs-bug? Is there anything in your ~/.gitconfig that could be causing this? > It might be dependent on git configuration, but I think it's safe to assu= me that > there might be escape sequences and simply use --no-color. And that's wha= t > my patch does. I agree that you shouldn't need to see those escape sequences, but it would be better if we could narrow it down so we don't have to remove colours for everyone. The first step is to try to figure out what it is that makes you see control sequences where I get colours.