From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#71734: 30.0.50; eww interprets make errors as URLs Date: Sun, 23 Jun 2024 06:11:57 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18502"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: 71734@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 15:13:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLN1w-0004aI-Cn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 15:13:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLN1k-0005o6-7v; Sun, 23 Jun 2024 09:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLN1i-0005no-Vb for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 09:13:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLN1i-0000zg-EM for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLN1h-0002i7-Vb; Sun, 23 Jun 2024 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71734 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.171914832910330 (code B ref -1); Sun, 23 Jun 2024 13:13:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Jun 2024 13:12:09 +0000 Original-Received: from localhost ([127.0.0.1]:58724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLN0q-0002gX-Ov for submit@debbugs.gnu.org; Sun, 23 Jun 2024 09:12:09 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLN0n-0002gO-M9 for submit@debbugs.gnu.org; Sun, 23 Jun 2024 09:12:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLN0m-0005ju-Ec for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 09:12:04 -0400 Original-Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLN0k-0000lB-1Y for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 09:12:04 -0400 Original-Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2ec50d4e47bso18434021fa.2 for ; Sun, 23 Jun 2024 06:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719148318; x=1719753118; darn=gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=7fBTMW1gzziI5r8gMZ4NLN6yLfouFERuBcZrWIcu1JQ=; b=P6zABDyF5qFCVhZAINTO79C9ayReeZy0ByTEOvvDwtLh5I0p7xDGatswvWEqaXIFDl Fp7AC+bnPTgc97cin7yH0ZN6JG91Hpv1xpoH8ZE6YlFgZC47wMW1YjGegWVJHI6Or2ky 23wrA6WIXzFPyPr+ICf8P5dk2KE1G4aK48N8y/jPDWRZtMQ4JIyzqib0jf9TnKUFk21K 2B30Bp6z79jKVm6c0FtLX9zLNv40Hn1sDWY263CkOYgxgS8AB4n/Nay+/a1KaM+XLE6/ J/ddMKzpmaKajke54VkB1S61ZZAFRsfWNEBfict0WyaQlt+f7S2RYG+pu+DEb2yGYao0 r0zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719148318; x=1719753118; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7fBTMW1gzziI5r8gMZ4NLN6yLfouFERuBcZrWIcu1JQ=; b=iX6n2gabDKzPn2aMrrwjhxeQLfsmhsxoYoGtCRV/moTOgPqUXxpfkwf5N9KakEsUAU G3SpPQVVBOa9CXOe8IEYfdCKtf+c0UCRmEPhbC1NfCbbNMYAexXiCckXLAEgWVTCt97E uCdD3M6yZwG66bG6J4C67W5UOzSbSrq9U6wYfU0upcNtyA0kW4PFj4zzkaQt/tZ4yU02 oSPIy3IlpnD8z2S+1xDyd4ADbU7JnYGV1wxFhLeTzxHc5/pLMUrmYvy1TznMy/KzSn+e V191FN9vCTzYt7REou8HbcSVpqiBL5+envsNXW4/HJZcw77G3Rvqyp4fz4CMbte6zSIu RlHw== X-Gm-Message-State: AOJu0YxQCPn0m8ukTH7M5BWj07UR1jWzRRMT+549fIklGDvKimF5CYJ9 qYbNuXyVeX6LlmA/tkeKbMdMnG0tq63FmGUV7fTzRlziM5xKF49SLynS38QBgMmi4iFgJHAsTuK 0ilVZ6NJUc6xg0UMhmODngOUSEmzlA392nN0= X-Google-Smtp-Source: AGHT+IFhokDCADUSPVkJn4LFkrydto0VfryAPw2D7TofmxO0B5zfjh7UYTrxUWOycdMMRYOZmeHGhK4uKF/uBPEk3ck= X-Received: by 2002:a2e:9590:0:b0:2ec:5075:83cc with SMTP id 38308e7fff4ca-2ec5b27e833mr11432981fa.19.1719148318390; Sun, 23 Jun 2024 06:11:58 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 23 Jun 2024 06:11:57 -0700 Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=stefankangas@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287784 Archived-At: `M-x eww` currently interprets this as a URL: make: *** [Makefile:240: __sub-make] Error 2 I think this is due to the below commit: ``` commit 4113ac253456027c4b54b92a617e0c2b3003a049 Author: Lars Ingebrigtsen Date: Sun Jan 11 15:58:10 2015 +0100 Further eww URL DWIM tweaks * net/eww.el (eww): Interpret anything that looks like a protocol designator as a full URL. diff --git a/lisp/net/eww.el b/lisp/net/eww.el --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -258,29 +258,31 @@ - (if (or (string-match "\\`https?:" url) + ;; Anything that starts with something that vaguely looks + ;; like a protocol designator is interpreted as a full URL. + (if (or (string-match "\\`[A-Za-z]+:" url) ``` I think that this is much too dwim-y, and we should go back to the old code. But I have no idea why Lars made the above change in the first place, so I'd like to check here first. If the intention is to support the various protocols that Emacs supports, then we should look for exactly those and nothing else. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-06-22 built on xxxxx Repository revision: 014aab9847a0d3d898cb8cbc7224143f2d741abb Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm)