bug#74123: Add more fields to AppStream metadata

bug#74123: Add more fields to AppStream metadata

[Peter Oliver]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

Attached is a patch to add more data to emacs.metainfo.xml, based on the specification at https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-filespec

-- 
Peter Oliver

[-- Attachment #2: Type: text/plain, Size: 1344 bytes --]

From 1f3f7290955900842582f5c0afceba8bcf18066f Mon Sep 17 00:00:00 2001
From: Peter Oliver <git@mavit.org.uk>
Date: Wed, 30 Oct 2024 22:15:59 +0000
Subject: [PATCH] Add more fields to AppStream metadata

* etc/emacs.metainfo.xml: Populate the vcs-browser and contribute URLs,
as well as the branding colour.
---
 etc/emacs.metainfo.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/etc/emacs.metainfo.xml b/etc/emacs.metainfo.xml
index 80bbd690217..7e97df926be 100644
--- a/etc/emacs.metainfo.xml
+++ b/etc/emacs.metainfo.xml
@@ -33,6 +33,8 @@
  <url type="help">https://www.gnu.org/software/emacs/documentation.html</url>
  <url type="donation">https://my.fsf.org/donate/</url>
  <url type="contact">https://lists.gnu.org/mailman/listinfo/emacs-devel/</url>
+ <url type="vcs-browser">https://git.savannah.gnu.org/cgit/emacs.git</url>
+ <url type="contribute">https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html</url>
  <launchable type="desktop-id">emacs.desktop</launchable>
  <launchable type="service">emacs.service</launchable>
  <project_group>GNU</project_group>
@@ -45,4 +47,7 @@
   </screenshot>
  </screenshots>
  <update_contact>emacs-devel_AT_gnu.org</update_contact>
+ <branding>
+   <color type="primary">#7f5ab6</color>
+ </branding>
 </component>
-- 
2.47.0

bug#74123: Add more fields to AppStream metadata

[Eli Zaretskii]

> Date: Wed, 30 Oct 2024 22:22:10 +0000 (GMT)
> From: Peter Oliver <p.d.oliver@mavit.org.uk>
> 
> Attached is a patch to add more data to emacs.metainfo.xml, based on the specification at https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-filespec

Could you please explain why you have chosen that particular color for
<branding>?  Should we have separate colors for the light and dark
color schemes, for example?

Thanks.

bug#74123: Add more fields to AppStream metadata

[Peter Oliver]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Thu, 31 Oct 2024, Eli Zaretskii wrote:

> Could you please explain why you have chosen that particular color for
> <branding>?  Should we have separate colors for the light and dark
> color schemes, for example?

I took it from the website https://www.gnu.org/software/emacs/.

Here are a few other possible combinations taken from the website.  I have attached an image demonstrating them behind the Emacs icon.

  <branding>
    <color type="primary" scheme_preference="light">#7f5ab6</color>
    <color type="primary" scheme_preference="dark">#624195</color>
  </branding>

  <branding>
    <color type="primary" scheme_preference="light">#f4f2e9</color>
    <color type="primary" scheme_preference="dark">#624195</color>
  </branding>

  <branding>
    <color type="primary" scheme_preference="light">#f4f2e9</color>
    <color type="primary" scheme_preference="dark">#7f5ab6</color>
  </branding>

-- 
Peter Oliver

[-- Attachment #2: Type: image/png, Size: 48455 bytes --]

bug#74123: Add more fields to AppStream metadata

[Stefan Kangas]

Peter Oliver <p.d.oliver@mavit.org.uk> writes:

> Here are a few other possible combinations taken from the website.  I have attached an image demonstrating them behind the Emacs icon.
>
>   <branding>
>     <color type="primary" scheme_preference="light">#7f5ab6</color>
>     <color type="primary" scheme_preference="dark">#624195</color>
>   </branding>

I guess this is the top one in your screenshot?

This color scheme looks fine to me, FWIW.