From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#8951: 24.0.50; [PATCH] enhancement request: buttonize key names Date: Fri, 22 Oct 2021 17:46:24 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000018a58905cefa75ec" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2232"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 8951@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 23 02:47:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1me5Bn-0000Nh-NS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Oct 2021 02:47:11 +0200 Original-Received: from localhost ([::1]:52234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1me5Bm-0002Pe-D3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Oct 2021 20:47:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1me5Be-0002NE-W8 for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1me5Be-0008Pu-Ni for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1me5Be-0002Th-GA for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Oct 2021 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8951 X-GNU-PR-Package: emacs Original-Received: via spool by 8951-submit@debbugs.gnu.org id=B8951.16349499989492 (code B ref 8951); Sat, 23 Oct 2021 00:47:02 +0000 Original-Received: (at 8951) by debbugs.gnu.org; 23 Oct 2021 00:46:38 +0000 Original-Received: from localhost ([127.0.0.1]:34035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me5BF-0002T2-QP for submit@debbugs.gnu.org; Fri, 22 Oct 2021 20:46:38 -0400 Original-Received: from mail-pl1-f176.google.com ([209.85.214.176]:39609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me5B9-0002ST-2k for 8951@debbugs.gnu.org; Fri, 22 Oct 2021 20:46:34 -0400 Original-Received: by mail-pl1-f176.google.com with SMTP id t21so3877111plr.6 for <8951@debbugs.gnu.org>; Fri, 22 Oct 2021 17:46:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=XE6xx6ELq1CKAt75FlLlzWQFR6dxwra5tqMppmUdNXU=; b=WYSo3Kkm/+yNuWvQzLQCm89sVqmvZJonEj2/ZuqF7sG0dUNC/CLbFJj5e94dbII9BL 1DRZe71pkiH2ZdQoHItR4Hib/llaph8sm6CDvWd5JCUoZ9adDfi44EC6eW3qP4KqSByg tEIV9cb0fFEqCIQYb2Z8UT00HNCb1qkuWvFyffbm5rmFVwn1inBbjwr7Wo/81Q+hxImD Kqx6PcnJdJcyJk2ieEhWcm9diY4pZft1DKGA5enml33OHN8Sdae8g2WfYflC2frP/FW1 dbVB1TGX9QmepvB4CRk55oL6rOkNmzV+Eoui0T3OGdd/G1j5NM1Pj3qh65N4lqqoolQQ zEUA== X-Gm-Message-State: AOAM530kVq3XdpSB0t7Pa/Imd4789bK/dqGs52WPHw64RwMWNEeldrbC 5xpEkUze5meAY0Eep6PCmftBia0DqvpxCzB3iL4= X-Google-Smtp-Source: ABdhPJx8zy+Q3UxDdl/2ZdwIfPAIn82v0jsKWRKrkO4lyRIIPIcwg/bschyTlbJtOdnghygtLoLPIBhVXAdP7J7HH8A= X-Received: by 2002:a17:90a:245:: with SMTP id t5mr3425623pje.133.1634949985242; Fri, 22 Oct 2021 17:46:25 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 22 Oct 2021 17:46:24 -0700 In-Reply-To: (Stefan Monnier's message of "Mon, 04 Jul 2011 16:28:33 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217930 Archived-At: --00000000000018a58905cefa75ec Content-Type: text/plain; charset="UTF-8" tags 8951 + patch thanks Stefan Monnier writes: >> What is the feature? Let users click a key description (i.e., a >> key name, such as `C-f') in a buffer such as *Help* to see the >> associated help. This applies to key descriptions derived from >> \[...] doc patterns (only). > > That looks like a good idea. Have you tried to plug it directly into > substitute-command-keys instead? Are there places where such buttons > become annoying? (I have had a patch sitting around for a while, but it failed bootstrap. It turns out that the fix was a simple `fboundp', heh.) The attached patch adds a new option `help-mode--add-function-link' that when non-nil makes `substitute-command-keys' add a link to the `describe-function' for the bound command when inserting keys. I have reconsidered my previously held opinion that this should be off by default. From using this patch, I have come to the conclusion that this position is wrong, as this is in fact highly useful in places such as `M-x ibuffer RET C-h m' and on many other help screen besides. The only adverse effect of enabling it, furthermore, is that you might have to hit TAB a couple of times more on some help screens. So I think having it on by default is very much a good thing. --00000000000018a58905cefa75ec Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Add-new-option-help-link-key-to-documentation.patch" Content-Disposition: attachment; filename="0001-Add-new-option-help-link-key-to-documentation.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 13bf0b06baa4ba80_0.1 RnJvbSBiNGJmMzRhY2FiYTk4ZGRlYWU2Zjk3MzU1YjY3ZGE1ZDJhYzEzZTkxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogRnJpLCA1IE1hciAyMDIxIDAyOjQ5OjA3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG5l dyBvcHRpb24gaGVscC1saW5rLWtleS10by1kb2N1bWVudGF0aW9uCgoqIGxpc3AvaGVscC5lbCAo aGVscC1saW5rLWtleS10by1kb2N1bWVudGF0aW9uKTogTmV3IHVzZXIgb3B0aW9uLgooc3Vic3Rp dHV0ZS1jb21tYW5kLWtleXMpOiBBZGQgbGluayBmcm9tIGtleXMgdG8gdGhlIGNvbW1hbmQgdGhl eQphcmUgYm91bmQgdG8gaWYgdGhlIGFib3ZlIG5ldyBvcHRpb24gaXMgbm9uLW5pbC4gIChCdWcj ODk1MSkKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhlIG5ldyBvcHRpb24uCi0tLQogZXRjL05FV1Mg ICAgICAgICAgfCAgOCArKysrKysrKwogbGlzcC9oZWxwLW1vZGUuZWwgfCAgNyArKysrKysrCiBs aXNwL2hlbHAuZWwgICAgICB8IDE3ICsrKysrKysrKysrKysrKystCiAzIGZpbGVzIGNoYW5nZWQs IDMxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBi L2V0Yy9ORVdTCmluZGV4IDM2ZDA0YWEyZDguLmFjYjZjNjUzZGIgMTAwNjQ0Ci0tLSBhL2V0Yy9O RVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xMzYsNiArMTM2LDE0IEBAIGZ1bmN0aW9uIHdoaWNoIHJl dHVybnMgYSBzdHJpbmcuICBGb3IgdGhlIGZpcnN0IHR3byBjYXNlcywgdGhlIGxlbmd0aAogb2Yg dGhlIHJlc3VsdGluZyBuYW1lIGlzIGNvbnRyb2xsZWQgYnkgJ2V3dy1idWZmZXItbmFtZS1sZW5n dGgnLiAgQnkKIGRlZmF1bHQsIG5vIGF1dG9tYXRpYyByZW5hbWluZyBpcyBwZXJmb3JtZWQuCiAK KyoqIGhlbHAKKworKioqIE5ldyB1c2VyIG9wdGlvbiBgaGVscC1saW5rLWtleS10by1kb2N1bWVu dGF0aW9uJy4KK1doZW4gdGhpcyBvcHRpb24gaXMgbm9uLW5pbCwga2V5IGJpbmRpbmdzIGRpc3Bs YXllZCBpbiB0aGUgKkhlbHAqCitidWZmZXIgd2lsbCBiZSBsaW5rZWQgdG8gdGhlIGRvY3VtZW50 YXRpb24gZm9yIHRoZSBjb21tYW5kIHRoZXkgYXJlCitib3VuZCB0by4gIFRoaXMgZG9lcyBub3Qg YWZmZWN0IGxpc3RpbmdzIG9mIGtleSBiaW5kaW5ncyBhbmQKK2Z1bmN0aW9ucy4KKwogKiogaW1h Z2UtZGlyZWQKIAogLS0tCmRpZmYgLS1naXQgYS9saXNwL2hlbHAtbW9kZS5lbCBiL2xpc3AvaGVs cC1tb2RlLmVsCmluZGV4IGQ2MWIxYmRjNjIuLjUzYWNiZjk3ZTcgMTAwNjQ0Ci0tLSBhL2xpc3Av aGVscC1tb2RlLmVsCisrKyBiL2xpc3AvaGVscC1tb2RlLmVsCkBAIC0zNzYsNiArMzc2LDEzIEBA ICdoZWxwLW5ld3MKICAgICAodmlldy1idWZmZXItb3RoZXItd2luZG93IChmaW5kLWZpbGUtbm9z ZWxlY3QgZmlsZSkpCiAgICAgKGdvdG8tY2hhciBwb3MpKQogICAnaGVscC1lY2hvIChwdXJlY29w eSAibW91c2UtMiwgUkVUOiBzaG93IGNvcnJlc3BvbmRpbmcgTkVXUyBhbm5vdW5jZW1lbnQiKSkK KworOzs7IyMjYXV0b2xvYWQKKyhkZWZ1biBoZWxwLW1vZGUtLWFkZC1mdW5jdGlvbi1saW5rIChz dHIgZnVuKQorICAobWFrZS10ZXh0LWJ1dHRvbiAoY29weS1zZXF1ZW5jZSBzdHIpIG5pbAorICAg ICAgICAgICAgICAgICAgICAndHlwZSAnaGVscC1mdW5jdGlvbgorICAgICAgICAgICAgICAgICAg ICAnaGVscC1hcmdzIChsaXN0IGZ1bikpKQorCiAMCiAoZGVmdmFyIGJvb2ttYXJrLW1ha2UtcmVj b3JkLWZ1bmN0aW9uKQogKGRlZnZhciBoZWxwLW1vZGUtLWN1cnJlbnQtZGF0YSBuaWwpCmRpZmYg LS1naXQgYS9saXNwL2hlbHAuZWwgYi9saXNwL2hlbHAuZWwKaW5kZXggYTVkNTAzN2JmZS4uMDNj NWI4ZTIzMCAxMDA2NDQKLS0tIGEvbGlzcC9oZWxwLmVsCisrKyBiL2xpc3AvaGVscC5lbApAQCAt MTA1OCw2ICsxMDU4LDE0IEBAIGxvb2t1cC1taW5vci1tb2RlLWZyb20taW5kaWNhdG9yCiAgICAg cmVzdWx0KSkKIAogDAorKGRlZmN1c3RvbSBoZWxwLWxpbmsta2V5LXRvLWRvY3VtZW50YXRpb24g dAorICAiTm9uLW5pbCBtZWFucyBsaW5rIGtleXMgdG8gdGhlaXIgY29tbWFuZCBpbiAqSGVscCog YnVmZmVycy4KK1RoaXMgYWZmZWN0cyBcXFxcPVxcW2NvbW1hbmRdIHN1YnN0aXR1dGlvbnMgaW4g ZG9jdW1lbnRhdGlvbgorc3RyaW5ncyBkb25lIGJ5IGBzdWJzdGl0dXRlLWNvbW1hbmQta2V5cycu IgorICA6dHlwZSAnYm9vbGVhbgorICA6dmVyc2lvbiAiMjkuMSIKKyAgOmdyb3VwICdoZWxwKQor CiAoZGVmdW4gc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMgKHN0cmluZykKICAgIlN1YnN0aXR1dGUg a2V5IGRlc2NyaXB0aW9ucyBmb3IgY29tbWFuZCBuYW1lcyBpbiBTVFJJTkcuCiBFYWNoIHN1YnN0 cmluZyBvZiB0aGUgZm9ybSBcXFxcPVtDT01NQU5EXSBpcyByZXBsYWNlZCBieSBlaXRoZXIgYQpA QCAtMTE0NSw3ICsxMTUzLDE0IEBAIHN1YnN0aXR1dGUtY29tbWFuZC1rZXlzCiAgICAgICAgICAg ICAgICAgICAgICAgICAoZGVsZXRlLWNoYXIgMSkpCiAgICAgICAgICAgICAgICAgICAgIDs7IEZ1 bmN0aW9uIGlzIG9uIGEga2V5LgogICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWNoYXIgKC0g ZW5kLXBvaW50IChwb2ludCkpKQotICAgICAgICAgICAgICAgICAgICAoaW5zZXJ0IChoZWxwLS1r ZXktZGVzY3JpcHRpb24tZm9udGlmaWVkIGtleSkpKSkpCisgICAgICAgICAgICAgICAgICAgIChs ZXQgKChrZXkgKGhlbHAtLWtleS1kZXNjcmlwdGlvbi1mb250aWZpZWQga2V5KSkpCisgICAgICAg ICAgICAgICAgICAgICAgKGluc2VydCAoaWYgKGFuZCBoZWxwLWxpbmsta2V5LXRvLWRvY3VtZW50 YXRpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmdW5jdGlvbnAg ZnVuKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBUaGUgYGZib3VuZHAn IGZpeGVzIGJvb3RzdHJhcDoKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYg KGZib3VuZHAgJ2hlbHAtbW9kZS0tYWRkLWZ1bmN0aW9uLWxpbmspCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChoZWxwLW1vZGUtLWFkZC1mdW5jdGlvbi1saW5rIGtleSBm dW4pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBrZXkpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGtleSkpKSkpKQogICAgICAgICAgICAgICAgOzsgMUQuIFx7 Zm9vfSBpcyByZXBsYWNlZCB3aXRoIGEgc3VtbWFyeSBvZiB0aGUga2V5bWFwCiAgICAgICAgICAg ICAgICA7OyAgICAgICAgICAgIChzeW1ib2wtdmFsdWUgZm9vKS4KICAgICAgICAgICAgICAgIDs7 ICAgICBcPGZvbz4ganVzdCBzZXRzIHRoZSBrZXltYXAgdXNlZCBmb3IgXFtjbWRdLgotLSAKMi4z MC4yCgo= --00000000000018a58905cefa75ec--